From: "Juha-Pekka Heikkilä" <juha-pekka.heikkila@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
<igt-dev@lists.freedesktop.org>,
Vinod Govindapillai <vinod.govindapillai@intel.com>,
<bhanuprakash.modem@intel.com>, <jani.saarinen@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/kms_big_fb: Fix width calculation while creating the intel buf
Date: Wed, 8 May 2024 21:39:24 +0300 [thread overview]
Message-ID: <778e52d6-b3f8-4764-bd2b-1d3efd7912f9@intel.com> (raw)
In-Reply-To: <20240508151300.it6pnyauxeq6tyed@kamilkon-DESK.igk.intel.com>
@Vinod, can you add here comment this patch partially revert changes
done in bfa3db0cd9e9a11c0eeaf40a2743c5e2e0f24d2c
On 8.5.2024 18.13, Kamil Konieczny wrote:
> Hi Vinod,
> On 2024-05-07 at 15:30:26 +0300, Vinod Govindapillai wrote:
>> From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>
>
> Please add description here.
>
> Regards,
> Kamil
>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
>> ---
>> lib/igt_draw.c | 2 +-
>> tests/intel/kms_big_fb.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
>> index 2c01d7b02..97a7e6b37 100644
>> --- a/lib/igt_draw.c
>> +++ b/lib/igt_draw.c
>> @@ -650,7 +650,7 @@ static struct intel_buf *create_buf(int fd, struct buf_ops *bops,
>> uint64_t region = driver == INTEL_DRIVER_XE ? vram_if_possible(fd, 0) : -1;
>> uint64_t size = from->size;
>>
>> - width = from->width;
>> + width = from->stride / (from->bpp / 8);
>> height = from->height;
>> if (driver == INTEL_DRIVER_XE)
>> size = ALIGN(size, xe_get_default_alignment(fd));
>> diff --git a/tests/intel/kms_big_fb.c b/tests/intel/kms_big_fb.c
>> index f7f303d41..1e45d8e42 100644
>> --- a/tests/intel/kms_big_fb.c
>> +++ b/tests/intel/kms_big_fb.c
>> @@ -199,7 +199,7 @@ static struct intel_buf *init_buf(data_t *data,
>> tiling = igt_fb_mod_to_tiling(fb->modifier);
>> bpp = fb->plane_bpp[0];
>> size = fb->size;
>> - width = fb->width;
>> + width = fb->strides[0] / (bpp / 8);
>> height = fb->height;
>>
>> name = gem_flink(data->drm_fd, fb->gem_handle);
>> --
>> 2.34.1
>>
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2024-05-08 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 12:30 [PATCH i-g-t] tests/intel/kms_big_fb: Fix width calculation while creating the intel buf Vinod Govindapillai
2024-05-07 12:34 ` Juha-Pekka Heikkila
2024-05-07 19:14 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-05-08 6:33 ` Saarinen, Jani
2024-05-07 19:55 ` ✓ CI.xeBAT: success " Patchwork
2024-05-08 4:00 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-08 15:13 ` [PATCH i-g-t] " Kamil Konieczny
2024-05-08 18:39 ` Juha-Pekka Heikkilä [this message]
2024-05-09 9:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-05-09 21:44 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=778e52d6-b3f8-4764-bd2b-1d3efd7912f9@intel.com \
--to=juha-pekka.heikkila@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox