From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Vinod Govindapillai <vinod.govindapillai@intel.com>,
igt-dev@lists.freedesktop.org
Cc: bhanuprakash.modem@intel.com, juha-pekka.heikkila@intel.com,
jani.saarinen@intel.com
Subject: Re: [PATCH i-g-t] tests/intel/kms_big_fb: Fix width calculation while creating the intel buf
Date: Tue, 7 May 2024 15:34:58 +0300 [thread overview]
Message-ID: <def81b7d-2443-4d39-8724-752d30a55090@gmail.com> (raw)
In-Reply-To: <20240507123026.57575-1-vinod.govindapillai@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 7.5.2024 15.30, Vinod Govindapillai wrote:
> From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
> lib/igt_draw.c | 2 +-
> tests/intel/kms_big_fb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index 2c01d7b02..97a7e6b37 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -650,7 +650,7 @@ static struct intel_buf *create_buf(int fd, struct buf_ops *bops,
> uint64_t region = driver == INTEL_DRIVER_XE ? vram_if_possible(fd, 0) : -1;
> uint64_t size = from->size;
>
> - width = from->width;
> + width = from->stride / (from->bpp / 8);
> height = from->height;
> if (driver == INTEL_DRIVER_XE)
> size = ALIGN(size, xe_get_default_alignment(fd));
> diff --git a/tests/intel/kms_big_fb.c b/tests/intel/kms_big_fb.c
> index f7f303d41..1e45d8e42 100644
> --- a/tests/intel/kms_big_fb.c
> +++ b/tests/intel/kms_big_fb.c
> @@ -199,7 +199,7 @@ static struct intel_buf *init_buf(data_t *data,
> tiling = igt_fb_mod_to_tiling(fb->modifier);
> bpp = fb->plane_bpp[0];
> size = fb->size;
> - width = fb->width;
> + width = fb->strides[0] / (bpp / 8);
> height = fb->height;
>
> name = gem_flink(data->drm_fd, fb->gem_handle);
next prev parent reply other threads:[~2024-05-07 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 12:30 [PATCH i-g-t] tests/intel/kms_big_fb: Fix width calculation while creating the intel buf Vinod Govindapillai
2024-05-07 12:34 ` Juha-Pekka Heikkila [this message]
2024-05-07 19:14 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-05-08 6:33 ` Saarinen, Jani
2024-05-07 19:55 ` ✓ CI.xeBAT: success " Patchwork
2024-05-08 4:00 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-08 15:13 ` [PATCH i-g-t] " Kamil Konieczny
2024-05-08 18:39 ` Juha-Pekka Heikkilä
2024-05-09 9:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-05-09 21:44 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=def81b7d-2443-4d39-8724-752d30a55090@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.saarinen@intel.com \
--cc=juha-pekka.heikkila@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox