[igt-dev] [PATCH i-g-t] Revert VDSC lib changes

[igt-dev] [PATCH i-g-t] Revert VDSC lib changes

[Swati Sharma]

This reverts
    commit 2a611c37bd170763052bf6c17aa2d48cf09a63c1
    commit 65202cbc6109f17cf786a95947f4ee9223aec6b8
    commit b6984b946ba66f6bb0452b223fe188429ddeab34
    commit bbc2a5ceadb656552c5bcf95a19ce2b292a78128

Series broke git pipeline, revert above commits.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 lib/igt.h                   |   1 -
 lib/igt_dsc.c               | 133 ----------------------------------
 lib/igt_dsc.h               |  19 -----
 lib/igt_kms.c               | 127 +++++++++++++++++++++++++++++++++
 lib/igt_kms.h               |  10 +++
 lib/meson.build             |   1 -
 tests/i915/kms_dsc.c        | 137 ++++++++++++++++++++++++++++++++----
 tests/i915/kms_dsc_helper.c |  99 --------------------------
 tests/i915/kms_dsc_helper.h |  35 ---------
 tests/meson.build           |   9 +--
 10 files changed, 263 insertions(+), 308 deletions(-)
 delete mode 100644 lib/igt_dsc.c
 delete mode 100644 lib/igt_dsc.h
 delete mode 100644 tests/i915/kms_dsc_helper.c
 delete mode 100644 tests/i915/kms_dsc_helper.h

diff --git a/lib/igt.h b/lib/igt.h
index 73b6f7727..88938109e 100644
--- a/lib/igt.h
+++ b/lib/igt.h
@@ -40,7 +40,6 @@
 #include "igt_pipe_crc.h"
 #include "igt_pm.h"
 #include "igt_stats.h"
-#include "igt_dsc.h"
 #ifdef HAVE_CHAMELIUM
 #include "igt_alsa.h"
 #include "igt_audio.h"
diff --git a/lib/igt_dsc.c b/lib/igt_dsc.c
deleted file mode 100644
index 25dcb5840..000000000
--- a/lib/igt_dsc.c
+++ /dev/null
@@ -1,133 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#include <unistd.h>
-#include <fcntl.h>
-#include <string.h>
-#include "igt_dsc.h"
-#include "igt_sysfs.h"
-
-static bool check_dsc_debugfs(int drmfd, char *connector_name, const char *check_str)
-{
-	char file_name[128] = {0};
-	char buf[512];
-
-	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
-
-	igt_debugfs_read(drmfd, file_name, buf);
-
-	return strstr(buf, check_str);
-}
-
-static int write_dsc_debugfs(int drmfd, char *connector_name, const char *file_name,
-			     const char *write_buf)
-{
-	int debugfs_fd = igt_debugfs_dir(drmfd);
-	int len = strlen(write_buf);
-	int ret;
-	char file_path[128] = {0};
-
-	sprintf(file_path, "%s/%s", connector_name, file_name);
-
-	ret = igt_sysfs_write(debugfs_fd, file_path, write_buf, len);
-
-	close(debugfs_fd);
-
-	return ret;
-}
-
-/*
- * igt_is_dsc_supported:
- * @drmfd: A drm file descriptor
- * @connector_name: Name of the libdrm connector we're going to use
- *
- * Returns: True if DSC is supported for the given connector, false otherwise.
- */
-bool igt_is_dsc_supported(int drmfd, char *connector_name)
-{
-	return check_dsc_debugfs(drmfd, connector_name, "DSC_Sink_Support: yes");
-}
-
-/*
- * igt_is_fec_supported:
- * @drmfd: A drm file descriptor
- * @connector_name: Name of the libdrm connector we're going to use
- *
- * Returns: True if FEC is supported for the given connector, false otherwise.
- */
-bool igt_is_fec_supported(int drmfd, char *connector_name)
-{
-	return check_dsc_debugfs(drmfd, connector_name, "FEC_Sink_Support: yes");
-}
-
-/*
- * igt_is_dsc_enabled:
- * @drmfd: A drm file descriptor
- * @connector_name: Name of the libdrm connector we're going to use
- *
- * Returns: True if DSC is enabled for the given connector, false otherwise.
- */
-bool igt_is_dsc_enabled(int drmfd, char *connector_name)
-{
-	return check_dsc_debugfs(drmfd, connector_name, "DSC_Enabled: yes");
-}
-
-/*
- * igt_is_force_dsc_enabled:
- * @drmfd: A drm file descriptor
- * @connector_name: Name of the libdrm connector we're going to use
- *
- * Returns: True if DSC is force enabled (via debugfs) for the given connector,
- * false otherwise.
- */
-bool igt_is_force_dsc_enabled(int drmfd, char *connector_name)
-{
-	return check_dsc_debugfs(drmfd, connector_name, "Force_DSC_Enable: yes");
-}
-
-/*
- * igt_force_dsc_enable:
- * @drmfd: A drm file descriptor
- * @connector_name: Name of the libdrm connector we're going to use
- *
- * Returns: 1 on success or negative error code, in case of failure.
- */
-int igt_force_dsc_enable(int drmfd, char *connector_name)
-{
-	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_fec_support", "1");
-}
-
-/*
- * igt_force_dsc_enable_bpc:
- * @drmfd: A drm file descriptor
- * @connector_name: Name of the libdrm connector we're going to use
- * @bpc: Input BPC
- *
- * Returns: No. of bytes written or negative error code, in case of failure.
- */
-int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc)
-{
-	char buf[20] = {0};
-
-	sprintf(buf, "%d", bpc);
-
-	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_bpc", buf);
-}
-
-/*
- * igt_get_dsc_debugfs_fd:
- * @drmfd: A drm file descriptor
- * @connector_name: Name of the libdrm connector we're going to use
- *
- * Returns: fd of the DSC debugfs for the given connector, else returns -1.
- */
-int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name)
-{
-	char file_name[128] = {0};
-
-	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
-
-	return openat(igt_debugfs_dir(drmfd), file_name, O_WRONLY);
-}
diff --git a/lib/igt_dsc.h b/lib/igt_dsc.h
deleted file mode 100644
index 291c2cdea..000000000
--- a/lib/igt_dsc.h
+++ /dev/null
@@ -1,19 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#ifndef IGT_DSC_H
-#define IGT_DSC_H
-
-#include "igt_fb.h"
-
-bool igt_is_dsc_supported(int drmfd, char *connector_name);
-bool igt_is_fec_supported(int drmfd, char *connector_name);
-bool igt_is_dsc_enabled(int drmfd, char *connector_name);
-bool igt_is_force_dsc_enabled(int drmfd, char *connector_name);
-int igt_force_dsc_enable(int drmfd, char *connector_name);
-int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc);
-int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name);
-
-#endif
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 31e6dfda0..b4a98ae17 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -5564,6 +5564,133 @@ void igt_dump_crtcs_fd(int drmfd)
 	drmModeFreeResources(mode_resources);
 }
 
+static
+bool check_dsc_debugfs(int drmfd, char *connector_name,
+		       const char *check_str)
+{
+	char file_name[128] = {0};
+	char buf[512];
+
+	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
+
+	igt_debugfs_read(drmfd, file_name, buf);
+
+	return strstr(buf, check_str);
+}
+
+static
+int write_dsc_debugfs(int drmfd, char *connector_name,
+		      const char *file_name,
+		      const char *write_buf)
+{
+	int debugfs_fd = igt_debugfs_dir(drmfd);
+	int len = strlen(write_buf);
+	int ret;
+	char file_path[128] = {0};
+
+	sprintf(file_path, "%s/%s", connector_name, file_name);
+
+	ret = igt_sysfs_write(debugfs_fd, file_path, write_buf, len);
+
+	close(debugfs_fd);
+
+	return ret;
+}
+
+/*
+ * igt_is_dsc_supported:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: True if DSC is supported for the given connector, false otherwise.
+ */
+bool igt_is_dsc_supported(int drmfd, char *connector_name)
+{
+	return check_dsc_debugfs(drmfd, connector_name, "DSC_Sink_Support: yes");
+}
+
+/*
+ * igt_is_fec_supported:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: True if FEC is supported for the given connector, false otherwise.
+ */
+bool igt_is_fec_supported(int drmfd, char *connector_name)
+{
+	return check_dsc_debugfs(drmfd, connector_name, "FEC_Sink_Support: yes");
+}
+
+/*
+ * igt_is_dsc_enabled:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: True if DSC is enabled for the given connector, false otherwise.
+ */
+bool igt_is_dsc_enabled(int drmfd, char *connector_name)
+{
+	return check_dsc_debugfs(drmfd, connector_name, "DSC_Enabled: yes");
+}
+
+/*
+ * igt_is_force_dsc_enabled:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: True if DSC is force enabled (via debugfs) for the given connector,
+ * false otherwise.
+ */
+bool igt_is_force_dsc_enabled(int drmfd, char *connector_name)
+{
+	return check_dsc_debugfs(drmfd, connector_name, "Force_DSC_Enable: yes");
+}
+
+/*
+ * igt_force_dsc_enable:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: 1 on success or negative error code, in case of failure.
+ */
+int igt_force_dsc_enable(int drmfd, char *connector_name)
+{
+	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_fec_support", "1");
+}
+
+/*
+ * igt_force_dsc_enable_bpc:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ * @bpc: Input BPC
+ *
+ * Returns: No. of bytes written or negative error code, in case of failure.
+ */
+int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc)
+{
+	char buf[20] = {0};
+
+	sprintf(buf, "%d", bpc);
+
+	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_bpc", buf);
+}
+
+/*
+ * igt_get_dsc_debugfs_fd:
+ * @drmfd: A drm file descriptor
+ * @connector_name: Name of the libdrm connector we're going to use
+ *
+ * Returns: fd of the DSC debugfs for the given connector, else returns -1.
+ */
+int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name)
+{
+	char file_name[128] = {0};
+
+	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
+
+	return openat(igt_debugfs_dir(drmfd), file_name, O_WRONLY);
+}
+
 /*
  * igt_get_output_max_bpc:
  * @drmfd: A drm file descriptor
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index be5482e08..7a00d2045 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -974,6 +974,16 @@ void igt_require_pipe(igt_display_t *display,
 void igt_dump_connectors_fd(int drmfd);
 void igt_dump_crtcs_fd(int drmfd);
 bool igt_override_all_active_output_modes_to_fit_bw(igt_display_t *display);
+
+bool igt_is_dsc_supported(int drmfd, char *connector_name);
+bool igt_is_fec_supported(int drmfd, char *connector_name);
+bool igt_is_dsc_enabled(int drmfd, char *connector_name);
+bool igt_is_force_dsc_enabled(int drmfd, char *connector_name);
+int igt_force_dsc_enable(int drmfd, char *connector_name);
+int igt_force_dsc_enable_bpc(int drmfd, char *connector_name,
+			     int bpc);
+int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name);
+
 unsigned int igt_get_output_max_bpc(int drmfd, char *connector_name);
 unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe);
 void igt_assert_output_bpc_equal(int drmfd, enum pipe pipe,
diff --git a/lib/meson.build b/lib/meson.build
index 4e5b08bcd..cc7846869 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -96,7 +96,6 @@ lib_sources = [
 	'igt_infoframe.c',
 	'veboxcopy_gen12.c',
 	'igt_msm.c',
-	'igt_dsc.c',
 ]
 
 lib_deps = [
diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
index 8f32ae950..330fc050b 100644
--- a/tests/i915/kms_dsc.c
+++ b/tests/i915/kms_dsc.c
@@ -29,8 +29,22 @@
  * Manasi Navare <manasi.d.navare@intel.com>
  *
  */
-
-#include "kms_dsc_helper.h"
+#include "igt.h"
+#include "igt_sysfs.h"
+#include <errno.h>
+#include <getopt.h>
+#include <math.h>
+#include <stdint.h>
+#include <stdbool.h>
+#include <strings.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <signal.h>
+#include <time.h>
+#include <fcntl.h>
+#include <termios.h>
+
+#define HDISPLAY_5K	5120
 
 IGT_TEST_DESCRIPTION("Test to validate display stream compression");
 
@@ -47,10 +61,12 @@ typedef struct {
 	igt_output_t *output;
 	int input_bpc;
 	int n_pipes;
-	int disp_ver;
 	enum pipe pipe;
 } data_t;
 
+bool force_dsc_en_orig;
+int force_dsc_restore_fd = -1;
+
 const struct {
 	const int format;
 	const char format_str[20];
@@ -68,6 +84,56 @@ static inline void manual(const char *expected)
 	igt_debug_interactive_mode_check("all", expected);
 }
 
+static void force_dsc_enable(data_t *data)
+{
+	int ret;
+
+	igt_debug("Forcing DSC enable on %s\n", data->output->name);
+	ret = igt_force_dsc_enable(data->drm_fd,
+				   data->output->name);
+	igt_assert_f(ret > 0, "debugfs_write failed");
+}
+
+static void force_dsc_enable_bpc(data_t *data)
+{
+	int ret;
+
+	igt_debug("Forcing input DSC BPC to %d on %s\n",
+		  data->input_bpc, data->output->name);
+	ret = igt_force_dsc_enable_bpc(data->drm_fd,
+				       data->output->name,
+				       data->input_bpc);
+	igt_assert_f(ret > 0, "debugfs_write failed");
+}
+
+static void save_force_dsc_en(data_t *data)
+{
+	force_dsc_en_orig =
+		igt_is_force_dsc_enabled(data->drm_fd,
+					 data->output->name);
+	force_dsc_restore_fd =
+		igt_get_dsc_debugfs_fd(data->drm_fd,
+				       data->output->name);
+	igt_assert(force_dsc_restore_fd >= 0);
+}
+
+static void restore_force_dsc_en(void)
+{
+	if (force_dsc_restore_fd < 0)
+		return;
+
+	igt_debug("Restoring DSC enable\n");
+	igt_assert(write(force_dsc_restore_fd, force_dsc_en_orig ? "1" : "0", 1) == 1);
+
+	close(force_dsc_restore_fd);
+	force_dsc_restore_fd = -1;
+}
+
+static void kms_dsc_exit_handler(int sig)
+{
+	restore_force_dsc_en();
+}
+
 static drmModeModeInfo *get_highres_mode(igt_output_t *output)
 {
 	drmModeConnector *connector = output->config.connector;
@@ -80,6 +146,26 @@ static drmModeModeInfo *get_highres_mode(igt_output_t *output)
 	return highest_mode;
 }
 
+static bool check_dsc_on_connector(data_t *data)
+{
+	igt_output_t *output = data->output;
+
+	if (!igt_is_dsc_supported(data->drm_fd, output->name)) {
+		igt_debug("DSC not supported on connector %s\n",
+			  output->name);
+		return false;
+	}
+
+	if (!output_is_internal_panel(output) &&
+	    !igt_is_fec_supported(data->drm_fd, output->name)) {
+		igt_debug("DSC cannot be enabled without FEC on %s\n",
+			  output->name);
+		return false;
+	}
+
+	return true;
+}
+
 static bool check_big_joiner_pipe_constraint(data_t *data)
 {
 	igt_output_t *output = data->output;
@@ -95,6 +181,34 @@ static bool check_big_joiner_pipe_constraint(data_t *data)
 	return true;
 }
 
+static bool check_gen11_dp_constraint(data_t *data)
+{
+	igt_output_t *output = data->output;
+	uint32_t devid = intel_get_drm_devid(data->drm_fd);
+	drmModeConnector *connector = output->config.connector;
+
+	if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) &&
+	    (data->pipe == PIPE_A) && IS_GEN11(devid)) {
+		igt_debug("DSC not supported on pipe A on external DP in gen11 platforms\n");
+		return false;
+	}
+
+	return true;
+}
+
+/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
+static bool check_gen11_bpc_constraint(data_t *data)
+{
+	uint32_t devid = intel_get_drm_devid(data->drm_fd);
+
+	if (IS_GEN11(devid) && data->input_bpc == 12) {
+		igt_debug("Input bpc 12 not supported on gen11 platforms\n");
+		return false;
+	}
+
+	return true;
+}
+
 static void test_cleanup(data_t *data)
 {
 	igt_output_t *output = data->output;
@@ -121,12 +235,12 @@ static void update_display(data_t *data, enum dsc_test_type test_type, unsigned
 	igt_display_commit(display);
 
 	igt_debug("DSC is supported on %s\n", data->output->name);
-	save_force_dsc_en(data->drm_fd, data->output);
-	force_dsc_enable(data->drm_fd, data->output);
+	save_force_dsc_en(data);
+	force_dsc_enable(data);
 
 	if (test_type == TEST_DSC_BPC) {
 		igt_debug("Trying to set input BPC to %d\n", data->input_bpc);
-		force_dsc_enable_bpc(data->drm_fd, data->output, data->input_bpc);
+		force_dsc_enable_bpc(data);
 	}
 
 	igt_output_set_pipe(output, data->pipe);
@@ -165,7 +279,7 @@ static void update_display(data_t *data, enum dsc_test_type test_type, unsigned
 	restore_force_dsc_en();
 	igt_debug("Reset compression BPC\n");
 	data->input_bpc = 0;
-	force_dsc_enable_bpc(data->drm_fd, data->output, data->input_bpc);
+	force_dsc_enable_bpc(data);
 
 	igt_assert_f(enabled,
 		     "Default DSC enable failed on connector: %s pipe: %s\n",
@@ -188,13 +302,13 @@ static void test_dsc(data_t *data, enum dsc_test_type test_type, int bpc,
 		data->output = output;
 		data->pipe = pipe;
 
-		if (!check_dsc_on_connector(data->drm_fd, data->output))
+		if (!check_dsc_on_connector(data))
 			continue;
 
-		if (!check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe))
+		if (!check_gen11_dp_constraint(data))
 			continue;
 
-		if (!check_gen11_bpc_constraint(data->drm_fd, data->output, data->input_bpc))
+		if (!check_gen11_bpc_constraint(data))
 			continue;
 
 		if (!check_big_joiner_pipe_constraint(data))
@@ -218,12 +332,11 @@ igt_main
 	igt_fixture {
 		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
 		data.devid = intel_get_drm_devid(data.drm_fd);
-		data.disp_ver = intel_display_ver(data.devid);
 		kmstest_set_vt_graphics_mode();
 		igt_install_exit_handler(kms_dsc_exit_handler);
 		igt_display_require(&data.display, data.drm_fd);
 		igt_display_require_output(&data.display);
-		igt_require(data.disp_ver >= 11);
+		igt_require(intel_display_ver(data.devid) >= 11);
 		data.n_pipes = 0;
 		for_each_pipe(&data.display, i)
 			data.n_pipes++;
diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c
deleted file mode 100644
index a80f3d787..000000000
--- a/tests/i915/kms_dsc_helper.c
+++ /dev/null
@@ -1,99 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#include "kms_dsc_helper.h"
-
-static bool force_dsc_en_orig;
-static int force_dsc_restore_fd = -1;
-
-void force_dsc_enable(int drmfd, igt_output_t *output)
-{
-	int ret;
-
-	igt_debug("Forcing DSC enable on %s\n", output->name);
-	ret = igt_force_dsc_enable(drmfd, output->name);
-	igt_assert_f(ret > 0, "forcing dsc enable debugfs_write failed\n");
-}
-
-void force_dsc_enable_bpc(int drmfd, igt_output_t *output, int input_bpc)
-{
-	int ret;
-
-	igt_debug("Forcing input DSC BPC to %d on %s\n",
-		  input_bpc, output->name);
-	ret = igt_force_dsc_enable_bpc(drmfd, output->name, input_bpc);
-	igt_assert_f(ret > 0, "forcing input dsc bpc debugfs_write failed\n");
-}
-
-void save_force_dsc_en(int drmfd, igt_output_t *output)
-{
-	force_dsc_en_orig =
-		igt_is_force_dsc_enabled(drmfd, output->name);
-	force_dsc_restore_fd =
-		igt_get_dsc_debugfs_fd(drmfd, output->name);
-	igt_assert(force_dsc_restore_fd >= 0);
-}
-
-void restore_force_dsc_en(void)
-{
-	if (force_dsc_restore_fd < 0)
-		return;
-
-	igt_debug("Restoring DSC enable\n");
-	igt_assert(write(force_dsc_restore_fd, force_dsc_en_orig ? "1" : "0", 1) == 1);
-
-	close(force_dsc_restore_fd);
-	force_dsc_restore_fd = -1;
-}
-
-void kms_dsc_exit_handler(int sig)
-{
-	restore_force_dsc_en();
-}
-
-bool check_dsc_on_connector(int drmfd, igt_output_t *output)
-{
-	if (!igt_is_dsc_supported(drmfd, output->name)) {
-		igt_debug("DSC not supported on connector %s\n",
-			  output->name);
-		return false;
-	}
-
-	if (!output_is_internal_panel(output) &&
-	    !igt_is_fec_supported(drmfd, output->name)) {
-		igt_debug("DSC cannot be enabled without FEC on %s\n",
-			  output->name);
-		return false;
-	}
-
-	return true;
-}
-
-bool check_gen11_dp_constraint(int drmfd, igt_output_t *output, enum pipe pipe)
-{
-	uint32_t devid = intel_get_drm_devid(drmfd);
-	drmModeConnector *connector = output->config.connector;
-
-	if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) &&
-	    (pipe == PIPE_A) && IS_GEN11(devid)) {
-		igt_debug("DSC not supported on pipe A on external DP in gen11 platforms\n");
-		return false;
-	}
-
-	return true;
-}
-
-/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
-bool check_gen11_bpc_constraint(int drmfd, igt_output_t *output, int input_bpc)
-{
-	uint32_t devid = intel_get_drm_devid(drmfd);
-
-	if (IS_GEN11(devid) && input_bpc == 12) {
-		igt_debug("Input bpc 12 not supported on gen11 platforms\n");
-		return false;
-	}
-
-	return true;
-}
diff --git a/tests/i915/kms_dsc_helper.h b/tests/i915/kms_dsc_helper.h
deleted file mode 100644
index fe479dac4..000000000
--- a/tests/i915/kms_dsc_helper.h
+++ /dev/null
@@ -1,35 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2022 Intel Corporation
- */
-
-#ifndef IGT_KMS_DSC_HELPER_H
-#define IGT_KMS_DSC_HELPER_H
-
-#include "igt.h"
-#include "igt_sysfs.h"
-#include <errno.h>
-#include <getopt.h>
-#include <math.h>
-#include <stdint.h>
-#include <stdbool.h>
-#include <strings.h>
-#include <unistd.h>
-#include <stdlib.h>
-#include <signal.h>
-#include <time.h>
-#include <fcntl.h>
-#include <termios.h>
-
-#define HDISPLAY_5K	5120
-
-void force_dsc_enable(int drmfd, igt_output_t *output);
-void force_dsc_enable_bpc(int drmfd, igt_output_t *output, int input_bpc);
-void save_force_dsc_en(int drmfd, igt_output_t *output);
-void restore_force_dsc_en(void);
-void kms_dsc_exit_handler(int sig);
-bool check_dsc_on_connector(int drmfd, igt_output_t *output);
-bool check_gen11_dp_constraint(int drmfd, igt_output_t *output, enum pipe pipe);
-bool check_gen11_bpc_constraint(int drmfd, igt_output_t *output, int input_bpc);
-
-#endif
diff --git a/tests/meson.build b/tests/meson.build
index d41ed30fa..e20a86403 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -221,6 +221,7 @@ i915_progs = [
 	'kms_ccs',
 	'kms_cdclk',
 	'kms_draw_crc',
+	'kms_dsc',
 	'kms_fbcon_fbt',
 	'kms_fence_pin_leak',
 	'kms_flip_scaled_crc',
@@ -427,14 +428,6 @@ test_executables += executable('kms_color',
 	   install : true)
 test_list += 'kms_color'
 
-test_executables += executable('kms_dsc',
-	   [ join_paths('i915', 'kms_dsc.c'), join_paths ('i915', 'kms_dsc_helper.c')],
-	   dependencies : test_deps,
-	   install_dir : libexecdir,
-	   install_rpath : libexecdir_rpathdir,
-	   install : true)
-test_list += 'kms_dsc'
-
 if chamelium.found()
        test_executables += executable('kms_chamelium_color',
                              [ 'chamelium/kms_chamelium_color.c', 'kms_color_helper.c' ],
-- 
2.25.1

Re: [igt-dev] [PATCH i-g-t] Revert VDSC lib changes

[Petri Latvala]

On Fri, Jan 20, 2023 at 08:15:00PM +0530, Swati Sharma wrote:
> This reverts
>     commit 2a611c37bd170763052bf6c17aa2d48cf09a63c1
>     commit 65202cbc6109f17cf786a95947f4ee9223aec6b8
>     commit b6984b946ba66f6bb0452b223fe188429ddeab34
>     commit bbc2a5ceadb656552c5bcf95a19ce2b292a78128
> 
> Series broke git pipeline, revert above commits.
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>

The ultimate root cause is gitlab CI using Debian buster and thus
libdrm 2.4.97. Until that's changed (soon) #include <stddef.h> and
maybe some others need to be liberally applied all around.

Thanks for the quick revert.

Acked-by: Petri Latvala <petri.latvala@intel.com>


> ---
>  lib/igt.h                   |   1 -
>  lib/igt_dsc.c               | 133 ----------------------------------
>  lib/igt_dsc.h               |  19 -----
>  lib/igt_kms.c               | 127 +++++++++++++++++++++++++++++++++
>  lib/igt_kms.h               |  10 +++
>  lib/meson.build             |   1 -
>  tests/i915/kms_dsc.c        | 137 ++++++++++++++++++++++++++++++++----
>  tests/i915/kms_dsc_helper.c |  99 --------------------------
>  tests/i915/kms_dsc_helper.h |  35 ---------
>  tests/meson.build           |   9 +--
>  10 files changed, 263 insertions(+), 308 deletions(-)
>  delete mode 100644 lib/igt_dsc.c
>  delete mode 100644 lib/igt_dsc.h
>  delete mode 100644 tests/i915/kms_dsc_helper.c
>  delete mode 100644 tests/i915/kms_dsc_helper.h
> 
> diff --git a/lib/igt.h b/lib/igt.h
> index 73b6f7727..88938109e 100644
> --- a/lib/igt.h
> +++ b/lib/igt.h
> @@ -40,7 +40,6 @@
>  #include "igt_pipe_crc.h"
>  #include "igt_pm.h"
>  #include "igt_stats.h"
> -#include "igt_dsc.h"
>  #ifdef HAVE_CHAMELIUM
>  #include "igt_alsa.h"
>  #include "igt_audio.h"
> diff --git a/lib/igt_dsc.c b/lib/igt_dsc.c
> deleted file mode 100644
> index 25dcb5840..000000000
> --- a/lib/igt_dsc.c
> +++ /dev/null
> @@ -1,133 +0,0 @@
> -/* SPDX-License-Identifier: MIT */
> -/*
> - * Copyright © 2023 Intel Corporation
> - */
> -
> -#include <unistd.h>
> -#include <fcntl.h>
> -#include <string.h>
> -#include "igt_dsc.h"
> -#include "igt_sysfs.h"
> -
> -static bool check_dsc_debugfs(int drmfd, char *connector_name, const char *check_str)
> -{
> -	char file_name[128] = {0};
> -	char buf[512];
> -
> -	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
> -
> -	igt_debugfs_read(drmfd, file_name, buf);
> -
> -	return strstr(buf, check_str);
> -}
> -
> -static int write_dsc_debugfs(int drmfd, char *connector_name, const char *file_name,
> -			     const char *write_buf)
> -{
> -	int debugfs_fd = igt_debugfs_dir(drmfd);
> -	int len = strlen(write_buf);
> -	int ret;
> -	char file_path[128] = {0};
> -
> -	sprintf(file_path, "%s/%s", connector_name, file_name);
> -
> -	ret = igt_sysfs_write(debugfs_fd, file_path, write_buf, len);
> -
> -	close(debugfs_fd);
> -
> -	return ret;
> -}
> -
> -/*
> - * igt_is_dsc_supported:
> - * @drmfd: A drm file descriptor
> - * @connector_name: Name of the libdrm connector we're going to use
> - *
> - * Returns: True if DSC is supported for the given connector, false otherwise.
> - */
> -bool igt_is_dsc_supported(int drmfd, char *connector_name)
> -{
> -	return check_dsc_debugfs(drmfd, connector_name, "DSC_Sink_Support: yes");
> -}
> -
> -/*
> - * igt_is_fec_supported:
> - * @drmfd: A drm file descriptor
> - * @connector_name: Name of the libdrm connector we're going to use
> - *
> - * Returns: True if FEC is supported for the given connector, false otherwise.
> - */
> -bool igt_is_fec_supported(int drmfd, char *connector_name)
> -{
> -	return check_dsc_debugfs(drmfd, connector_name, "FEC_Sink_Support: yes");
> -}
> -
> -/*
> - * igt_is_dsc_enabled:
> - * @drmfd: A drm file descriptor
> - * @connector_name: Name of the libdrm connector we're going to use
> - *
> - * Returns: True if DSC is enabled for the given connector, false otherwise.
> - */
> -bool igt_is_dsc_enabled(int drmfd, char *connector_name)
> -{
> -	return check_dsc_debugfs(drmfd, connector_name, "DSC_Enabled: yes");
> -}
> -
> -/*
> - * igt_is_force_dsc_enabled:
> - * @drmfd: A drm file descriptor
> - * @connector_name: Name of the libdrm connector we're going to use
> - *
> - * Returns: True if DSC is force enabled (via debugfs) for the given connector,
> - * false otherwise.
> - */
> -bool igt_is_force_dsc_enabled(int drmfd, char *connector_name)
> -{
> -	return check_dsc_debugfs(drmfd, connector_name, "Force_DSC_Enable: yes");
> -}
> -
> -/*
> - * igt_force_dsc_enable:
> - * @drmfd: A drm file descriptor
> - * @connector_name: Name of the libdrm connector we're going to use
> - *
> - * Returns: 1 on success or negative error code, in case of failure.
> - */
> -int igt_force_dsc_enable(int drmfd, char *connector_name)
> -{
> -	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_fec_support", "1");
> -}
> -
> -/*
> - * igt_force_dsc_enable_bpc:
> - * @drmfd: A drm file descriptor
> - * @connector_name: Name of the libdrm connector we're going to use
> - * @bpc: Input BPC
> - *
> - * Returns: No. of bytes written or negative error code, in case of failure.
> - */
> -int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc)
> -{
> -	char buf[20] = {0};
> -
> -	sprintf(buf, "%d", bpc);
> -
> -	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_bpc", buf);
> -}
> -
> -/*
> - * igt_get_dsc_debugfs_fd:
> - * @drmfd: A drm file descriptor
> - * @connector_name: Name of the libdrm connector we're going to use
> - *
> - * Returns: fd of the DSC debugfs for the given connector, else returns -1.
> - */
> -int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name)
> -{
> -	char file_name[128] = {0};
> -
> -	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
> -
> -	return openat(igt_debugfs_dir(drmfd), file_name, O_WRONLY);
> -}
> diff --git a/lib/igt_dsc.h b/lib/igt_dsc.h
> deleted file mode 100644
> index 291c2cdea..000000000
> --- a/lib/igt_dsc.h
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -/* SPDX-License-Identifier: MIT */
> -/*
> - * Copyright © 2023 Intel Corporation
> - */
> -
> -#ifndef IGT_DSC_H
> -#define IGT_DSC_H
> -
> -#include "igt_fb.h"
> -
> -bool igt_is_dsc_supported(int drmfd, char *connector_name);
> -bool igt_is_fec_supported(int drmfd, char *connector_name);
> -bool igt_is_dsc_enabled(int drmfd, char *connector_name);
> -bool igt_is_force_dsc_enabled(int drmfd, char *connector_name);
> -int igt_force_dsc_enable(int drmfd, char *connector_name);
> -int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc);
> -int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name);
> -
> -#endif
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 31e6dfda0..b4a98ae17 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -5564,6 +5564,133 @@ void igt_dump_crtcs_fd(int drmfd)
>  	drmModeFreeResources(mode_resources);
>  }
>  
> +static
> +bool check_dsc_debugfs(int drmfd, char *connector_name,
> +		       const char *check_str)
> +{
> +	char file_name[128] = {0};
> +	char buf[512];
> +
> +	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
> +
> +	igt_debugfs_read(drmfd, file_name, buf);
> +
> +	return strstr(buf, check_str);
> +}
> +
> +static
> +int write_dsc_debugfs(int drmfd, char *connector_name,
> +		      const char *file_name,
> +		      const char *write_buf)
> +{
> +	int debugfs_fd = igt_debugfs_dir(drmfd);
> +	int len = strlen(write_buf);
> +	int ret;
> +	char file_path[128] = {0};
> +
> +	sprintf(file_path, "%s/%s", connector_name, file_name);
> +
> +	ret = igt_sysfs_write(debugfs_fd, file_path, write_buf, len);
> +
> +	close(debugfs_fd);
> +
> +	return ret;
> +}
> +
> +/*
> + * igt_is_dsc_supported:
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + *
> + * Returns: True if DSC is supported for the given connector, false otherwise.
> + */
> +bool igt_is_dsc_supported(int drmfd, char *connector_name)
> +{
> +	return check_dsc_debugfs(drmfd, connector_name, "DSC_Sink_Support: yes");
> +}
> +
> +/*
> + * igt_is_fec_supported:
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + *
> + * Returns: True if FEC is supported for the given connector, false otherwise.
> + */
> +bool igt_is_fec_supported(int drmfd, char *connector_name)
> +{
> +	return check_dsc_debugfs(drmfd, connector_name, "FEC_Sink_Support: yes");
> +}
> +
> +/*
> + * igt_is_dsc_enabled:
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + *
> + * Returns: True if DSC is enabled for the given connector, false otherwise.
> + */
> +bool igt_is_dsc_enabled(int drmfd, char *connector_name)
> +{
> +	return check_dsc_debugfs(drmfd, connector_name, "DSC_Enabled: yes");
> +}
> +
> +/*
> + * igt_is_force_dsc_enabled:
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + *
> + * Returns: True if DSC is force enabled (via debugfs) for the given connector,
> + * false otherwise.
> + */
> +bool igt_is_force_dsc_enabled(int drmfd, char *connector_name)
> +{
> +	return check_dsc_debugfs(drmfd, connector_name, "Force_DSC_Enable: yes");
> +}
> +
> +/*
> + * igt_force_dsc_enable:
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + *
> + * Returns: 1 on success or negative error code, in case of failure.
> + */
> +int igt_force_dsc_enable(int drmfd, char *connector_name)
> +{
> +	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_fec_support", "1");
> +}
> +
> +/*
> + * igt_force_dsc_enable_bpc:
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + * @bpc: Input BPC
> + *
> + * Returns: No. of bytes written or negative error code, in case of failure.
> + */
> +int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc)
> +{
> +	char buf[20] = {0};
> +
> +	sprintf(buf, "%d", bpc);
> +
> +	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_bpc", buf);
> +}
> +
> +/*
> + * igt_get_dsc_debugfs_fd:
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + *
> + * Returns: fd of the DSC debugfs for the given connector, else returns -1.
> + */
> +int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name)
> +{
> +	char file_name[128] = {0};
> +
> +	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
> +
> +	return openat(igt_debugfs_dir(drmfd), file_name, O_WRONLY);
> +}
> +
>  /*
>   * igt_get_output_max_bpc:
>   * @drmfd: A drm file descriptor
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index be5482e08..7a00d2045 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -974,6 +974,16 @@ void igt_require_pipe(igt_display_t *display,
>  void igt_dump_connectors_fd(int drmfd);
>  void igt_dump_crtcs_fd(int drmfd);
>  bool igt_override_all_active_output_modes_to_fit_bw(igt_display_t *display);
> +
> +bool igt_is_dsc_supported(int drmfd, char *connector_name);
> +bool igt_is_fec_supported(int drmfd, char *connector_name);
> +bool igt_is_dsc_enabled(int drmfd, char *connector_name);
> +bool igt_is_force_dsc_enabled(int drmfd, char *connector_name);
> +int igt_force_dsc_enable(int drmfd, char *connector_name);
> +int igt_force_dsc_enable_bpc(int drmfd, char *connector_name,
> +			     int bpc);
> +int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name);
> +
>  unsigned int igt_get_output_max_bpc(int drmfd, char *connector_name);
>  unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe);
>  void igt_assert_output_bpc_equal(int drmfd, enum pipe pipe,
> diff --git a/lib/meson.build b/lib/meson.build
> index 4e5b08bcd..cc7846869 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -96,7 +96,6 @@ lib_sources = [
>  	'igt_infoframe.c',
>  	'veboxcopy_gen12.c',
>  	'igt_msm.c',
> -	'igt_dsc.c',
>  ]
>  
>  lib_deps = [
> diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
> index 8f32ae950..330fc050b 100644
> --- a/tests/i915/kms_dsc.c
> +++ b/tests/i915/kms_dsc.c
> @@ -29,8 +29,22 @@
>   * Manasi Navare <manasi.d.navare@intel.com>
>   *
>   */
> -
> -#include "kms_dsc_helper.h"
> +#include "igt.h"
> +#include "igt_sysfs.h"
> +#include <errno.h>
> +#include <getopt.h>
> +#include <math.h>
> +#include <stdint.h>
> +#include <stdbool.h>
> +#include <strings.h>
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <signal.h>
> +#include <time.h>
> +#include <fcntl.h>
> +#include <termios.h>
> +
> +#define HDISPLAY_5K	5120
>  
>  IGT_TEST_DESCRIPTION("Test to validate display stream compression");
>  
> @@ -47,10 +61,12 @@ typedef struct {
>  	igt_output_t *output;
>  	int input_bpc;
>  	int n_pipes;
> -	int disp_ver;
>  	enum pipe pipe;
>  } data_t;
>  
> +bool force_dsc_en_orig;
> +int force_dsc_restore_fd = -1;
> +
>  const struct {
>  	const int format;
>  	const char format_str[20];
> @@ -68,6 +84,56 @@ static inline void manual(const char *expected)
>  	igt_debug_interactive_mode_check("all", expected);
>  }
>  
> +static void force_dsc_enable(data_t *data)
> +{
> +	int ret;
> +
> +	igt_debug("Forcing DSC enable on %s\n", data->output->name);
> +	ret = igt_force_dsc_enable(data->drm_fd,
> +				   data->output->name);
> +	igt_assert_f(ret > 0, "debugfs_write failed");
> +}
> +
> +static void force_dsc_enable_bpc(data_t *data)
> +{
> +	int ret;
> +
> +	igt_debug("Forcing input DSC BPC to %d on %s\n",
> +		  data->input_bpc, data->output->name);
> +	ret = igt_force_dsc_enable_bpc(data->drm_fd,
> +				       data->output->name,
> +				       data->input_bpc);
> +	igt_assert_f(ret > 0, "debugfs_write failed");
> +}
> +
> +static void save_force_dsc_en(data_t *data)
> +{
> +	force_dsc_en_orig =
> +		igt_is_force_dsc_enabled(data->drm_fd,
> +					 data->output->name);
> +	force_dsc_restore_fd =
> +		igt_get_dsc_debugfs_fd(data->drm_fd,
> +				       data->output->name);
> +	igt_assert(force_dsc_restore_fd >= 0);
> +}
> +
> +static void restore_force_dsc_en(void)
> +{
> +	if (force_dsc_restore_fd < 0)
> +		return;
> +
> +	igt_debug("Restoring DSC enable\n");
> +	igt_assert(write(force_dsc_restore_fd, force_dsc_en_orig ? "1" : "0", 1) == 1);
> +
> +	close(force_dsc_restore_fd);
> +	force_dsc_restore_fd = -1;
> +}
> +
> +static void kms_dsc_exit_handler(int sig)
> +{
> +	restore_force_dsc_en();
> +}
> +
>  static drmModeModeInfo *get_highres_mode(igt_output_t *output)
>  {
>  	drmModeConnector *connector = output->config.connector;
> @@ -80,6 +146,26 @@ static drmModeModeInfo *get_highres_mode(igt_output_t *output)
>  	return highest_mode;
>  }
>  
> +static bool check_dsc_on_connector(data_t *data)
> +{
> +	igt_output_t *output = data->output;
> +
> +	if (!igt_is_dsc_supported(data->drm_fd, output->name)) {
> +		igt_debug("DSC not supported on connector %s\n",
> +			  output->name);
> +		return false;
> +	}
> +
> +	if (!output_is_internal_panel(output) &&
> +	    !igt_is_fec_supported(data->drm_fd, output->name)) {
> +		igt_debug("DSC cannot be enabled without FEC on %s\n",
> +			  output->name);
> +		return false;
> +	}
> +
> +	return true;
> +}
> +
>  static bool check_big_joiner_pipe_constraint(data_t *data)
>  {
>  	igt_output_t *output = data->output;
> @@ -95,6 +181,34 @@ static bool check_big_joiner_pipe_constraint(data_t *data)
>  	return true;
>  }
>  
> +static bool check_gen11_dp_constraint(data_t *data)
> +{
> +	igt_output_t *output = data->output;
> +	uint32_t devid = intel_get_drm_devid(data->drm_fd);
> +	drmModeConnector *connector = output->config.connector;
> +
> +	if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) &&
> +	    (data->pipe == PIPE_A) && IS_GEN11(devid)) {
> +		igt_debug("DSC not supported on pipe A on external DP in gen11 platforms\n");
> +		return false;
> +	}
> +
> +	return true;
> +}
> +
> +/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
> +static bool check_gen11_bpc_constraint(data_t *data)
> +{
> +	uint32_t devid = intel_get_drm_devid(data->drm_fd);
> +
> +	if (IS_GEN11(devid) && data->input_bpc == 12) {
> +		igt_debug("Input bpc 12 not supported on gen11 platforms\n");
> +		return false;
> +	}
> +
> +	return true;
> +}
> +
>  static void test_cleanup(data_t *data)
>  {
>  	igt_output_t *output = data->output;
> @@ -121,12 +235,12 @@ static void update_display(data_t *data, enum dsc_test_type test_type, unsigned
>  	igt_display_commit(display);
>  
>  	igt_debug("DSC is supported on %s\n", data->output->name);
> -	save_force_dsc_en(data->drm_fd, data->output);
> -	force_dsc_enable(data->drm_fd, data->output);
> +	save_force_dsc_en(data);
> +	force_dsc_enable(data);
>  
>  	if (test_type == TEST_DSC_BPC) {
>  		igt_debug("Trying to set input BPC to %d\n", data->input_bpc);
> -		force_dsc_enable_bpc(data->drm_fd, data->output, data->input_bpc);
> +		force_dsc_enable_bpc(data);
>  	}
>  
>  	igt_output_set_pipe(output, data->pipe);
> @@ -165,7 +279,7 @@ static void update_display(data_t *data, enum dsc_test_type test_type, unsigned
>  	restore_force_dsc_en();
>  	igt_debug("Reset compression BPC\n");
>  	data->input_bpc = 0;
> -	force_dsc_enable_bpc(data->drm_fd, data->output, data->input_bpc);
> +	force_dsc_enable_bpc(data);
>  
>  	igt_assert_f(enabled,
>  		     "Default DSC enable failed on connector: %s pipe: %s\n",
> @@ -188,13 +302,13 @@ static void test_dsc(data_t *data, enum dsc_test_type test_type, int bpc,
>  		data->output = output;
>  		data->pipe = pipe;
>  
> -		if (!check_dsc_on_connector(data->drm_fd, data->output))
> +		if (!check_dsc_on_connector(data))
>  			continue;
>  
> -		if (!check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe))
> +		if (!check_gen11_dp_constraint(data))
>  			continue;
>  
> -		if (!check_gen11_bpc_constraint(data->drm_fd, data->output, data->input_bpc))
> +		if (!check_gen11_bpc_constraint(data))
>  			continue;
>  
>  		if (!check_big_joiner_pipe_constraint(data))
> @@ -218,12 +332,11 @@ igt_main
>  	igt_fixture {
>  		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
>  		data.devid = intel_get_drm_devid(data.drm_fd);
> -		data.disp_ver = intel_display_ver(data.devid);
>  		kmstest_set_vt_graphics_mode();
>  		igt_install_exit_handler(kms_dsc_exit_handler);
>  		igt_display_require(&data.display, data.drm_fd);
>  		igt_display_require_output(&data.display);
> -		igt_require(data.disp_ver >= 11);
> +		igt_require(intel_display_ver(data.devid) >= 11);
>  		data.n_pipes = 0;
>  		for_each_pipe(&data.display, i)
>  			data.n_pipes++;
> diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c
> deleted file mode 100644
> index a80f3d787..000000000
> --- a/tests/i915/kms_dsc_helper.c
> +++ /dev/null
> @@ -1,99 +0,0 @@
> -/* SPDX-License-Identifier: MIT */
> -/*
> - * Copyright © 2023 Intel Corporation
> - */
> -
> -#include "kms_dsc_helper.h"
> -
> -static bool force_dsc_en_orig;
> -static int force_dsc_restore_fd = -1;
> -
> -void force_dsc_enable(int drmfd, igt_output_t *output)
> -{
> -	int ret;
> -
> -	igt_debug("Forcing DSC enable on %s\n", output->name);
> -	ret = igt_force_dsc_enable(drmfd, output->name);
> -	igt_assert_f(ret > 0, "forcing dsc enable debugfs_write failed\n");
> -}
> -
> -void force_dsc_enable_bpc(int drmfd, igt_output_t *output, int input_bpc)
> -{
> -	int ret;
> -
> -	igt_debug("Forcing input DSC BPC to %d on %s\n",
> -		  input_bpc, output->name);
> -	ret = igt_force_dsc_enable_bpc(drmfd, output->name, input_bpc);
> -	igt_assert_f(ret > 0, "forcing input dsc bpc debugfs_write failed\n");
> -}
> -
> -void save_force_dsc_en(int drmfd, igt_output_t *output)
> -{
> -	force_dsc_en_orig =
> -		igt_is_force_dsc_enabled(drmfd, output->name);
> -	force_dsc_restore_fd =
> -		igt_get_dsc_debugfs_fd(drmfd, output->name);
> -	igt_assert(force_dsc_restore_fd >= 0);
> -}
> -
> -void restore_force_dsc_en(void)
> -{
> -	if (force_dsc_restore_fd < 0)
> -		return;
> -
> -	igt_debug("Restoring DSC enable\n");
> -	igt_assert(write(force_dsc_restore_fd, force_dsc_en_orig ? "1" : "0", 1) == 1);
> -
> -	close(force_dsc_restore_fd);
> -	force_dsc_restore_fd = -1;
> -}
> -
> -void kms_dsc_exit_handler(int sig)
> -{
> -	restore_force_dsc_en();
> -}
> -
> -bool check_dsc_on_connector(int drmfd, igt_output_t *output)
> -{
> -	if (!igt_is_dsc_supported(drmfd, output->name)) {
> -		igt_debug("DSC not supported on connector %s\n",
> -			  output->name);
> -		return false;
> -	}
> -
> -	if (!output_is_internal_panel(output) &&
> -	    !igt_is_fec_supported(drmfd, output->name)) {
> -		igt_debug("DSC cannot be enabled without FEC on %s\n",
> -			  output->name);
> -		return false;
> -	}
> -
> -	return true;
> -}
> -
> -bool check_gen11_dp_constraint(int drmfd, igt_output_t *output, enum pipe pipe)
> -{
> -	uint32_t devid = intel_get_drm_devid(drmfd);
> -	drmModeConnector *connector = output->config.connector;
> -
> -	if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) &&
> -	    (pipe == PIPE_A) && IS_GEN11(devid)) {
> -		igt_debug("DSC not supported on pipe A on external DP in gen11 platforms\n");
> -		return false;
> -	}
> -
> -	return true;
> -}
> -
> -/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
> -bool check_gen11_bpc_constraint(int drmfd, igt_output_t *output, int input_bpc)
> -{
> -	uint32_t devid = intel_get_drm_devid(drmfd);
> -
> -	if (IS_GEN11(devid) && input_bpc == 12) {
> -		igt_debug("Input bpc 12 not supported on gen11 platforms\n");
> -		return false;
> -	}
> -
> -	return true;
> -}
> diff --git a/tests/i915/kms_dsc_helper.h b/tests/i915/kms_dsc_helper.h
> deleted file mode 100644
> index fe479dac4..000000000
> --- a/tests/i915/kms_dsc_helper.h
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -/* SPDX-License-Identifier: MIT */
> -/*
> - * Copyright © 2022 Intel Corporation
> - */
> -
> -#ifndef IGT_KMS_DSC_HELPER_H
> -#define IGT_KMS_DSC_HELPER_H
> -
> -#include "igt.h"
> -#include "igt_sysfs.h"
> -#include <errno.h>
> -#include <getopt.h>
> -#include <math.h>
> -#include <stdint.h>
> -#include <stdbool.h>
> -#include <strings.h>
> -#include <unistd.h>
> -#include <stdlib.h>
> -#include <signal.h>
> -#include <time.h>
> -#include <fcntl.h>
> -#include <termios.h>
> -
> -#define HDISPLAY_5K	5120
> -
> -void force_dsc_enable(int drmfd, igt_output_t *output);
> -void force_dsc_enable_bpc(int drmfd, igt_output_t *output, int input_bpc);
> -void save_force_dsc_en(int drmfd, igt_output_t *output);
> -void restore_force_dsc_en(void);
> -void kms_dsc_exit_handler(int sig);
> -bool check_dsc_on_connector(int drmfd, igt_output_t *output);
> -bool check_gen11_dp_constraint(int drmfd, igt_output_t *output, enum pipe pipe);
> -bool check_gen11_bpc_constraint(int drmfd, igt_output_t *output, int input_bpc);
> -
> -#endif
> diff --git a/tests/meson.build b/tests/meson.build
> index d41ed30fa..e20a86403 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -221,6 +221,7 @@ i915_progs = [
>  	'kms_ccs',
>  	'kms_cdclk',
>  	'kms_draw_crc',
> +	'kms_dsc',
>  	'kms_fbcon_fbt',
>  	'kms_fence_pin_leak',
>  	'kms_flip_scaled_crc',
> @@ -427,14 +428,6 @@ test_executables += executable('kms_color',
>  	   install : true)
>  test_list += 'kms_color'
>  
> -test_executables += executable('kms_dsc',
> -	   [ join_paths('i915', 'kms_dsc.c'), join_paths ('i915', 'kms_dsc_helper.c')],
> -	   dependencies : test_deps,
> -	   install_dir : libexecdir,
> -	   install_rpath : libexecdir_rpathdir,
> -	   install : true)
> -test_list += 'kms_dsc'
> -
>  if chamelium.found()
>         test_executables += executable('kms_chamelium_color',
>                               [ 'chamelium/kms_chamelium_color.c', 'kms_color_helper.c' ],
> -- 
> 2.25.1
> 

Re: [igt-dev] [PATCH i-g-t] Revert VDSC lib changes

[Kamil Konieczny]

Hi,

On 2023-01-20 at 16:47:58 +0200, Petri Latvala wrote:
> On Fri, Jan 20, 2023 at 08:15:00PM +0530, Swati Sharma wrote:
> > This reverts
> >     commit 2a611c37bd170763052bf6c17aa2d48cf09a63c1
> >     commit 65202cbc6109f17cf786a95947f4ee9223aec6b8
> >     commit b6984b946ba66f6bb0452b223fe188429ddeab34
> >     commit bbc2a5ceadb656552c5bcf95a19ce2b292a78128
> > 
> > Series broke git pipeline, revert above commits.
> > 
> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> 
> The ultimate root cause is gitlab CI using Debian buster and thus
> libdrm 2.4.97. Until that's changed (soon) #include <stddef.h> and
> maybe some others need to be liberally applied all around.
> 
> Thanks for the quick revert.
> 
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> 
> 
> > ---
> >  lib/igt.h                   |   1 -
> >  lib/igt_dsc.c               | 133 ----------------------------------
> >  lib/igt_dsc.h               |  19 -----
> >  lib/igt_kms.c               | 127 +++++++++++++++++++++++++++++++++
> >  lib/igt_kms.h               |  10 +++

Looks like igt_kms.h is missing #include <stdint.h> before x86.

Regards,
Kamil

> >  lib/meson.build             |   1 -
> >  tests/i915/kms_dsc.c        | 137 ++++++++++++++++++++++++++++++++----
> >  tests/i915/kms_dsc_helper.c |  99 --------------------------
> >  tests/i915/kms_dsc_helper.h |  35 ---------
> >  tests/meson.build           |   9 +--
> >  10 files changed, 263 insertions(+), 308 deletions(-)
> >  delete mode 100644 lib/igt_dsc.c
> >  delete mode 100644 lib/igt_dsc.h
> >  delete mode 100644 tests/i915/kms_dsc_helper.c
> >  delete mode 100644 tests/i915/kms_dsc_helper.h
[cut]

Re: [igt-dev] [PATCH i-g-t] Revert VDSC lib changes

[Kamil Konieczny]

On 2023-01-20 at 16:47:58 +0200, Petri Latvala wrote:
> On Fri, Jan 20, 2023 at 08:15:00PM +0530, Swati Sharma wrote:
> > This reverts
> >     commit 2a611c37bd170763052bf6c17aa2d48cf09a63c1
> >     commit 65202cbc6109f17cf786a95947f4ee9223aec6b8
> >     commit b6984b946ba66f6bb0452b223fe188429ddeab34
> >     commit bbc2a5ceadb656552c5bcf95a19ce2b292a78128
> > 
> > Series broke git pipeline, revert above commits.
> > 
> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> 
> The ultimate root cause is gitlab CI using Debian buster and thus
> libdrm 2.4.97. Until that's changed (soon) #include <stddef.h> and
> maybe some others need to be liberally applied all around.
> 
> Thanks for the quick revert.
> 
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> 
> 
> > ---
> >  lib/igt.h                   |   1 -
> >  lib/igt_dsc.c               | 133 ----------------------------------
> >  lib/igt_dsc.h               |  19 -----
> >  lib/igt_kms.c               | 127 +++++++++++++++++++++++++++++++++
> >  lib/igt_kms.h               |  10 +++

My bad, I wrote igt_kms.h but there it is correct,
it is igt_fb.h where should be

#include <stdint.h>

before

#include <xf86drmMode.h>

Btw in igt_fb.h includes should be reorganised, std libs first,
then cairo and other graphics, then igt headers.

Regards,
Kamil

> >  lib/meson.build             |   1 -
> >  tests/i915/kms_dsc.c        | 137 ++++++++++++++++++++++++++++++++----
> >  tests/i915/kms_dsc_helper.c |  99 --------------------------
> >  tests/i915/kms_dsc_helper.h |  35 ---------
> >  tests/meson.build           |   9 +--
> >  10 files changed, 263 insertions(+), 308 deletions(-)
> >  delete mode 100644 lib/igt_dsc.c
> >  delete mode 100644 lib/igt_dsc.h
> >  delete mode 100644 tests/i915/kms_dsc_helper.c
> >  delete mode 100644 tests/i915/kms_dsc_helper.h
> > 
> > diff --git a/lib/igt.h b/lib/igt.h
> > index 73b6f7727..88938109e 100644
> > --- a/lib/igt.h
> > +++ b/lib/igt.h
> > @@ -40,7 +40,6 @@
> >  #include "igt_pipe_crc.h"
> >  #include "igt_pm.h"
> >  #include "igt_stats.h"
> > -#include "igt_dsc.h"
> >  #ifdef HAVE_CHAMELIUM
> >  #include "igt_alsa.h"
> >  #include "igt_audio.h"
> > diff --git a/lib/igt_dsc.c b/lib/igt_dsc.c
> > deleted file mode 100644
> > index 25dcb5840..000000000
> > --- a/lib/igt_dsc.c
> > +++ /dev/null
> > @@ -1,133 +0,0 @@
> > -/* SPDX-License-Identifier: MIT */
> > -/*
> > - * Copyright © 2023 Intel Corporation
> > - */
> > -
> > -#include <unistd.h>
> > -#include <fcntl.h>
> > -#include <string.h>
> > -#include "igt_dsc.h"
> > -#include "igt_sysfs.h"
> > -
> > -static bool check_dsc_debugfs(int drmfd, char *connector_name, const char *check_str)
> > -{
> > -	char file_name[128] = {0};
> > -	char buf[512];
> > -
> > -	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
> > -
> > -	igt_debugfs_read(drmfd, file_name, buf);
> > -
> > -	return strstr(buf, check_str);
> > -}
> > -
> > -static int write_dsc_debugfs(int drmfd, char *connector_name, const char *file_name,
> > -			     const char *write_buf)
> > -{
> > -	int debugfs_fd = igt_debugfs_dir(drmfd);
> > -	int len = strlen(write_buf);
> > -	int ret;
> > -	char file_path[128] = {0};
> > -
> > -	sprintf(file_path, "%s/%s", connector_name, file_name);
> > -
> > -	ret = igt_sysfs_write(debugfs_fd, file_path, write_buf, len);
> > -
> > -	close(debugfs_fd);
> > -
> > -	return ret;
> > -}
> > -
> > -/*
> > - * igt_is_dsc_supported:
> > - * @drmfd: A drm file descriptor
> > - * @connector_name: Name of the libdrm connector we're going to use
> > - *
> > - * Returns: True if DSC is supported for the given connector, false otherwise.
> > - */
> > -bool igt_is_dsc_supported(int drmfd, char *connector_name)
> > -{
> > -	return check_dsc_debugfs(drmfd, connector_name, "DSC_Sink_Support: yes");
> > -}
> > -
> > -/*
> > - * igt_is_fec_supported:
> > - * @drmfd: A drm file descriptor
> > - * @connector_name: Name of the libdrm connector we're going to use
> > - *
> > - * Returns: True if FEC is supported for the given connector, false otherwise.
> > - */
> > -bool igt_is_fec_supported(int drmfd, char *connector_name)
> > -{
> > -	return check_dsc_debugfs(drmfd, connector_name, "FEC_Sink_Support: yes");
> > -}
> > -
> > -/*
> > - * igt_is_dsc_enabled:
> > - * @drmfd: A drm file descriptor
> > - * @connector_name: Name of the libdrm connector we're going to use
> > - *
> > - * Returns: True if DSC is enabled for the given connector, false otherwise.
> > - */
> > -bool igt_is_dsc_enabled(int drmfd, char *connector_name)
> > -{
> > -	return check_dsc_debugfs(drmfd, connector_name, "DSC_Enabled: yes");
> > -}
> > -
> > -/*
> > - * igt_is_force_dsc_enabled:
> > - * @drmfd: A drm file descriptor
> > - * @connector_name: Name of the libdrm connector we're going to use
> > - *
> > - * Returns: True if DSC is force enabled (via debugfs) for the given connector,
> > - * false otherwise.
> > - */
> > -bool igt_is_force_dsc_enabled(int drmfd, char *connector_name)
> > -{
> > -	return check_dsc_debugfs(drmfd, connector_name, "Force_DSC_Enable: yes");
> > -}
> > -
> > -/*
> > - * igt_force_dsc_enable:
> > - * @drmfd: A drm file descriptor
> > - * @connector_name: Name of the libdrm connector we're going to use
> > - *
> > - * Returns: 1 on success or negative error code, in case of failure.
> > - */
> > -int igt_force_dsc_enable(int drmfd, char *connector_name)
> > -{
> > -	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_fec_support", "1");
> > -}
> > -
> > -/*
> > - * igt_force_dsc_enable_bpc:
> > - * @drmfd: A drm file descriptor
> > - * @connector_name: Name of the libdrm connector we're going to use
> > - * @bpc: Input BPC
> > - *
> > - * Returns: No. of bytes written or negative error code, in case of failure.
> > - */
> > -int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc)
> > -{
> > -	char buf[20] = {0};
> > -
> > -	sprintf(buf, "%d", bpc);
> > -
> > -	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_bpc", buf);
> > -}
> > -
> > -/*
> > - * igt_get_dsc_debugfs_fd:
> > - * @drmfd: A drm file descriptor
> > - * @connector_name: Name of the libdrm connector we're going to use
> > - *
> > - * Returns: fd of the DSC debugfs for the given connector, else returns -1.
> > - */
> > -int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name)
> > -{
> > -	char file_name[128] = {0};
> > -
> > -	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
> > -
> > -	return openat(igt_debugfs_dir(drmfd), file_name, O_WRONLY);
> > -}
> > diff --git a/lib/igt_dsc.h b/lib/igt_dsc.h
> > deleted file mode 100644
> > index 291c2cdea..000000000
> > --- a/lib/igt_dsc.h
> > +++ /dev/null
> > @@ -1,19 +0,0 @@
> > -/* SPDX-License-Identifier: MIT */
> > -/*
> > - * Copyright © 2023 Intel Corporation
> > - */
> > -
> > -#ifndef IGT_DSC_H
> > -#define IGT_DSC_H
> > -
> > -#include "igt_fb.h"
> > -
> > -bool igt_is_dsc_supported(int drmfd, char *connector_name);
> > -bool igt_is_fec_supported(int drmfd, char *connector_name);
> > -bool igt_is_dsc_enabled(int drmfd, char *connector_name);
> > -bool igt_is_force_dsc_enabled(int drmfd, char *connector_name);
> > -int igt_force_dsc_enable(int drmfd, char *connector_name);
> > -int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc);
> > -int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name);
> > -
> > -#endif
> > diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> > index 31e6dfda0..b4a98ae17 100644
> > --- a/lib/igt_kms.c
> > +++ b/lib/igt_kms.c
> > @@ -5564,6 +5564,133 @@ void igt_dump_crtcs_fd(int drmfd)
> >  	drmModeFreeResources(mode_resources);
> >  }
> >  
> > +static
> > +bool check_dsc_debugfs(int drmfd, char *connector_name,
> > +		       const char *check_str)
> > +{
> > +	char file_name[128] = {0};
> > +	char buf[512];
> > +
> > +	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
> > +
> > +	igt_debugfs_read(drmfd, file_name, buf);
> > +
> > +	return strstr(buf, check_str);
> > +}
> > +
> > +static
> > +int write_dsc_debugfs(int drmfd, char *connector_name,
> > +		      const char *file_name,
> > +		      const char *write_buf)
> > +{
> > +	int debugfs_fd = igt_debugfs_dir(drmfd);
> > +	int len = strlen(write_buf);
> > +	int ret;
> > +	char file_path[128] = {0};
> > +
> > +	sprintf(file_path, "%s/%s", connector_name, file_name);
> > +
> > +	ret = igt_sysfs_write(debugfs_fd, file_path, write_buf, len);
> > +
> > +	close(debugfs_fd);
> > +
> > +	return ret;
> > +}
> > +
> > +/*
> > + * igt_is_dsc_supported:
> > + * @drmfd: A drm file descriptor
> > + * @connector_name: Name of the libdrm connector we're going to use
> > + *
> > + * Returns: True if DSC is supported for the given connector, false otherwise.
> > + */
> > +bool igt_is_dsc_supported(int drmfd, char *connector_name)
> > +{
> > +	return check_dsc_debugfs(drmfd, connector_name, "DSC_Sink_Support: yes");
> > +}
> > +
> > +/*
> > + * igt_is_fec_supported:
> > + * @drmfd: A drm file descriptor
> > + * @connector_name: Name of the libdrm connector we're going to use
> > + *
> > + * Returns: True if FEC is supported for the given connector, false otherwise.
> > + */
> > +bool igt_is_fec_supported(int drmfd, char *connector_name)
> > +{
> > +	return check_dsc_debugfs(drmfd, connector_name, "FEC_Sink_Support: yes");
> > +}
> > +
> > +/*
> > + * igt_is_dsc_enabled:
> > + * @drmfd: A drm file descriptor
> > + * @connector_name: Name of the libdrm connector we're going to use
> > + *
> > + * Returns: True if DSC is enabled for the given connector, false otherwise.
> > + */
> > +bool igt_is_dsc_enabled(int drmfd, char *connector_name)
> > +{
> > +	return check_dsc_debugfs(drmfd, connector_name, "DSC_Enabled: yes");
> > +}
> > +
> > +/*
> > + * igt_is_force_dsc_enabled:
> > + * @drmfd: A drm file descriptor
> > + * @connector_name: Name of the libdrm connector we're going to use
> > + *
> > + * Returns: True if DSC is force enabled (via debugfs) for the given connector,
> > + * false otherwise.
> > + */
> > +bool igt_is_force_dsc_enabled(int drmfd, char *connector_name)
> > +{
> > +	return check_dsc_debugfs(drmfd, connector_name, "Force_DSC_Enable: yes");
> > +}
> > +
> > +/*
> > + * igt_force_dsc_enable:
> > + * @drmfd: A drm file descriptor
> > + * @connector_name: Name of the libdrm connector we're going to use
> > + *
> > + * Returns: 1 on success or negative error code, in case of failure.
> > + */
> > +int igt_force_dsc_enable(int drmfd, char *connector_name)
> > +{
> > +	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_fec_support", "1");
> > +}
> > +
> > +/*
> > + * igt_force_dsc_enable_bpc:
> > + * @drmfd: A drm file descriptor
> > + * @connector_name: Name of the libdrm connector we're going to use
> > + * @bpc: Input BPC
> > + *
> > + * Returns: No. of bytes written or negative error code, in case of failure.
> > + */
> > +int igt_force_dsc_enable_bpc(int drmfd, char *connector_name, int bpc)
> > +{
> > +	char buf[20] = {0};
> > +
> > +	sprintf(buf, "%d", bpc);
> > +
> > +	return write_dsc_debugfs(drmfd, connector_name, "i915_dsc_bpc", buf);
> > +}
> > +
> > +/*
> > + * igt_get_dsc_debugfs_fd:
> > + * @drmfd: A drm file descriptor
> > + * @connector_name: Name of the libdrm connector we're going to use
> > + *
> > + * Returns: fd of the DSC debugfs for the given connector, else returns -1.
> > + */
> > +int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name)
> > +{
> > +	char file_name[128] = {0};
> > +
> > +	sprintf(file_name, "%s/i915_dsc_fec_support", connector_name);
> > +
> > +	return openat(igt_debugfs_dir(drmfd), file_name, O_WRONLY);
> > +}
> > +
> >  /*
> >   * igt_get_output_max_bpc:
> >   * @drmfd: A drm file descriptor
> > diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> > index be5482e08..7a00d2045 100644
> > --- a/lib/igt_kms.h
> > +++ b/lib/igt_kms.h
> > @@ -974,6 +974,16 @@ void igt_require_pipe(igt_display_t *display,
> >  void igt_dump_connectors_fd(int drmfd);
> >  void igt_dump_crtcs_fd(int drmfd);
> >  bool igt_override_all_active_output_modes_to_fit_bw(igt_display_t *display);
> > +
> > +bool igt_is_dsc_supported(int drmfd, char *connector_name);
> > +bool igt_is_fec_supported(int drmfd, char *connector_name);
> > +bool igt_is_dsc_enabled(int drmfd, char *connector_name);
> > +bool igt_is_force_dsc_enabled(int drmfd, char *connector_name);
> > +int igt_force_dsc_enable(int drmfd, char *connector_name);
> > +int igt_force_dsc_enable_bpc(int drmfd, char *connector_name,
> > +			     int bpc);
> > +int igt_get_dsc_debugfs_fd(int drmfd, char *connector_name);
> > +
> >  unsigned int igt_get_output_max_bpc(int drmfd, char *connector_name);
> >  unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe);
> >  void igt_assert_output_bpc_equal(int drmfd, enum pipe pipe,
> > diff --git a/lib/meson.build b/lib/meson.build
> > index 4e5b08bcd..cc7846869 100644
> > --- a/lib/meson.build
> > +++ b/lib/meson.build
> > @@ -96,7 +96,6 @@ lib_sources = [
> >  	'igt_infoframe.c',
> >  	'veboxcopy_gen12.c',
> >  	'igt_msm.c',
> > -	'igt_dsc.c',
> >  ]
> >  
> >  lib_deps = [
> > diff --git a/tests/i915/kms_dsc.c b/tests/i915/kms_dsc.c
> > index 8f32ae950..330fc050b 100644
> > --- a/tests/i915/kms_dsc.c
> > +++ b/tests/i915/kms_dsc.c
> > @@ -29,8 +29,22 @@
> >   * Manasi Navare <manasi.d.navare@intel.com>
> >   *
> >   */
> > -
> > -#include "kms_dsc_helper.h"
> > +#include "igt.h"
> > +#include "igt_sysfs.h"
> > +#include <errno.h>
> > +#include <getopt.h>
> > +#include <math.h>
> > +#include <stdint.h>
> > +#include <stdbool.h>
> > +#include <strings.h>
> > +#include <unistd.h>
> > +#include <stdlib.h>
> > +#include <signal.h>
> > +#include <time.h>
> > +#include <fcntl.h>
> > +#include <termios.h>
> > +
> > +#define HDISPLAY_5K	5120
> >  
> >  IGT_TEST_DESCRIPTION("Test to validate display stream compression");
> >  
> > @@ -47,10 +61,12 @@ typedef struct {
> >  	igt_output_t *output;
> >  	int input_bpc;
> >  	int n_pipes;
> > -	int disp_ver;
> >  	enum pipe pipe;
> >  } data_t;
> >  
> > +bool force_dsc_en_orig;
> > +int force_dsc_restore_fd = -1;
> > +
> >  const struct {
> >  	const int format;
> >  	const char format_str[20];
> > @@ -68,6 +84,56 @@ static inline void manual(const char *expected)
> >  	igt_debug_interactive_mode_check("all", expected);
> >  }
> >  
> > +static void force_dsc_enable(data_t *data)
> > +{
> > +	int ret;
> > +
> > +	igt_debug("Forcing DSC enable on %s\n", data->output->name);
> > +	ret = igt_force_dsc_enable(data->drm_fd,
> > +				   data->output->name);
> > +	igt_assert_f(ret > 0, "debugfs_write failed");
> > +}
> > +
> > +static void force_dsc_enable_bpc(data_t *data)
> > +{
> > +	int ret;
> > +
> > +	igt_debug("Forcing input DSC BPC to %d on %s\n",
> > +		  data->input_bpc, data->output->name);
> > +	ret = igt_force_dsc_enable_bpc(data->drm_fd,
> > +				       data->output->name,
> > +				       data->input_bpc);
> > +	igt_assert_f(ret > 0, "debugfs_write failed");
> > +}
> > +
> > +static void save_force_dsc_en(data_t *data)
> > +{
> > +	force_dsc_en_orig =
> > +		igt_is_force_dsc_enabled(data->drm_fd,
> > +					 data->output->name);
> > +	force_dsc_restore_fd =
> > +		igt_get_dsc_debugfs_fd(data->drm_fd,
> > +				       data->output->name);
> > +	igt_assert(force_dsc_restore_fd >= 0);
> > +}
> > +
> > +static void restore_force_dsc_en(void)
> > +{
> > +	if (force_dsc_restore_fd < 0)
> > +		return;
> > +
> > +	igt_debug("Restoring DSC enable\n");
> > +	igt_assert(write(force_dsc_restore_fd, force_dsc_en_orig ? "1" : "0", 1) == 1);
> > +
> > +	close(force_dsc_restore_fd);
> > +	force_dsc_restore_fd = -1;
> > +}
> > +
> > +static void kms_dsc_exit_handler(int sig)
> > +{
> > +	restore_force_dsc_en();
> > +}
> > +
> >  static drmModeModeInfo *get_highres_mode(igt_output_t *output)
> >  {
> >  	drmModeConnector *connector = output->config.connector;
> > @@ -80,6 +146,26 @@ static drmModeModeInfo *get_highres_mode(igt_output_t *output)
> >  	return highest_mode;
> >  }
> >  
> > +static bool check_dsc_on_connector(data_t *data)
> > +{
> > +	igt_output_t *output = data->output;
> > +
> > +	if (!igt_is_dsc_supported(data->drm_fd, output->name)) {
> > +		igt_debug("DSC not supported on connector %s\n",
> > +			  output->name);
> > +		return false;
> > +	}
> > +
> > +	if (!output_is_internal_panel(output) &&
> > +	    !igt_is_fec_supported(data->drm_fd, output->name)) {
> > +		igt_debug("DSC cannot be enabled without FEC on %s\n",
> > +			  output->name);
> > +		return false;
> > +	}
> > +
> > +	return true;
> > +}
> > +
> >  static bool check_big_joiner_pipe_constraint(data_t *data)
> >  {
> >  	igt_output_t *output = data->output;
> > @@ -95,6 +181,34 @@ static bool check_big_joiner_pipe_constraint(data_t *data)
> >  	return true;
> >  }
> >  
> > +static bool check_gen11_dp_constraint(data_t *data)
> > +{
> > +	igt_output_t *output = data->output;
> > +	uint32_t devid = intel_get_drm_devid(data->drm_fd);
> > +	drmModeConnector *connector = output->config.connector;
> > +
> > +	if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) &&
> > +	    (data->pipe == PIPE_A) && IS_GEN11(devid)) {
> > +		igt_debug("DSC not supported on pipe A on external DP in gen11 platforms\n");
> > +		return false;
> > +	}
> > +
> > +	return true;
> > +}
> > +
> > +/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
> > +static bool check_gen11_bpc_constraint(data_t *data)
> > +{
> > +	uint32_t devid = intel_get_drm_devid(data->drm_fd);
> > +
> > +	if (IS_GEN11(devid) && data->input_bpc == 12) {
> > +		igt_debug("Input bpc 12 not supported on gen11 platforms\n");
> > +		return false;
> > +	}
> > +
> > +	return true;
> > +}
> > +
> >  static void test_cleanup(data_t *data)
> >  {
> >  	igt_output_t *output = data->output;
> > @@ -121,12 +235,12 @@ static void update_display(data_t *data, enum dsc_test_type test_type, unsigned
> >  	igt_display_commit(display);
> >  
> >  	igt_debug("DSC is supported on %s\n", data->output->name);
> > -	save_force_dsc_en(data->drm_fd, data->output);
> > -	force_dsc_enable(data->drm_fd, data->output);
> > +	save_force_dsc_en(data);
> > +	force_dsc_enable(data);
> >  
> >  	if (test_type == TEST_DSC_BPC) {
> >  		igt_debug("Trying to set input BPC to %d\n", data->input_bpc);
> > -		force_dsc_enable_bpc(data->drm_fd, data->output, data->input_bpc);
> > +		force_dsc_enable_bpc(data);
> >  	}
> >  
> >  	igt_output_set_pipe(output, data->pipe);
> > @@ -165,7 +279,7 @@ static void update_display(data_t *data, enum dsc_test_type test_type, unsigned
> >  	restore_force_dsc_en();
> >  	igt_debug("Reset compression BPC\n");
> >  	data->input_bpc = 0;
> > -	force_dsc_enable_bpc(data->drm_fd, data->output, data->input_bpc);
> > +	force_dsc_enable_bpc(data);
> >  
> >  	igt_assert_f(enabled,
> >  		     "Default DSC enable failed on connector: %s pipe: %s\n",
> > @@ -188,13 +302,13 @@ static void test_dsc(data_t *data, enum dsc_test_type test_type, int bpc,
> >  		data->output = output;
> >  		data->pipe = pipe;
> >  
> > -		if (!check_dsc_on_connector(data->drm_fd, data->output))
> > +		if (!check_dsc_on_connector(data))
> >  			continue;
> >  
> > -		if (!check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe))
> > +		if (!check_gen11_dp_constraint(data))
> >  			continue;
> >  
> > -		if (!check_gen11_bpc_constraint(data->drm_fd, data->output, data->input_bpc))
> > +		if (!check_gen11_bpc_constraint(data))
> >  			continue;
> >  
> >  		if (!check_big_joiner_pipe_constraint(data))
> > @@ -218,12 +332,11 @@ igt_main
> >  	igt_fixture {
> >  		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> >  		data.devid = intel_get_drm_devid(data.drm_fd);
> > -		data.disp_ver = intel_display_ver(data.devid);
> >  		kmstest_set_vt_graphics_mode();
> >  		igt_install_exit_handler(kms_dsc_exit_handler);
> >  		igt_display_require(&data.display, data.drm_fd);
> >  		igt_display_require_output(&data.display);
> > -		igt_require(data.disp_ver >= 11);
> > +		igt_require(intel_display_ver(data.devid) >= 11);
> >  		data.n_pipes = 0;
> >  		for_each_pipe(&data.display, i)
> >  			data.n_pipes++;
> > diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c
> > deleted file mode 100644
> > index a80f3d787..000000000
> > --- a/tests/i915/kms_dsc_helper.c
> > +++ /dev/null
> > @@ -1,99 +0,0 @@
> > -/* SPDX-License-Identifier: MIT */
> > -/*
> > - * Copyright © 2023 Intel Corporation
> > - */
> > -
> > -#include "kms_dsc_helper.h"
> > -
> > -static bool force_dsc_en_orig;
> > -static int force_dsc_restore_fd = -1;
> > -
> > -void force_dsc_enable(int drmfd, igt_output_t *output)
> > -{
> > -	int ret;
> > -
> > -	igt_debug("Forcing DSC enable on %s\n", output->name);
> > -	ret = igt_force_dsc_enable(drmfd, output->name);
> > -	igt_assert_f(ret > 0, "forcing dsc enable debugfs_write failed\n");
> > -}
> > -
> > -void force_dsc_enable_bpc(int drmfd, igt_output_t *output, int input_bpc)
> > -{
> > -	int ret;
> > -
> > -	igt_debug("Forcing input DSC BPC to %d on %s\n",
> > -		  input_bpc, output->name);
> > -	ret = igt_force_dsc_enable_bpc(drmfd, output->name, input_bpc);
> > -	igt_assert_f(ret > 0, "forcing input dsc bpc debugfs_write failed\n");
> > -}
> > -
> > -void save_force_dsc_en(int drmfd, igt_output_t *output)
> > -{
> > -	force_dsc_en_orig =
> > -		igt_is_force_dsc_enabled(drmfd, output->name);
> > -	force_dsc_restore_fd =
> > -		igt_get_dsc_debugfs_fd(drmfd, output->name);
> > -	igt_assert(force_dsc_restore_fd >= 0);
> > -}
> > -
> > -void restore_force_dsc_en(void)
> > -{
> > -	if (force_dsc_restore_fd < 0)
> > -		return;
> > -
> > -	igt_debug("Restoring DSC enable\n");
> > -	igt_assert(write(force_dsc_restore_fd, force_dsc_en_orig ? "1" : "0", 1) == 1);
> > -
> > -	close(force_dsc_restore_fd);
> > -	force_dsc_restore_fd = -1;
> > -}
> > -
> > -void kms_dsc_exit_handler(int sig)
> > -{
> > -	restore_force_dsc_en();
> > -}
> > -
> > -bool check_dsc_on_connector(int drmfd, igt_output_t *output)
> > -{
> > -	if (!igt_is_dsc_supported(drmfd, output->name)) {
> > -		igt_debug("DSC not supported on connector %s\n",
> > -			  output->name);
> > -		return false;
> > -	}
> > -
> > -	if (!output_is_internal_panel(output) &&
> > -	    !igt_is_fec_supported(drmfd, output->name)) {
> > -		igt_debug("DSC cannot be enabled without FEC on %s\n",
> > -			  output->name);
> > -		return false;
> > -	}
> > -
> > -	return true;
> > -}
> > -
> > -bool check_gen11_dp_constraint(int drmfd, igt_output_t *output, enum pipe pipe)
> > -{
> > -	uint32_t devid = intel_get_drm_devid(drmfd);
> > -	drmModeConnector *connector = output->config.connector;
> > -
> > -	if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) &&
> > -	    (pipe == PIPE_A) && IS_GEN11(devid)) {
> > -		igt_debug("DSC not supported on pipe A on external DP in gen11 platforms\n");
> > -		return false;
> > -	}
> > -
> > -	return true;
> > -}
> > -
> > -/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
> > -bool check_gen11_bpc_constraint(int drmfd, igt_output_t *output, int input_bpc)
> > -{
> > -	uint32_t devid = intel_get_drm_devid(drmfd);
> > -
> > -	if (IS_GEN11(devid) && input_bpc == 12) {
> > -		igt_debug("Input bpc 12 not supported on gen11 platforms\n");
> > -		return false;
> > -	}
> > -
> > -	return true;
> > -}
> > diff --git a/tests/i915/kms_dsc_helper.h b/tests/i915/kms_dsc_helper.h
> > deleted file mode 100644
> > index fe479dac4..000000000
> > --- a/tests/i915/kms_dsc_helper.h
> > +++ /dev/null
> > @@ -1,35 +0,0 @@
> > -/* SPDX-License-Identifier: MIT */
> > -/*
> > - * Copyright © 2022 Intel Corporation
> > - */
> > -
> > -#ifndef IGT_KMS_DSC_HELPER_H
> > -#define IGT_KMS_DSC_HELPER_H
> > -
> > -#include "igt.h"
> > -#include "igt_sysfs.h"
> > -#include <errno.h>
> > -#include <getopt.h>
> > -#include <math.h>
> > -#include <stdint.h>
> > -#include <stdbool.h>
> > -#include <strings.h>
> > -#include <unistd.h>
> > -#include <stdlib.h>
> > -#include <signal.h>
> > -#include <time.h>
> > -#include <fcntl.h>
> > -#include <termios.h>
> > -
> > -#define HDISPLAY_5K	5120
> > -
> > -void force_dsc_enable(int drmfd, igt_output_t *output);
> > -void force_dsc_enable_bpc(int drmfd, igt_output_t *output, int input_bpc);
> > -void save_force_dsc_en(int drmfd, igt_output_t *output);
> > -void restore_force_dsc_en(void);
> > -void kms_dsc_exit_handler(int sig);
> > -bool check_dsc_on_connector(int drmfd, igt_output_t *output);
> > -bool check_gen11_dp_constraint(int drmfd, igt_output_t *output, enum pipe pipe);
> > -bool check_gen11_bpc_constraint(int drmfd, igt_output_t *output, int input_bpc);
> > -
> > -#endif
> > diff --git a/tests/meson.build b/tests/meson.build
> > index d41ed30fa..e20a86403 100644
> > --- a/tests/meson.build
> > +++ b/tests/meson.build
> > @@ -221,6 +221,7 @@ i915_progs = [
> >  	'kms_ccs',
> >  	'kms_cdclk',
> >  	'kms_draw_crc',
> > +	'kms_dsc',
> >  	'kms_fbcon_fbt',
> >  	'kms_fence_pin_leak',
> >  	'kms_flip_scaled_crc',
> > @@ -427,14 +428,6 @@ test_executables += executable('kms_color',
> >  	   install : true)
> >  test_list += 'kms_color'
> >  
> > -test_executables += executable('kms_dsc',
> > -	   [ join_paths('i915', 'kms_dsc.c'), join_paths ('i915', 'kms_dsc_helper.c')],
> > -	   dependencies : test_deps,
> > -	   install_dir : libexecdir,
> > -	   install_rpath : libexecdir_rpathdir,
> > -	   install : true)
> > -test_list += 'kms_dsc'
> > -
> >  if chamelium.found()
> >         test_executables += executable('kms_chamelium_color',
> >                               [ 'chamelium/kms_chamelium_color.c', 'kms_color_helper.c' ],
> > -- 
> > 2.25.1
> > 

Re: [igt-dev] [PATCH i-g-t] Revert VDSC lib changes

[Petri Latvala]

On Fri, Jan 20, 2023 at 04:47:58PM +0200, Petri Latvala wrote:
> On Fri, Jan 20, 2023 at 08:15:00PM +0530, Swati Sharma wrote:
> > This reverts
> >     commit 2a611c37bd170763052bf6c17aa2d48cf09a63c1
> >     commit 65202cbc6109f17cf786a95947f4ee9223aec6b8
> >     commit b6984b946ba66f6bb0452b223fe188429ddeab34
> >     commit bbc2a5ceadb656552c5bcf95a19ce2b292a78128
> > 
> > Series broke git pipeline, revert above commits.
> > 
> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> 
> The ultimate root cause is gitlab CI using Debian buster and thus
> libdrm 2.4.97. Until that's changed (soon) #include <stddef.h> and
> maybe some others need to be liberally applied all around.
> 
> Thanks for the quick revert.
> 
> Acked-by: Petri Latvala <petri.latvala@intel.com>

Gitlab pipeline for this series was a success, go ahead and merge.


-- 
Petri Latvala

[igt-dev] ✓ Fi.CI.BAT: success for Revert VDSC lib changes

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 6532 bytes --]

== Series Details ==

Series: Revert VDSC lib changes
URL   : https://patchwork.freedesktop.org/series/113154/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12617 -> IGTPW_8384
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/index.html

Participating hosts (35 -> 34)
------------------------------

  Additional (3): fi-kbl-soraka bat-adls-5 fi-pnv-d510 
  Missing    (4): fi-bsw-kefka bat-rpls-2 fi-rkl-11600 fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8384 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_gttfill@basic:
    - fi-pnv-d510:        NOTRUN -> [FAIL][1] ([i915#7229])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-pnv-d510/igt@gem_exec_gttfill@basic.html

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@i915_module_load@load:
    - fi-ctg-p8600:       [PASS][4] -> [DMESG-WARN][5] ([i915#6020])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/fi-ctg-p8600/igt@i915_module_load@load.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-ctg-p8600/igt@i915_module_load@load.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][6] ([i915#5334] / [i915#7872])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][7] ([i915#1886])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@i915_selftest@live@ring_submission:
    - fi-kbl-soraka:      NOTRUN -> [INCOMPLETE][8] ([i915#7640])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-kbl-soraka/igt@i915_selftest@live@ring_submission.html

  * igt@kms_chamelium_frames@hdmi-crc-fast:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][9] ([fdo#109271]) +15 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][10] ([fdo#109271])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-bsw-n3050/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
    - fi-bsw-n3050:       [PASS][11] -> [FAIL][12] ([i915#6298])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html

  * igt@kms_psr@primary_page_flip:
    - fi-pnv-d510:        NOTRUN -> [SKIP][13] ([fdo#109271]) +44 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-pnv-d510/igt@kms_psr@primary_page_flip.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@execlists:
    - fi-bsw-n3050:       [INCOMPLETE][14] ([i915#6972]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-bsw-n3050/igt@i915_selftest@live@execlists.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [DMESG-FAIL][16] ([i915#5334]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
  [i915#6020]: https://gitlab.freedesktop.org/drm/intel/issues/6020
  [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
  [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
  [i915#6972]: https://gitlab.freedesktop.org/drm/intel/issues/6972
  [i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
  [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
  [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
  [i915#7640]: https://gitlab.freedesktop.org/drm/intel/issues/7640
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7128 -> IGTPW_8384

  CI-20190529: 20190529
  CI_DRM_12617: 328799697aa88d6f14c6a7267e5aefc9129725de @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8384: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/index.html
  IGT_7128: be755d8bfee83a21448e58217edea2b615eef1a3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/index.html

[-- Attachment #2: Type: text/html, Size: 6914 bytes --]

Re: [igt-dev] [PATCH i-g-t] Revert VDSC lib changes

[Swati Sharma]

On 20-Jan-23 9:02 PM, Petri Latvala wrote:
> On Fri, Jan 20, 2023 at 04:47:58PM +0200, Petri Latvala wrote:
>> On Fri, Jan 20, 2023 at 08:15:00PM +0530, Swati Sharma wrote:
>>> This reverts
>>>      commit 2a611c37bd170763052bf6c17aa2d48cf09a63c1
>>>      commit 65202cbc6109f17cf786a95947f4ee9223aec6b8
>>>      commit b6984b946ba66f6bb0452b223fe188429ddeab34
>>>      commit bbc2a5ceadb656552c5bcf95a19ce2b292a78128
>>>
>>> Series broke git pipeline, revert above commits.
>>>
>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>
>> The ultimate root cause is gitlab CI using Debian buster and thus
>> libdrm 2.4.97. Until that's changed (soon) #include <stddef.h> and
>> maybe some others need to be liberally applied all around.
>>
>> Thanks for the quick revert.
>>
>> Acked-by: Petri Latvala <petri.latvala@intel.com>
> 
> Gitlab pipeline for this series was a success, go ahead and merge.

Done.
> 
> 

-- 
~Swati Sharma

[igt-dev] ✗ Fi.CI.IGT: failure for Revert VDSC lib changes

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 27381 bytes --]

== Series Details ==

Series: Revert VDSC lib changes
URL   : https://patchwork.freedesktop.org/series/113154/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12617_full -> IGTPW_8384_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_8384_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_8384_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/index.html

Participating hosts (11 -> 9)
------------------------------

  Missing    (2): pig-skl-6260u pig-kbl-iris 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8384_full:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
    - shard-apl:          [PASS][1] -> [TIMEOUT][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-apl2/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl2/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html

  
Known issues
------------

  Here are the changes found in IGTPW_8384_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [PASS][3] -> [FAIL][4] ([i915#2842])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_lmem_swapping@heavy-multi:
    - shard-apl:          NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl1/igt@gem_lmem_swapping@heavy-multi.html

  * igt@i915_module_load@reload-no-display:
    - shard-snb:          [PASS][6] -> [DMESG-WARN][7] ([i915#4528])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-snb5/igt@i915_module_load@reload-no-display.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-snb5/igt@i915_module_load@reload-no-display.html

  * igt@i915_pipe_stress@stress-xrgb8888-untiled:
    - shard-apl:          NOTRUN -> [FAIL][8] ([i915#7036])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl6/igt@i915_pipe_stress@stress-xrgb8888-untiled.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [PASS][9] -> [SKIP][10] ([fdo#109271])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-apl6/igt@i915_pm_dc@dc9-dpms.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl2/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_rps@engine-order:
    - shard-apl:          [PASS][11] -> [FAIL][12] ([i915#6537])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-apl7/igt@i915_pm_rps@engine-order.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl1/igt@i915_pm_rps@engine-order.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs_cc:
    - shard-apl:          NOTRUN -> [SKIP][13] ([fdo#109271]) +79 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl6/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs_cc.html

  * igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
    - shard-apl:          NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#3886]) +1 similar issue
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl7/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
    - shard-glk:          [PASS][15] -> [FAIL][16] ([i915#79])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2:
    - shard-glk:          [PASS][17] -> [FAIL][18] ([i915#2122]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-glk8/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
    - shard-apl:          [PASS][19] -> [FAIL][20] ([i915#79])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html

  * igt@kms_plane_alpha_blend@constant-alpha-max@pipe-b-dp-1:
    - shard-apl:          NOTRUN -> [FAIL][21] ([i915#4573]) +2 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl3/igt@kms_plane_alpha_blend@constant-alpha-max@pipe-b-dp-1.html

  * igt@runner@aborted:
    - shard-snb:          NOTRUN -> [FAIL][22] ([i915#4312])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-snb5/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@fbdev@nullptr:
    - {shard-tglu}:       [SKIP][23] ([i915#2582]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-tglu-6/igt@fbdev@nullptr.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-tglu-5/igt@fbdev@nullptr.html

  * igt@gem_ctx_isolation@preservation-s3@vecs0:
    - shard-apl:          [DMESG-WARN][25] ([i915#180]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-apl2/igt@gem_ctx_isolation@preservation-s3@vecs0.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl7/igt@gem_ctx_isolation@preservation-s3@vecs0.html

  * igt@gem_ctx_persistence@engines-hang@bcs0:
    - {shard-rkl}:        [SKIP][27] ([i915#6252]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-5/igt@gem_ctx_persistence@engines-hang@bcs0.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-3/igt@gem_ctx_persistence@engines-hang@bcs0.html

  * igt@gem_eio@suspend:
    - {shard-rkl}:        [FAIL][29] ([i915#7052]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-3/igt@gem_eio@suspend.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-1/igt@gem_eio@suspend.html

  * igt@gem_exec_fair@basic-none@rcs0:
    - shard-glk:          [FAIL][31] ([i915#2842]) -> [PASS][32] +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-glk1/igt@gem_exec_fair@basic-none@rcs0.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html

  * igt@gem_exec_reloc@basic-gtt-read:
    - {shard-rkl}:        [SKIP][33] ([i915#3281]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-1/igt@gem_exec_reloc@basic-gtt-read.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read.html

  * igt@gem_pread@snoop:
    - {shard-rkl}:        [SKIP][35] ([i915#3282]) -> [PASS][36] +3 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-1/igt@gem_pread@snoop.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-5/igt@gem_pread@snoop.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-apl:          [DMESG-WARN][37] ([i915#5566] / [i915#716]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-apl7/igt@gen9_exec_parse@allowed-single.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl2/igt@gen9_exec_parse@allowed-single.html

  * igt@gen9_exec_parse@bb-start-cmd:
    - {shard-rkl}:        [SKIP][39] ([i915#2527]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-6/igt@gen9_exec_parse@bb-start-cmd.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-5/igt@gen9_exec_parse@bb-start-cmd.html

  * igt@i915_pipe_stress@stress-xrgb8888-ytiled:
    - {shard-rkl}:        [SKIP][41] ([i915#4098]) -> [PASS][42] +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-4/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html

  * igt@i915_pm_rpm@drm-resources-equal:
    - {shard-rkl}:        [SKIP][43] ([fdo#109308]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-2/igt@i915_pm_rpm@drm-resources-equal.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@i915_pm_rpm@drm-resources-equal.html

  * igt@i915_pm_rpm@fences-dpms:
    - {shard-rkl}:        [SKIP][45] ([i915#1849]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-1/igt@i915_pm_rpm@fences-dpms.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@i915_pm_rpm@fences-dpms.html

  * igt@i915_suspend@fence-restore-untiled:
    - {shard-rkl}:        [FAIL][47] ([fdo#103375]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-4/igt@i915_suspend@fence-restore-untiled.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
    - {shard-tglu}:       [SKIP][49] ([i915#7651]) -> [PASS][50] +6 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-tglu-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-tglu-1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
    - {shard-rkl}:        [FAIL][51] ([i915#3743]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

  * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
    - shard-apl:          [FAIL][53] ([i915#2346]) -> [PASS][54] +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
    - shard-glk:          [FAIL][55] ([i915#2346]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - {shard-rkl}:        [SKIP][57] ([i915#3955]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-4/igt@kms_fbcon_fbt@psr-suspend.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
    - {shard-tglu}:       [SKIP][59] ([i915#1849]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-tglu-4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt:
    - {shard-rkl}:        [SKIP][61] ([i915#1849] / [i915#4098]) -> [PASS][62] +15 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt.html

  * igt@kms_psr@sprite_plane_move:
    - {shard-rkl}:        [SKIP][63] ([i915#1072]) -> [PASS][64] +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-2/igt@kms_psr@sprite_plane_move.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@kms_psr@sprite_plane_move.html

  * igt@kms_universal_plane@universal-plane-pipe-d-sanity:
    - {shard-tglu}:       [SKIP][65] ([fdo#109274]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-tglu-6/igt@kms_universal_plane@universal-plane-pipe-d-sanity.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-tglu-8/igt@kms_universal_plane@universal-plane-pipe-d-sanity.html

  * igt@kms_vblank@pipe-b-accuracy-idle:
    - {shard-tglu}:       [SKIP][67] ([i915#1845] / [i915#7651]) -> [PASS][68] +2 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-tglu-6/igt@kms_vblank@pipe-b-accuracy-idle.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-tglu-7/igt@kms_vblank@pipe-b-accuracy-idle.html

  * igt@kms_vblank@pipe-b-ts-continuation-idle:
    - {shard-rkl}:        [SKIP][69] ([i915#1845] / [i915#4098]) -> [PASS][70] +28 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-1/igt@kms_vblank@pipe-b-ts-continuation-idle.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-6/igt@kms_vblank@pipe-b-ts-continuation-idle.html

  * igt@perf@polling:
    - {shard-rkl}:        [FAIL][71] ([i915#7756]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-1/igt@perf@polling.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-rkl-1/igt@perf@polling.html

  
#### Warnings ####

  * igt@kms_dsc@dsc-with-bpc-formats:
    - shard-glk:          [SKIP][73] ([fdo#109271]) -> [SKIP][74] ([fdo#109271] / [i915#7205])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-glk2/igt@kms_dsc@dsc-with-bpc-formats.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-glk3/igt@kms_dsc@dsc-with-bpc-formats.html
    - shard-apl:          [SKIP][75] ([fdo#109271]) -> [SKIP][76] ([fdo#109271] / [i915#7205])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-apl2/igt@kms_dsc@dsc-with-bpc-formats.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/shard-apl3/igt@kms_dsc@dsc-with-bpc-formats.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
  [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
  [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
  [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
  [i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
  [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
  [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
  [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
  [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
  [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
  [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
  [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
  [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
  [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
  [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
  [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
  [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
  [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
  [i915#7205]: https://gitlab.freedesktop.org/drm/intel/issues/7205
  [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
  [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
  [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
  [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7756]: https://gitlab.freedesktop.org/drm/intel/issues/7756
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7128 -> IGTPW_8384
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_12617: 328799697aa88d6f14c6a7267e5aefc9129725de @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8384: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/index.html
  IGT_7128: be755d8bfee83a21448e58217edea2b615eef1a3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8384/index.html

[-- Attachment #2: Type: text/html, Size: 21052 bytes --]