Re: [PATCH] [i-g-t] tests/intel/xe_vm:Reduce n_execs for bind-array-enobufs

["Randhawa, Jagmeet" <jagmeet.randhawa@intel.com>]

On 10/28/2024 9:53 AM, Kamil Konieczny wrote:
> Hi Jagmeet,
> On 2024-10-22 at 20:11:30 +0000, Jagmeet Randhawa wrote:
>
> small nit for subject, please place space after ':'
> [i-g-t] tests/intel/xe_vm:Reduce n_execs for bind-array-enobufs
>
> should be:
>
> [i-g-t] tests/intel/xe_vm: Reduce n_execs for bind-array-enobufs
>
>> The bind-array-enobufs test in xe_vm.c is intended to trigger
>> an -ENOBUFS error by submitting an oversized bind array.
>> After encountering and handling the error, the test reduces
>> n_execs by half and retries the operation. On some environments
>> with stricter resource limits (e.g. simulator), halving
>> n_execs isn't sufficient to prevent the ENOBUFS error on the retry.
>> Reducing n_execs further to n_execs / 4 allows the test to pass
>> successfully. This patch modifies the test to reduce n_execs
> --------------- ^
> Imho you repeat your argument again here, I will take only
> what is up to 'This patch...' with Jonathan r-b.
>
> Also please replay to CI failure reports, I will do this now
> as to give you an example how to follow up with your next patches.
>
> Regards,
> Kamil
Hey Kamil, I have adjusted the patch according to your comments and sent 
v2 just now. Thank you for the comments.
>> to n_execs / 4 after an ENOBUFS error is handled. This ensures
>> compatibility with environments that have tighter resource
>> constraints while maintaining the test's integrity.
>>
>> Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
>> Signed-off-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
>> ---
>>   tests/intel/xe_vm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
>> index 7a8740b69..e78ddd0e5 100644
>> --- a/tests/intel/xe_vm.c
>> +++ b/tests/intel/xe_vm.c
>> @@ -957,7 +957,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs,
>>   		xe_cork_end(&cork);
>>   		xe_cork_wait_done(&cork);
>>   		xe_cork_fini(&cork);
>> -		n_execs = n_execs / 2;
>> +		n_execs = n_execs / 4;
>>   	}
>>   
>>   	xe_vm_bind_array(fd, vm, bind_exec_queue, bind_ops, n_execs, sync, 1);
>> -- 
>> 2.34.1
>>