[igt-dev] [PATCH i-g-t] lib/i915/perf: reenable perf tests on cometlake

[igt-dev] [PATCH i-g-t] lib/i915/perf: reenable perf tests on cometlake

[Lionel Landwerlin]

The perf code coming from gputop assumed that devinfo for
cometlake/coffeelake used the same entry (devinfo->is_coffeelake).

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 53f8f541ca ("lib: Add i915_perf library")
---
 lib/i915/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/i915/perf.c b/lib/i915/perf.c
index a5dd3eab..babfe633 100644
--- a/lib/i915/perf.c
+++ b/lib/i915/perf.c
@@ -219,7 +219,7 @@ intel_perf_for_devinfo(uint32_t device_id,
 	} else if (devinfo->is_geminilake) {
 		perf->devinfo.eu_threads_count = 6;
 		intel_perf_load_metrics_glk(perf);
-	} else if (devinfo->is_coffeelake) {
+	} else if (devinfo->is_coffeelake || devinfo->is_cometlake) {
 		switch (devinfo->gt) {
 		case 2:
 			intel_perf_load_metrics_cflgt2(perf);
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/i915/perf: reenable perf tests on cometlake

[Chris Wilson]

Quoting Lionel Landwerlin (2020-02-26 08:23:48)
> The perf code coming from gputop assumed that devinfo for
> cometlake/coffeelake used the same entry (devinfo->is_coffeelake).
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 53f8f541ca ("lib: Add i915_perf library")
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/i915/perf: reenable perf tests on cometlake

[Lionel Landwerlin]

On 26/02/2020 13:03, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2020-02-26 08:23:48)
>> The perf code coming from gputop assumed that devinfo for
>> cometlake/coffeelake used the same entry (devinfo->is_coffeelake).
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Fixes: 53f8f541ca ("lib: Add i915_perf library")
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris

Thanks a lot,


-Lionel

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/i915/perf: reenable perf tests on cometlake

[Patchwork]

== Series Details ==

Series: lib/i915/perf: reenable perf tests on cometlake
URL   : https://patchwork.freedesktop.org/series/73946/
State : failure

== Summary ==

Series 73946 revision 1 was fully merged or fully failed: no git log

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev