* [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls()
@ 2019-11-09 15:10 Chris Wilson
2019-11-09 15:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2019-11-09 15:10 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
igt_aux.h already provides the optimal igt_fls(), so use that in
preference to open coding the brute force version.
Reported-by: Stuart Summers <stuart.summers@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Stuart Summers <stuart.summers@intel.com>
---
tests/i915/gem_blits.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/tests/i915/gem_blits.c b/tests/i915/gem_blits.c
index e0346a7c7..f9cb12bb8 100644
--- a/tests/i915/gem_blits.c
+++ b/tests/i915/gem_blits.c
@@ -57,16 +57,6 @@ enum mode {
WC,
};
-static int fls(uint64_t x)
-{
- int t;
-
- for (t = 0; x >> t; t++)
- ;
-
- return t;
-}
-
static unsigned int
get_tiling_stride(const struct device *device,
unsigned int width, unsigned int tiling)
@@ -81,7 +71,7 @@ get_tiling_stride(const struct device *device,
else
stride = ALIGN(stride, 128);
if (device->gen < 4)
- stride = 1 << fls(stride - 1);
+ stride = 1 << igt_fls(stride - 1);
} else {
if (device->gen >= 8)
stride = ALIGN(stride, 64);
--
2.24.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_blits: Use common igt_fls() 2019-11-09 15:10 [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls() Chris Wilson @ 2019-11-09 15:52 ` Patchwork 2019-11-10 22:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-11-09 15:52 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: i915/gem_blits: Use common igt_fls() URL : https://patchwork.freedesktop.org/series/69238/ State : success == Summary == CI Bug Log - changes from CI_DRM_7299 -> IGTPW_3677 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/index.html Known issues ------------ Here are the changes found in IGTPW_3677 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-cml-s: [PASS][1] -> [DMESG-WARN][2] ([fdo#111764]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-cml-s/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/fi-cml-s/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live_gem_contexts: - fi-bsw-n3050: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html #### Possible fixes #### * igt@i915_selftest@live_blt: - fi-hsw-peppy: [DMESG-FAIL][5] ([fdo#112147]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-hsw-peppy/igt@i915_selftest@live_blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/fi-hsw-peppy/igt@i915_selftest@live_blt.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][7] ([fdo#111407]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 [fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736 [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764 [fdo#112147]: https://bugs.freedesktop.org/show_bug.cgi?id=112147 Participating hosts (51 -> 42) ------------------------------ Missing (9): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-byt-clapper fi-bdw-samus fi-snb-2600 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5268 -> IGTPW_3677 CI-20190529: 20190529 CI_DRM_7299: e7de48a8b1161a99f4b8e4483bc1bb85f5d31039 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3677: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/index.html IGT_5268: c94958b8f7caefcda72392417ae6f3a98e36a48b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_blits: Use common igt_fls() 2019-11-09 15:10 [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls() Chris Wilson 2019-11-09 15:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2019-11-10 22:00 ` Patchwork 2019-11-11 10:47 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler 2019-11-13 20:38 ` Summers, Stuart 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-11-10 22:00 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: i915/gem_blits: Use common igt_fls() URL : https://patchwork.freedesktop.org/series/69238/ State : success == Summary == CI Bug Log - changes from CI_DRM_7299_full -> IGTPW_3677_full ==================================================== Summary ------- **WARNING** Minor unknown changes coming with IGTPW_3677_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_3677_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_3677_full: ### IGT changes ### #### Warnings #### * igt@i915_pm_dc@dc6-psr: - shard-tglb: [SKIP][1] ([fdo#111865]) -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@i915_pm_dc@dc6-psr.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb4/igt@i915_pm_dc@dc6-psr.html Known issues ------------ Here are the changes found in IGTPW_3677_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_exec@basic-invalid-context-vcs1: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +9 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_ctx_exec@basic-invalid-context-vcs1.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb8/igt@gem_ctx_exec@basic-invalid-context-vcs1.html * igt@gem_ctx_isolation@rcs0-s3: - shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +3 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_ctx_persistence@vcs1-mixed: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb7/igt@gem_ctx_persistence@vcs1-mixed.html * igt@gem_ctx_switch@all-light: - shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([fdo#111672]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb8/igt@gem_ctx_switch@all-light.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb6/igt@gem_ctx_switch@all-light.html * igt@gem_exec_async@concurrent-writes-bsd: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112146]) +6 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb7/igt@gem_exec_async@concurrent-writes-bsd.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb2/igt@gem_exec_async@concurrent-writes-bsd.html * igt@gem_exec_await@wide-all: - shard-hsw: [PASS][13] -> [INCOMPLETE][14] ([fdo#103540]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw6/igt@gem_exec_await@wide-all.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-hsw2/igt@gem_exec_await@wide-all.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#110854]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_exec_balancer@smoke.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb6/igt@gem_exec_balancer@smoke.html * igt@gem_exec_suspend@basic-s0: - shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111832]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb3/igt@gem_exec_suspend@basic-s0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb8/igt@gem_exec_suspend@basic-s0.html * igt@gem_userptr_blits@map-fixed-invalidate-busy: - shard-snb: [PASS][19] -> [DMESG-WARN][20] ([fdo#111870]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html * igt@i915_selftest@mock_requests: - shard-glk: [PASS][21] -> [DMESG-WARN][22] ([fdo#112158]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-glk7/igt@i915_selftest@mock_requests.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-glk8/igt@i915_selftest@mock_requests.html * igt@i915_suspend@forcewake: - shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111832] / [fdo#111850]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb5/igt@i915_suspend@forcewake.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb7/igt@i915_suspend@forcewake.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite: - shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103167]) +5 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [PASS][27] -> [DMESG-WARN][28] ([fdo#108566]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw: - shard-tglb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#108341]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@kms_psr@no_drrs.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +2 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb3/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_setmode@basic: - shard-kbl: [PASS][35] -> [FAIL][36] ([fdo#99912]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl2/igt@kms_setmode@basic.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-kbl4/igt@kms_setmode@basic.html * igt@prime_busy@after-bsd2: - shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109276]) +12 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@prime_busy@after-bsd2.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb7/igt@prime_busy@after-bsd2.html #### Possible fixes #### * igt@gem_ctx_isolation@bcs0-s3: - shard-tglb: [INCOMPLETE][39] ([fdo#111832]) -> [PASS][40] +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb4/igt@gem_ctx_isolation@bcs0-s3.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb6/igt@gem_ctx_isolation@bcs0-s3.html * igt@gem_ctx_isolation@rcs0-s3: - shard-apl: [DMESG-WARN][41] ([fdo#108566]) -> [PASS][42] +2 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-apl1/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_ctx_persistence@vcs1-mixed-process: - shard-iclb: [SKIP][43] ([fdo#109276] / [fdo#112080]) -> [PASS][44] +3 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb8/igt@gem_ctx_persistence@vcs1-mixed-process.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html * igt@gem_ctx_shared@q-smoketest-vebox: - shard-tglb: [INCOMPLETE][45] ([fdo#111735]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@gem_ctx_shared@q-smoketest-vebox.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb6/igt@gem_ctx_shared@q-smoketest-vebox.html * igt@gem_eio@in-flight-suspend: - shard-tglb: [INCOMPLETE][47] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb3/igt@gem_eio@in-flight-suspend.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb8/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [SKIP][49] ([fdo#112080]) -> [PASS][50] +12 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][51] ([fdo#112146]) -> [PASS][52] +3 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_exec_schedule@smoketest-all: - shard-tglb: [INCOMPLETE][53] ([fdo#111855]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@gem_exec_schedule@smoketest-all.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb3/igt@gem_exec_schedule@smoketest-all.html * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: - shard-hsw: [DMESG-WARN][55] ([fdo#111870]) -> [PASS][56] +1 similar issue [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html - shard-snb: [DMESG-WARN][57] ([fdo#111870]) -> [PASS][58] +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html * igt@gem_userptr_blits@sync-unmap-cycles: - shard-snb: [DMESG-WARN][59] ([fdo#110789] / [fdo#111870]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html * igt@i915_selftest@live_requests: - shard-tglb: [INCOMPLETE][61] ([fdo#112057]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@i915_selftest@live_requests.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb1/igt@i915_selftest@live_requests.html * igt@kms_cursor_legacy@cursor-vs-flip-atomic: - shard-hsw: [FAIL][63] ([fdo#103355]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html * igt@kms_cursor_legacy@cursora-vs-flipa-atomic: - shard-tglb: [INCOMPLETE][65] ([fdo#112035 ]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb3/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy: - shard-apl: [DMESG-WARN][67] -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [DMESG-WARN][69] ([fdo#108566]) -> [PASS][70] +9 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-iclb: [FAIL][71] ([fdo#103167]) -> [PASS][72] +4 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-tglb: [FAIL][73] ([fdo#103167]) -> [PASS][74] +3 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-d: - shard-tglb: [TIMEOUT][75] ([fdo#112168]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb6/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html * igt@kms_psr@psr2_primary_render: - shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@kms_psr@psr2_primary_render.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb2/igt@kms_psr@psr2_primary_render.html * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-hsw: [INCOMPLETE][79] ([fdo#103540]) -> [PASS][80] +1 similar issue [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-hsw2/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend: - shard-tglb: [INCOMPLETE][81] ([fdo#111832] / [fdo#111850]) -> [PASS][82] +2 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb5/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-tglb1/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][83] ([fdo#109276]) -> [PASS][84] +22 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb7/igt@prime_busy@hang-bsd2.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb1/igt@prime_busy@hang-bsd2.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [FAIL][85] ([fdo#111329]) -> [SKIP][86] ([fdo#109276] / [fdo#112080]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv.html * igt@gem_ctx_isolation@vcs1-nonpriv-switch: - shard-iclb: [SKIP][87] ([fdo#109276] / [fdo#112080]) -> [FAIL][88] ([fdo#111329]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html * igt@gem_mocs_settings@mocs-reset-bsd2: - shard-iclb: [FAIL][89] ([fdo#111330]) -> [SKIP][90] ([fdo#109276]) +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_mocs_settings@mocs-reset-bsd2.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb5/igt@gem_mocs_settings@mocs-reset-bsd2.html * igt@gem_userptr_blits@dmabuf-unsync: - shard-hsw: [DMESG-WARN][91] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][92] ([fdo#111870]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw5/igt@gem_userptr_blits@dmabuf-unsync.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-hsw2/igt@gem_userptr_blits@dmabuf-unsync.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][93] ([fdo#109349]) -> [DMESG-WARN][94] ([fdo#107724]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 [fdo#111672]: https://bugs.freedesktop.org/show_bug.cgi?id=111672 [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735 [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832 [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850 [fdo#111855]: https://bugs.freedesktop.org/show_bug.cgi?id=111855 [fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865 [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 [fdo#112035 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112035 [fdo#112057]: https://bugs.freedesktop.org/show_bug.cgi?id=112057 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112081]: https://bugs.freedesktop.org/show_bug.cgi?id=112081 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112158]: https://bugs.freedesktop.org/show_bug.cgi?id=112158 [fdo#112168]: https://bugs.freedesktop.org/show_bug.cgi?id=112168 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (11 -> 8) ------------------------------ Missing (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5268 -> IGTPW_3677 * Piglit: piglit_4509 -> None CI-20190529: 20190529 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3677/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls() 2019-11-09 15:10 [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls() Chris Wilson 2019-11-09 15:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-11-10 22:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2019-11-11 10:47 ` Arkadiusz Hiler 2019-11-13 20:38 ` Summers, Stuart 3 siblings, 0 replies; 5+ messages in thread From: Arkadiusz Hiler @ 2019-11-11 10:47 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev, intel-gfx On Sat, Nov 09, 2019 at 03:10:02PM +0000, Chris Wilson wrote: > igt_aux.h already provides the optimal igt_fls(), so use that in > preference to open coding the brute force version. > > Reported-by: Stuart Summers <stuart.summers@intel.com> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Stuart Summers <stuart.summers@intel.com> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls() 2019-11-09 15:10 [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls() Chris Wilson ` (2 preceding siblings ...) 2019-11-11 10:47 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler @ 2019-11-13 20:38 ` Summers, Stuart 3 siblings, 0 replies; 5+ messages in thread From: Summers, Stuart @ 2019-11-13 20:38 UTC (permalink / raw) To: intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk Cc: igt-dev@lists.freedesktop.org [-- Attachment #1.1: Type: text/plain, Size: 1271 bytes --] On Sat, 2019-11-09 at 15:10 +0000, Chris Wilson wrote: > igt_aux.h already provides the optimal igt_fls(), so use that in > preference to open coding the brute force version. > > Reported-by: Stuart Summers <stuart.summers@intel.com> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Stuart Summers <stuart.summers@intel.com> Thanks for the look here Chris :) -Stuart > --- > tests/i915/gem_blits.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/tests/i915/gem_blits.c b/tests/i915/gem_blits.c > index e0346a7c7..f9cb12bb8 100644 > --- a/tests/i915/gem_blits.c > +++ b/tests/i915/gem_blits.c > @@ -57,16 +57,6 @@ enum mode { > WC, > }; > > -static int fls(uint64_t x) > -{ > - int t; > - > - for (t = 0; x >> t; t++) > - ; > - > - return t; > -} > - > static unsigned int > get_tiling_stride(const struct device *device, > unsigned int width, unsigned int tiling) > @@ -81,7 +71,7 @@ get_tiling_stride(const struct device *device, > else > stride = ALIGN(stride, 128); > if (device->gen < 4) > - stride = 1 << fls(stride - 1); > + stride = 1 << igt_fls(stride - 1); > } else { > if (device->gen >= 8) > stride = ALIGN(stride, 64); [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3270 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-13 20:38 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-11-09 15:10 [igt-dev] [PATCH i-g-t] i915/gem_blits: Use common igt_fls() Chris Wilson 2019-11-09 15:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-11-10 22:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2019-11-11 10:47 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler 2019-11-13 20:38 ` Summers, Stuart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox