Re: [PATCH v2 13/19] tests/intel/xe_exec_multi_queue: Add multi queues with SMEM

["Summers, Stuart" <stuart.summers@intel.com>]

On Thu, 2025-11-20 at 19:57 -0800, Niranjana Vishwanathapura wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Extend multi queue tests with SMEM.

This one is definitely interesting.

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Signed-off-by: Niranjana Vishwanathapura
> <niranjana.vishwanathapura@intel.com>
> ---
>  tests/intel/xe_exec_multi_queue.c | 40 +++++++++++++++++++++++++++--
> --
>  1 file changed, 36 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel/xe_exec_multi_queue.c
> b/tests/intel/xe_exec_multi_queue.c
> index da8117d57..df65ccafb 100644
> --- a/tests/intel/xe_exec_multi_queue.c
> +++ b/tests/intel/xe_exec_multi_queue.c
> @@ -32,6 +32,7 @@
>  #define DYN_PRIORITY           (0x1 << 4)
>  #define INVALIDATE             (0x1 << 5)
>  #define FAULT_MODE             (0x1 << 6)
> +#define SMEM                   (0x1 << 7)
>  
>  #define MAX_INSTANCE 9
>  
> @@ -266,8 +267,11 @@ test_preempt_mode(int fd, struct
> drm_xe_engine_class_instance *eci, int num_plac
>                 }
>                 memset(data, 0, bo_size);
>         } else {
> -               bo = xe_bo_create(fd, vm, bo_size,
> vram_if_possible(fd, eci[0].gt_id),
> -                                
> DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
> +               if (flags & SMEM)
> +                       bo = xe_bo_create(fd, vm, bo_size,
> system_memory(fd), 0);
> +               else
> +                       bo = xe_bo_create(fd, vm, bo_size,
> vram_if_possible(fd, eci[0].gt_id),
> +                                        
> DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
>                 data = xe_bo_map(fd, bo, bo_size);
>         }
>  
> @@ -428,8 +432,11 @@ test_legacy_mode(int fd, struct
> drm_xe_engine_class_instance *eci, int num_place
>                 }
>                 memset(data, 0, bo_size);
>         } else {
> -               bo = xe_bo_create(fd, vm, bo_size,
> vram_if_possible(fd, eci[0].gt_id),
> -                                
> DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
> +               if (flags & SMEM)
> +                       bo = xe_bo_create(fd, vm, bo_size,
> system_memory(fd), 0);
> +               else
> +                       bo = xe_bo_create(fd, vm, bo_size,
> vram_if_possible(fd, eci[0].gt_id),
> +                                        
> DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
>                 data = xe_bo_map(fd, bo, bo_size);
>         }
>  
> @@ -578,23 +585,36 @@ test_legacy_mode(int fd, struct
> drm_xe_engine_class_instance *eci, int num_place
>   * arg[1]:
>   *
>   * @basic:                                     basic
> + * @basic-smem:                                        basic smem
>   * @userptr:                                   userptr
>   * @userptr-invalidate:                                userptr
> invalidate
>   * @priority:                                  priority
>   * @close-fd:                                  close fd without
> destroying exec queues
>   * @dyn-priority:                              dynamic priority
>   * @preempt-mode-basic:                                preempt-mode
> basic
> + * @priority-smem:                             priority smem
> + * @close-fd-smem:                             close fd without
> destroying exec queues smem
> + * @dyn-priority-smem:                         dynamic priority smem
> + * @preempt-mode-basic-smem:                   preempt-mode basic
> smem
>   * @preempt-mode-userptr:                      preempt-mode userptr
>   * @preempt-mode-userptr-invalidate:           preempt-mode userptr
> invalidate
>   * @preempt-mode-priority:                     preempt-mode priority
>   * @preempt-mode-close-fd:                     preempt-mode close fd
> without destroying exec queues
>   * @preempt-mode-dyn-priority:                 preempt-mode dynamic
> priority
>   * @preempt-mode-fault-basic:                  preempt-mode-fault-
> mode basic
> + * @preempt-mode-priority-smem:                        preempt-mode
> priority smem
> + * @preempt-mode-close-fd-smem:                        preempt-mode
> close fd without destroying exec queues smem
> + * @preempt-mode-dyn-priority-smem:            preempt-mode dynamic
> priority smem
> + * @preempt-mode-fault-basic-smem:             preempt-mode-fault-
> mode basic smem
>   * @preempt-mode-fault-userptr:                        preempt-mode-
> fault-mode userptr
>   * @preempt-mode-fault-userptr-invalidate:     preempt-mode-fault-
> mode userptr invalidate
>   * @preempt-mode-fault-priority:               preempt-mode-fault-
> mode priority
>   * @preempt-mode-fault-close-fd:               preempt-mode-fault-
> mode close fd
>   * @preempt-mode-fault-dyn-priority:           preempt-mode-fault-
> mode dynamic priority
> + * @preempt-mode-fault-priority-smem:          preempt-mode-fault-
> mode priority smem
> + * @preempt-mode-fault-close-fd-smem:          preempt-mode-fault-
> mode close fd smem
> + * @preempt-mode-fault-dyn-priority-smem:      preempt-mode-fault-
> mode dynamic priority smem
> + *
>   */
>  static void
>  test_exec(int fd, struct drm_xe_engine_class_instance *eci, int
> num_placement,
> @@ -638,24 +658,36 @@ igt_main
>                 unsigned int flags;
>         } sections[] = {
>                 { "basic", 0 },
> +               { "basic-smem", SMEM },
>                 { "userptr", USERPTR },
>                 { "userptr-invalidate", USERPTR | INVALIDATE },
>                 { "priority", PRIORITY },
> +               { "priority-smem", PRIORITY | SMEM },
>                 { "close-fd", CLOSE_FD },
> +               { "close-fd-smem", CLOSE_FD | SMEM },
>                 { "dyn-priority", DYN_PRIORITY },
> +               { "dyn-priority-smem", DYN_PRIORITY | SMEM },
>                 { "preempt-mode-basic", PREEMPT_MODE },
> +               { "preempt-mode-basic-smem", PREEMPT_MODE | SMEM },
>                 { "preempt-mode-userptr", PREEMPT_MODE | USERPTR },
>                 { "preempt-mode-userptr-invalidate", PREEMPT_MODE |
> USERPTR | INVALIDATE },
>                 { "preempt-mode-priority", PREEMPT_MODE | PRIORITY },
> +               { "preempt-mode-priority-smem", PREEMPT_MODE |
> PRIORITY | SMEM },
>                 { "preempt-mode-close-fd", PREEMPT_MODE | CLOSE_FD },
> +               { "preempt-mode-close-fd-smem", PREEMPT_MODE |
> CLOSE_FD | SMEM },
>                 { "preempt-mode-dyn-priority", PREEMPT_MODE |
> DYN_PRIORITY },
> +               { "preempt-mode-dyn-priority-smem", PREEMPT_MODE |
> DYN_PRIORITY | SMEM },
>                 { "preempt-mode-fault-basic", PREEMPT_MODE |
> FAULT_MODE },
> +               { "preempt-mode-fault-basic-smem", PREEMPT_MODE |
> FAULT_MODE | SMEM },
>                 { "preempt-mode-fault-userptr", PREEMPT_MODE |
> FAULT_MODE | USERPTR },
>                 { "preempt-mode-fault-userptr-invalidate",
> PREEMPT_MODE | FAULT_MODE |
>                         USERPTR | INVALIDATE },
>                 { "preempt-mode-fault-priority", PREEMPT_MODE |
> FAULT_MODE | PRIORITY },
> +               { "preempt-mode-fault-priority-smem", PREEMPT_MODE |
> FAULT_MODE | PRIORITY | SMEM },
>                 { "preempt-mode-fault-close-fd", PREEMPT_MODE |
> FAULT_MODE | CLOSE_FD },
> +               { "preempt-mode-fault-close-fd-smem", PREEMPT_MODE |
> FAULT_MODE | CLOSE_FD | SMEM },
>                 { "preempt-mode-fault-dyn-priority", PREEMPT_MODE |
> FAULT_MODE | DYN_PRIORITY },
> +               { "preempt-mode-fault-dyn-priority-smem",
> PREEMPT_MODE | FAULT_MODE | DYN_PRIORITY | SMEM },
>                 { NULL },
>         };
>         int fd, gt, class;