Re: [PATCH i-g-t] tests/kms_bw: Skip tests when outputs don't support the mode

["Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>]

> 

[snip]

> >  static void run_test_linear_tiling(data_t *data, int pipe, const
> > drmModeModeInfo *mode, bool physical) {
> >         igt_display_t *display = &data->display;
> >         igt_output_t *output;
> > @@ -194,7 +223,7 @@ static void run_test_linear_tiling(data_t
> > *data, int pipe, const drmModeModeInfo
> >         igt_crc_t zero, captured[IGT_MAX_PIPES];
> >         int i = 0, num_pipes = 0;
> >         igt_crtc_t *crtc;
> > -       int ret;
> > +       int ret = -EINVAL;
> > 
> >         /* Cannot use igt_display_n_crtcs() due to fused pipes on
> > i915 where they do
> >          * not give the numver of valid crtcs and always return
> > IGT_MAX_PIPES */
> > @@ -211,7 +240,7 @@ static void run_test_linear_tiling(data_t
> > *data, int pipe, const drmModeModeInfo
> >         /* create buffers */
> >         for (i = 0; i <= pipe; i++) {
> >                 output = physical ? data->connected_output[i] :
> > data->output[i];
> > -               if (!output) {
> > +               if (!output || !output_mode_supported(output,
> > mode)) {
> >                         continue;
> >                 }
> > 
> > @@ -228,7 +257,9 @@ static void run_test_linear_tiling(data_t
> > *data, int pipe, const drmModeModeInfo
> >                 igt_plane_set_fb(data->primary[i], &buffer[i]);
> >                 igt_info("Assigning pipe %s to output %s with mode
> > %s\n",
> >                          kmstest_pipe_name(i),
> > igt_output_name(output), mode->name);
> > +               ret = 0;
> 
> I'd suggest using a dedicated flag instead of reusing `ret`, in case
> another `ret = igt_do_something();` is added before the for loop
> someday, which would overwrite the -EINVAL and invalidate the
> `igt_skip_on_f()` below.
> 
> After which,
> Reviewed-by: Fei Shao <fshao@chromium.org>
> 

Hi Fei,

Thanks for the reviews.
I'll take your suggest and send the next version.

Regards,
Jason-JH Lin

> Regards,
> Fei
> 
> >         }
> > +       igt_skip_on_f(ret != 0, "Unsupported mode for all
> > pipes\n");
> >