public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "karthik.b.s@intel.com" <karthik.b.s@intel.com>,
	"swati2.sharma@intel.com" <swati2.sharma@intel.com>,
	"juhapekka.heikkila@gmail.com" <juhapekka.heikkila@gmail.com>,
	"louis.chauvet@bootlin.com" <louis.chauvet@bootlin.com>,
	"bhanuprakash.modem@gmail.com" <bhanuprakash.modem@gmail.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"kamil.konieczny@linux.intel.com"
	<kamil.konieczny@linux.intel.com>,
	"fshao@chromium.org" <fshao@chromium.org>
Cc: "markyacoub@chromium.org" <markyacoub@chromium.org>,
	"jani.nikula@intel.com" <jani.nikula@intel.com>,
	"Paul-pl Chen (陳柏霖)" <Paul-pl.Chen@mediatek.com>,
	"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"gildekel@google.com" <gildekel@google.com>
Subject: Re: [PATCH i-g-t] tests/kms_bw: Skip tests when outputs don't support the mode
Date: Tue, 10 Mar 2026 07:20:45 +0000	[thread overview]
Message-ID: <dbe45d826484415512b59888fed6a1096450aaa1.camel@mediatek.com> (raw)
In-Reply-To: <e4bd5ad3-9d1f-4be3-941e-004fd57233b8@bootlin.com>


[snip]

> > +static bool output_mode_supported(igt_output_t *output, const
> > drmModeModeInfo *mode)
> > +{
> > +	drmModeConnector *connector = output->config.connector;
> > +	int i;
> > +
> > +	/* Virtual/forced sinks support all modes */
> > +	if (!igt_output_is_connected(output))
> > +		return true;> +	for (i = 0; i < connector-
> > >count_modes; i++) {
> > +		drmModeModeInfo *conn_mode = &connector->modes[i];
> > +
> > +		if (conn_mode->hdisplay == mode->hdisplay &&
> > +		    conn_mode->vdisplay == mode->vdisplay &&
> > +		    conn_mode->vrefresh == mode->vrefresh) {
> > +			igt_info("Found matching mode for
> > %dx%d@%dHz on %s\n",
> > +				 mode->hdisplay, mode->vdisplay,
> > mode->vrefresh,
> > +				 igt_output_name(output));
> 
> Hello,
> 
> I think this should be a igt_debug, I don't think this is useful to
> see 
> it every time in normal operations.
> 
> With or without this:
> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
> 

Hi Louis,

Thanks for the review.
OK! I'll change this to igt_debug.

Regards,
Jason-JH Lin

> Thanks,
> Louis Chauvet


      reply	other threads:[~2026-03-10  7:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 16:03 [PATCH i-g-t] tests/kms_bw: Skip tests when outputs don't support the mode Jason-JH Lin
2026-02-26  0:48 ` ✗ Xe.CI.BAT: failure for " Patchwork
2026-02-26  1:15 ` ✓ i915.CI.BAT: success " Patchwork
2026-02-26  3:58 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-26  5:40 ` ✗ i915.CI.Full: " Patchwork
2026-03-06  7:44 ` [PATCH i-g-t] " Fei Shao
2026-03-09  3:16   ` Jason-JH Lin (林睿祥)
2026-03-09 10:31 ` Louis Chauvet
2026-03-10  7:20   ` Jason-JH Lin (林睿祥) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbe45d826484415512b59888fed6a1096450aaa1.camel@mediatek.com \
    --to=jason-jh.lin@mediatek.com \
    --cc=Nancy.Lin@mediatek.com \
    --cc=Paul-pl.Chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=Singo.Chang@mediatek.com \
    --cc=bhanuprakash.modem@gmail.com \
    --cc=fshao@chromium.org \
    --cc=gildekel@google.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=louis.chauvet@bootlin.com \
    --cc=markyacoub@chromium.org \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox