Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2 1/3] lib/igt_kmod: fix check to confirm correct driver unload
@ 2024-12-19 23:05 Daniele Ceraolo Spurio
  2024-12-19 23:05 ` [PATCH i-g-t v2 2/3] lib/igt_kmod: Make sure errno is not already set before unbinding Daniele Ceraolo Spurio
                   ` (7 more replies)
  0 siblings, 8 replies; 12+ messages in thread
From: Daniele Ceraolo Spurio @ 2024-12-19 23:05 UTC (permalink / raw)
  To: igt-dev; +Cc: Daniele Ceraolo Spurio, Mauro Carvalho Chehab, Kamil Konieczny

The driver variable is a string, so we need to pass it in as a variable
for the driver name instead of stringifying it.

Fixes: e5edf7ea7 ("lib/igt_kmod: add support for Xe driver")
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 lib/igt_kmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index ed283c14b..d73cb4101 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -723,7 +723,7 @@ igt_intel_driver_unload(const char *driver)
 	igt_kmod_unload("drm_kms_helper");
 	igt_kmod_unload("drm");
 
-	if (igt_kmod_is_loaded("driver")) {
+	if (igt_kmod_is_loaded(driver)) {
 		igt_warn("%s.ko still loaded!\n", driver);
 		return -EBUSY;
 	}
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-12-21  1:36 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-19 23:05 [PATCH i-g-t v2 1/3] lib/igt_kmod: fix check to confirm correct driver unload Daniele Ceraolo Spurio
2024-12-19 23:05 ` [PATCH i-g-t v2 2/3] lib/igt_kmod: Make sure errno is not already set before unbinding Daniele Ceraolo Spurio
2024-12-19 23:29   ` Lucas De Marchi
2024-12-19 23:33     ` Daniele Ceraolo Spurio
2024-12-19 23:05 ` [PATCH i-g-t v2 3/3] lib/igt_kmod: Do not explicitly unload intel mei driver Daniele Ceraolo Spurio
2024-12-19 23:21 ` [PATCH i-g-t v2 1/3] lib/igt_kmod: fix check to confirm correct driver unload Lucas De Marchi
2024-12-20  0:49 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,v2,1/3] " Patchwork
2024-12-20  1:45 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-20 18:02 ` [i-g-t, v2, 1/3] " Kamil Konieczny
2024-12-20 19:13   ` Daniele Ceraolo Spurio
2024-12-20 21:46 ` ✗ i915.CI.Full: failure for series starting with [i-g-t,v2,1/3] " Patchwork
2024-12-21  1:36 ` ✗ Xe.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox