Re: [PATCH i-g-t v4] tests/kms_atomic_transition: Add info messages for skipped subtest

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

Hi Sowmiya,

On 11/6/2025 3:22 PM, Sowmiya S wrote:
> Add info messages for subtests that are skipped
> without having proper info messages. This provides
> clearer insight into the reason for skipping.
>
> v2: Add switch case instead of if conditions
>      Also changed the flag name.
> v3: Reframed the info message
>      corrected author name
> v4: declare and initialize flag inside
>      subtest (pranay)
>
> Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
> Reviewed-by: Pranay Samala <pranay.samala@intel.com>
> ---
>   tests/kms_atomic_transition.c | 21 +++++++++++++++++++--
>   1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 419afe4dd..9a74b4297 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -1216,6 +1216,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   
>   		igt_describe(transition_tests[i].desc);
>   		igt_subtest_with_dynamic_f("%s", transition_tests[i].name) {
> +			bool info_flag = false;
>   			pipe_count = 0;
>   
>   			for_each_pipe_with_valid_output(&data.display, pipe, output) {
> @@ -1225,12 +1226,16 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   				 * panels with long power cycle delays.
>   				 */
>   				if ((transition_tests[i].type == TRANSITION_MODESET) &&
> -				    output_is_internal_panel(output))
> +				    output_is_internal_panel(output)) {
> +					info_flag = true;
>   					continue;
> +				}
>   
>   				if ((transition_tests[i].type == TRANSITION_MODESET_FAST) &&
> -				    !output_is_internal_panel(output))
> +				    !output_is_internal_panel(output)) {
> +					info_flag = true;
>   					continue;
> +				}
>   
>   				if (pipe_count == 2 * count && !data.extended)
>   					break;
> @@ -1250,6 +1255,18 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   				test_cleanup(&data, pipe, output,
>   					     transition_tests[i].fencing);
>   			}
> +			if (info_flag && !pipe_count) {
> +				switch (transition_tests[i].type) {
> +				case TRANSITION_MODESET:
> +					igt_info("Skipping test: invalid for internal panel\n");
> +					break;
> +				case TRANSITION_MODESET_FAST:
> +					igt_info("Skipping test: invalid for external panel\n");
> +					break;
> +				default:
> +					break;
> +				}
This logic won't work for multi display config. Check and update the logic.
> +			}
>   		}
>   	}
>