Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v3] tests/kms_atomic_transition: Add info messages for skipped subtest
@ 2025-10-27  4:48 Sowmiya S
  2025-10-27  4:37 ` S, Sowmiya
                   ` (15 more replies)
  0 siblings, 16 replies; 21+ messages in thread
From: Sowmiya S @ 2025-10-27  4:48 UTC (permalink / raw)
  To: igt-dev; +Cc: karthik.b.s, pranay.samala, sowmiya

From: sowmiya <sowmiya.s@intel.com>

Add info messages for subtests that are skipped
without having proper info messages. This provides
clearer insight into the reason for skipping.

v2: Add switch case instead of if conditions
    Also changed the flag name.
v3: Reframed the info message

Signed-off-by: sowmiya <sowmiya.s@intel.com>
---
 tests/kms_atomic_transition.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
index a13830965..3c54604c2 100644
--- a/tests/kms_atomic_transition.c
+++ b/tests/kms_atomic_transition.c
@@ -1172,6 +1172,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	};
 	int i, j, count = 0;
 	int pipe_count = 0;
+	bool info_flag = false;
 
 	igt_fixture {
 		unsigned int debug_mask_if_ci = DRM_UT_KMS;
@@ -1216,6 +1217,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		igt_describe(transition_tests[i].desc);
 		igt_subtest_with_dynamic_f("%s", transition_tests[i].name) {
 			pipe_count = 0;
+			info_flag = false;
 
 			for_each_pipe_with_valid_output(&data.display, pipe, output) {
 				/*
@@ -1224,12 +1226,16 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 				 * panels with long power cycle delays.
 				 */
 				if ((transition_tests[i].type == TRANSITION_MODESET) &&
-				    output_is_internal_panel(output))
+				    output_is_internal_panel(output)) {
+					info_flag = true;
 					continue;
+				}
 
 				if ((transition_tests[i].type == TRANSITION_MODESET_FAST) &&
-				    !output_is_internal_panel(output))
+				    !output_is_internal_panel(output)) {
+					info_flag = true;
 					continue;
+				}
 
 				if (pipe_count == 2 * count && !data.extended)
 					break;
@@ -1249,6 +1255,18 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 				test_cleanup(&data, pipe, output,
 					     transition_tests[i].fencing);
 			}
+			if (info_flag && !pipe_count) {
+				switch (transition_tests[i].type) {
+				case TRANSITION_MODESET:
+					igt_info("Skipping test: invalid for internal panel\n");
+					break;
+				case TRANSITION_MODESET_FAST:
+					igt_info("Skipping test: invalid for external panel\n");
+					break;
+				default:
+					break;
+				}
+			}
 		}
 	}
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2025-11-10 10:11 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27  4:48 [PATCH i-g-t v3] tests/kms_atomic_transition: Add info messages for skipped subtest Sowmiya S
2025-10-27  4:37 ` S, Sowmiya
2025-10-27  5:04 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-10-27  5:06 ` ✗ Fi.CI.BUILD: failure for tests/kms_atomic_transition: Add info messages for skipped subtest (rev2) Patchwork
2025-10-27  5:16 ` ✓ i915.CI.BAT: success for tests/kms_atomic_transition: Add info messages for skipped subtest Patchwork
2025-10-27  5:37 ` [PATCH i-g-t v3] " B, Jeevan
2025-10-27  6:06 ` ✓ Xe.CI.Full: success for " Patchwork
2025-10-27  6:10 ` [PATCH i-g-t v3] " Sowmiya S
2025-11-06  9:16   ` Samala, Pranay
2025-11-06  9:52   ` [PATCH i-g-t v4] " Sowmiya S
2025-11-10  5:14     ` Naladala, Ramanaidu
2025-11-10 10:11       ` S, Sowmiya
2025-10-27  6:33 ` ✓ Xe.CI.BAT: success for tests/kms_atomic_transition: Add info messages for skipped subtest (rev3) Patchwork
2025-10-27  7:19 ` ✗ i915.CI.Full: failure for tests/kms_atomic_transition: Add info messages for skipped subtest Patchwork
2025-10-27  7:38 ` ✗ Xe.CI.Full: failure for tests/kms_atomic_transition: Add info messages for skipped subtest (rev3) Patchwork
2025-10-27  7:39 ` ✓ i915.CI.BAT: success " Patchwork
2025-10-27  8:24 ` ✓ i915.CI.Full: " Patchwork
2025-11-06 20:13 ` ✓ Xe.CI.BAT: success for tests/kms_atomic_transition: Add info messages for skipped subtest (rev4) Patchwork
2025-11-06 21:06 ` ✓ i915.CI.BAT: " Patchwork
2025-11-07 14:44 ` ✗ i915.CI.Full: failure " Patchwork
2025-11-07 18:21 ` ✗ Xe.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox