From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Andi Shyti <andi.shyti@intel.com>,
Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
IGT dev <igt-dev@lists.freedesktop.org>
Cc: Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v21 5/6] lib: igt_dummyload: use for_each_context_engine()
Date: Thu, 18 Apr 2019 09:46:15 +0100 [thread overview]
Message-ID: <826c7416-33a8-b28f-015f-1900242087a6@linux.intel.com> (raw)
In-Reply-To: <155551808147.25904.958785807683888289@skylake-alporthouse-com>
On 17/04/2019 17:21, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-17 17:14:45)
>> So what to do to preserve compatibility with eb.flags and not mess up
>> the context in here.. use the static iterator for contexts wo/ maps and
>> legacy eb? But what does ALL_ENGINES mean then? Phase out ALL_ENGINES
>> support in spin batch? Needs an audit of how many call sites we have and
>> how do they look.
>
> Actually, we've^I've open-coded several callsite that could do with
> ALL_ENGINES. And I think that's a good thing -- as the setup requires a
> bit of finesse and resubmitting the spin batch works quite well. No
> doubt someone else will be tempted to refactor.
I didn't quite get if you want more usages of spin_batch(ALL_ENGINES) or
fewer in the future?
Do we agree that for now at least we don't want to silently modify the
context, and so for now to go with dual paths in the spin batch
constructor, so Andi has a way forward?
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-18 8:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 15:11 [igt-dev] [PATCH v21 0/6] new engine discovery interface Andi Shyti
2019-04-16 15:11 ` [igt-dev] [PATCH v21 1/6] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-04-16 15:11 ` [igt-dev] [PATCH v21 2/6] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-04-16 15:21 ` Chris Wilson
2019-04-16 15:28 ` Andi Shyti
2019-04-16 17:09 ` Tvrtko Ursulin
2019-04-16 15:11 ` [igt-dev] [PATCH v21 3/6] lib: igt_gt: add execution buffer flags to class helper Andi Shyti
2019-04-16 15:11 ` [igt-dev] [PATCH v21 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-04-16 15:11 ` [igt-dev] [PATCH v21 5/6] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-04-17 15:42 ` Daniele Ceraolo Spurio
2019-04-17 15:48 ` Chris Wilson
2019-04-17 16:14 ` Tvrtko Ursulin
2019-04-17 16:21 ` Chris Wilson
2019-04-18 8:46 ` Tvrtko Ursulin [this message]
2019-04-16 15:11 ` [igt-dev] [PATCH v21 6/6] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-04-16 17:06 ` Tvrtko Ursulin
2019-04-16 23:05 ` Andi Shyti
2019-04-17 13:42 ` Tvrtko Ursulin
2019-04-16 16:36 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-04-17 0:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=826c7416-33a8-b28f-015f-1900242087a6@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=chris@chris-wilson.co.uk \
--cc=daniele.ceraolospurio@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox