From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Andi Shyti <andi.shyti@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v21 2/6] lib/i915: add gem_engine_topology library and for_each loop definition
Date: Tue, 16 Apr 2019 18:09:20 +0100 [thread overview]
Message-ID: <fe5d2206-7163-4d99-6a55-7cfd22663662@linux.intel.com> (raw)
In-Reply-To: <20190416152827.GA2611@intel.intel>
On 16/04/2019 16:28, Andi Shyti wrote:
>>> +void gem_unset_context_engines(int fd, uint32_t ctx)
>>> +{
>>> + gem_context_destroy(fd, ctx);
>>> +}
>>
>> That's a little surprising. I certainly would not expect my context to
>> be destroyed just to reset the engines back to default.
>>
>> On the Rusty scale that would be
>> -7. The obvious use is wrong.
>
> if I have a context creator 'gem_make_context_set_all_engines()'
> (which you already didn't like at the previous version), I should
> have a context destroyer.
>
> I understand your concern, I will remove the context creation and
> destruction from gem_engine_topology.
Yes I only asked for a helper to create a default/full engine map on a
context. :) (So one call site does not have to abuse the
intel_init_engines or so.)
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-16 17:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 15:11 [igt-dev] [PATCH v21 0/6] new engine discovery interface Andi Shyti
2019-04-16 15:11 ` [igt-dev] [PATCH v21 1/6] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-04-16 15:11 ` [igt-dev] [PATCH v21 2/6] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-04-16 15:21 ` Chris Wilson
2019-04-16 15:28 ` Andi Shyti
2019-04-16 17:09 ` Tvrtko Ursulin [this message]
2019-04-16 15:11 ` [igt-dev] [PATCH v21 3/6] lib: igt_gt: add execution buffer flags to class helper Andi Shyti
2019-04-16 15:11 ` [igt-dev] [PATCH v21 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-04-16 15:11 ` [igt-dev] [PATCH v21 5/6] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-04-17 15:42 ` Daniele Ceraolo Spurio
2019-04-17 15:48 ` Chris Wilson
2019-04-17 16:14 ` Tvrtko Ursulin
2019-04-17 16:21 ` Chris Wilson
2019-04-18 8:46 ` Tvrtko Ursulin
2019-04-16 15:11 ` [igt-dev] [PATCH v21 6/6] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-04-16 17:06 ` Tvrtko Ursulin
2019-04-16 23:05 ` Andi Shyti
2019-04-17 13:42 ` Tvrtko Ursulin
2019-04-16 16:36 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-04-17 0:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe5d2206-7163-4d99-6a55-7cfd22663662@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox