Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: Re: [PATCH i-g-t 2/2] tools/xe-perf: Change xe_perf_recorder command line to use OA unit id
Date: Fri, 13 Jun 2025 18:12:26 -0700	[thread overview]
Message-ID: <851prnktxh.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250614010827.3477175-3-ashutosh.dixit@intel.com>

On Fri, 13 Jun 2025 18:08:27 -0700, Ashutosh Dixit wrote:
>
> Xe OA uapi identifies an OA unit by means of its OA unit id.
> xe_perf_recorder was instead using engine class/instance to identify the OA
> unit, in order to have a common command line with i915_perf_recorder.
>
> However, Xe KMD now supports new OA units, which don't have any associated
> engines. This means that it is not possible to use engine class/instance to
> identify these OA units and these OA units must instead be identified by
> means of the OA unit id, as originally intended in Xe OA uapi.
>
> Therefore, change xe_perf_recorder command line to use OA unit id instead
> of engine class/instance to identify the OA unit.

After this patch is reviewed, we will create a gpuvis PR to update the
xe_perf_recorder command line in gpuvis scripts.

  reply	other threads:[~2025-06-14  1:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-14  1:08 [PATCH i-g-t 0/2] Xe-perf tools update for OAM Ashutosh Dixit
2025-06-14  1:08 ` [PATCH i-g-t 1/2] drm-uapi/xe: Sync with OAM uapi updates Ashutosh Dixit
2025-06-16 17:48   ` Umesh Nerlige Ramappa
2025-06-14  1:08 ` [PATCH i-g-t 2/2] tools/xe-perf: Change xe_perf_recorder command line to use OA unit id Ashutosh Dixit
2025-06-14  1:12   ` Dixit, Ashutosh [this message]
2025-06-16 17:47   ` Umesh Nerlige Ramappa
2025-06-14  2:03 ` ✓ Xe.CI.BAT: success for Xe-perf tools update for OAM Patchwork
2025-06-14  2:07 ` ✗ i915.CI.BAT: failure " Patchwork
2025-06-16  4:22 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=851prnktxh.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox