Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org,
	Ashutosh Dixit <ashutosh.dixit@intel.com>,
	Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: Re: [PATCH i-g-t 1/2] drm-uapi/xe: Sync with OA syncs uapi update
Date: Tue, 29 Oct 2024 12:38:59 -0700	[thread overview]
Message-ID: <851pzyzoks.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20241028151655.ysgah2k2rn7qxck4@kamilkon-desk.igk.intel.com>

On Mon, 28 Oct 2024 08:16:55 -0700, Kamil Konieczny wrote:
>
> Hi Ashutosh,
> On 2024-10-25 at 11:52:04 -0700, Ashutosh Dixit wrote:
> > Align with kernel commit c8507a25cebd ("drm/xe/oa/uapi: Define and parse OA
> > sync properties") which adds OA syncs uapi.
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> >  include/drm-uapi/xe_drm.h | 29 ++++++++++++++++++++++++-----
> >  1 file changed, 24 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
> > index f0a450db95..4a8a4a63e9 100644
> > --- a/include/drm-uapi/xe_drm.h
> > +++ b/include/drm-uapi/xe_drm.h
> > @@ -3,8 +3,8 @@
> >   * Copyright © 2023 Intel Corporation
> >   */
> >
> > -#ifndef _XE_DRM_H_
> > -#define _XE_DRM_H_
> > +#ifndef _UAPI_XE_DRM_H_
> > +#define _UAPI_XE_DRM_H_
>
> imho this shouldn't be here, did you use
> make INSTALL_HDR_PATH=<dest-dir> headers_install
>
> documented in README.md?

Thanks Kamil, I didn't know about INSTALL_HDR_PATH. Will fix this in the
next version.

Thanks.
--
Ashutosh

  reply	other threads:[~2024-10-29 19:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 18:52 [PATCH i-g-t 0/2] tests/intel/oa: Tests for OA syncs Ashutosh Dixit
2024-10-25 18:52 ` [PATCH i-g-t 1/2] drm-uapi/xe: Sync with OA syncs uapi update Ashutosh Dixit
2024-10-25 19:36   ` Umesh Nerlige Ramappa
2024-10-28 15:16   ` Kamil Konieczny
2024-10-29 19:38     ` Dixit, Ashutosh [this message]
2024-10-25 18:52 ` [PATCH i-g-t 2/2] tests/intel/xe_oa: Tests for OA syncs Ashutosh Dixit
2024-10-25 19:35   ` Umesh Nerlige Ramappa
2024-10-25 19:45     ` Dixit, Ashutosh
2024-10-25 22:02 ` ✓ Fi.CI.BAT: success for tests/intel/oa: Tests for OA syncs (rev4) Patchwork
2024-10-25 22:28 ` ✓ CI.xeBAT: " Patchwork
2024-10-27 12:56 ` ✗ CI.xeFULL: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-10-30  2:53 [PATCH i-g-t v5 0/2] tests/intel/oa: Tests for OA syncs Ashutosh Dixit
2024-10-30  2:53 ` [PATCH i-g-t 1/2] drm-uapi/xe: Sync with OA syncs uapi update Ashutosh Dixit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=851pzyzoks.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox