From: "Ser, Simon" <simon.ser@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "Latvala, Petri" <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable
Date: Thu, 28 Mar 2019 07:59:04 +0000 [thread overview]
Message-ID: <85345a3cd06beeebed677d0d7333a90b8a9a2e40.camel@intel.com> (raw)
In-Reply-To: <155315913079.22764.16577903388199927509@skylake-alporthouse-com>
On Thu, 2019-03-21 at 09:05 +0000, Chris Wilson wrote:
> Quoting Simon Ser (2019-03-21 08:59:38)
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> > tests/i915/gem_exec_latency.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/i915/gem_exec_latency.c
> > b/tests/i915/gem_exec_latency.c
> > index 6dd191ec..1b022df5 100644
> > --- a/tests/i915/gem_exec_latency.c
> > +++ b/tests/i915/gem_exec_latency.c
> > @@ -597,7 +597,7 @@ rthog_latency_on_ring(int fd, unsigned int
> > engine, const char *name, unsigned in
> > for (unsigned int child = 0; child < nengine; child++) {
> > struct rt_pkt normal = results[NPASS * child + 1];
> > igt_stats_t stats;
> > - double variance;
> > + double variance = 0.0;
>
> I know I reviewed a patch by Petri with the same fix...
> -Chris
Indeed: https://patchwork.freedesktop.org/patch/291893/
I'll mark this one as superseeded.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-28 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 8:59 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable Simon Ser
2019-03-21 9:05 ` Chris Wilson
2019-03-28 7:59 ` Ser, Simon [this message]
2019-03-28 8:02 ` Chris Wilson
2019-03-21 10:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-21 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85345a3cd06beeebed677d0d7333a90b8a9a2e40.camel@intel.com \
--to=simon.ser@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox