* [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable
@ 2019-03-21 8:59 Simon Ser
2019-03-21 9:05 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Simon Ser @ 2019-03-21 8:59 UTC (permalink / raw)
To: igt-dev
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
tests/i915/gem_exec_latency.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_latency.c b/tests/i915/gem_exec_latency.c
index 6dd191ec..1b022df5 100644
--- a/tests/i915/gem_exec_latency.c
+++ b/tests/i915/gem_exec_latency.c
@@ -597,7 +597,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned in
for (unsigned int child = 0; child < nengine; child++) {
struct rt_pkt normal = results[NPASS * child + 1];
igt_stats_t stats;
- double variance;
+ double variance = 0.0;
igt_stats_init_with_size(&stats, NPASS);
--
2.21.0
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable
2019-03-21 8:59 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable Simon Ser
@ 2019-03-21 9:05 ` Chris Wilson
2019-03-28 7:59 ` Ser, Simon
2019-03-21 10:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-21 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2019-03-21 9:05 UTC (permalink / raw)
To: Simon Ser, igt-dev; +Cc: Petri Latvala
Quoting Simon Ser (2019-03-21 08:59:38)
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> ---
> tests/i915/gem_exec_latency.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_latency.c b/tests/i915/gem_exec_latency.c
> index 6dd191ec..1b022df5 100644
> --- a/tests/i915/gem_exec_latency.c
> +++ b/tests/i915/gem_exec_latency.c
> @@ -597,7 +597,7 @@ rthog_latency_on_ring(int fd, unsigned int engine, const char *name, unsigned in
> for (unsigned int child = 0; child < nengine; child++) {
> struct rt_pkt normal = results[NPASS * child + 1];
> igt_stats_t stats;
> - double variance;
> + double variance = 0.0;
I know I reviewed a patch by Petri with the same fix...
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable
2019-03-21 9:05 ` Chris Wilson
@ 2019-03-28 7:59 ` Ser, Simon
2019-03-28 8:02 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Ser, Simon @ 2019-03-28 7:59 UTC (permalink / raw)
To: igt-dev@lists.freedesktop.org, chris@chris-wilson.co.uk; +Cc: Latvala, Petri
On Thu, 2019-03-21 at 09:05 +0000, Chris Wilson wrote:
> Quoting Simon Ser (2019-03-21 08:59:38)
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> > tests/i915/gem_exec_latency.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/i915/gem_exec_latency.c
> > b/tests/i915/gem_exec_latency.c
> > index 6dd191ec..1b022df5 100644
> > --- a/tests/i915/gem_exec_latency.c
> > +++ b/tests/i915/gem_exec_latency.c
> > @@ -597,7 +597,7 @@ rthog_latency_on_ring(int fd, unsigned int
> > engine, const char *name, unsigned in
> > for (unsigned int child = 0; child < nengine; child++) {
> > struct rt_pkt normal = results[NPASS * child + 1];
> > igt_stats_t stats;
> > - double variance;
> > + double variance = 0.0;
>
> I know I reviewed a patch by Petri with the same fix...
> -Chris
Indeed: https://patchwork.freedesktop.org/patch/291893/
I'll mark this one as superseeded.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable
2019-03-28 7:59 ` Ser, Simon
@ 2019-03-28 8:02 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-03-28 8:02 UTC (permalink / raw)
To: Ser, Simon, igt-dev@lists.freedesktop.org; +Cc: Latvala, Petri
Quoting Ser, Simon (2019-03-28 07:59:04)
> On Thu, 2019-03-21 at 09:05 +0000, Chris Wilson wrote:
> > Quoting Simon Ser (2019-03-21 08:59:38)
> > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > ---
> > > tests/i915/gem_exec_latency.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/i915/gem_exec_latency.c
> > > b/tests/i915/gem_exec_latency.c
> > > index 6dd191ec..1b022df5 100644
> > > --- a/tests/i915/gem_exec_latency.c
> > > +++ b/tests/i915/gem_exec_latency.c
> > > @@ -597,7 +597,7 @@ rthog_latency_on_ring(int fd, unsigned int
> > > engine, const char *name, unsigned in
> > > for (unsigned int child = 0; child < nengine; child++) {
> > > struct rt_pkt normal = results[NPASS * child + 1];
> > > igt_stats_t stats;
> > > - double variance;
> > > + double variance = 0.0;
> >
> > I know I reviewed a patch by Petri with the same fix...
> > -Chris
>
> Indeed: https://patchwork.freedesktop.org/patch/291893/
>
> I'll mark this one as superseeded.
And I pushed Petri's so that warning should disappear.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_exec_latency: fix uninitialized variable
2019-03-21 8:59 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable Simon Ser
2019-03-21 9:05 ` Chris Wilson
@ 2019-03-21 10:57 ` Patchwork
2019-03-21 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-21 10:57 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
== Series Details ==
Series: tests/i915/gem_exec_latency: fix uninitialized variable
URL : https://patchwork.freedesktop.org/series/58339/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5787 -> IGTPW_2678
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58339/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2678 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@gtt-bsd:
- fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] +103
* igt@gem_exec_basic@readonly-bsd1:
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] +57
* igt@i915_selftest@live_uncore:
- fi-ivb-3770: PASS -> DMESG-FAIL [fdo#110210]
* igt@kms_busy@basic-flip-c:
- fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_force_connector_basic@force-load-detect:
- fi-bxt-j4205: NOTRUN -> SKIP [fdo#109271] +47
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_psr@primary_mmap_gtt:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +27
#### Possible fixes ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210
Participating hosts (42 -> 37)
------------------------------
Additional (3): fi-bxt-j4205 fi-bwr-2160 fi-snb-2520m
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4896 -> IGTPW_2678
CI_DRM_5787: 8a27af0b94f56d403bc7806a64a50013a2dd9396 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2678: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2678/
IGT_4896: 0f9c061247fb7aba21c9459f19f437927a28f32c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2678/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_exec_latency: fix uninitialized variable
2019-03-21 8:59 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable Simon Ser
2019-03-21 9:05 ` Chris Wilson
2019-03-21 10:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-21 20:44 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-21 20:44 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
== Series Details ==
Series: tests/i915/gem_exec_latency: fix uninitialized variable
URL : https://patchwork.freedesktop.org/series/58339/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5787_full -> IGTPW_2678_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2678_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2678_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58339/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2678_full:
### IGT changes ###
#### Warnings ####
* igt@gem_mmap_gtt@forked-basic-small-copy-xy:
- shard-snb: PASS -> ( 2 PASS ) +37
Known issues
------------
Here are the changes found in IGTPW_2678_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@unwedge-stress:
- shard-snb: PASS -> FAIL [fdo#109661]
* igt@gem_wait@wait-bsd2:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +33
* igt@i915_hangman@error-state-capture-bsd2:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +17
* igt@kms_busy@basic-flip-d:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: PASS -> DMESG-WARN [fdo#107956] +1
- shard-hsw: PASS -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-pageflip-hang-oldfb-render-e:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render:
- shard-snb: NOTRUN -> ( 2 SKIP ) [fdo#109271]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-glk: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +40
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145]
- shard-kbl: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@kms_setmode@basic:
- shard-kbl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: PASS -> FAIL [fdo#104894] +3
- shard-kbl: PASS -> FAIL [fdo#104894]
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-glk: PASS -> FAIL [fdo#105010]
* igt@prime_nv_test@i915_import_pread_pwrite:
- shard-apl: NOTRUN -> SKIP [fdo#109271]
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS +1
- shard-apl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
- shard-apl: FAIL [fdo#103232] -> PASS +1
* {igt@kms_plane@pixel-format-pipe-a-planes}:
- shard-glk: SKIP [fdo#109271] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm:
- shard-apl: FAIL [fdo#104894] -> PASS
#### Warnings ####
* igt@kms_pipe_crc_basic@read-crc-pipe-f:
- shard-snb: SKIP [fdo#109271] / [fdo#109278] -> ( 2 SKIP ) [fdo#109271] / [fdo#109278] +1
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: INCOMPLETE [fdo#103665] -> FAIL [fdo#109016]
* igt@perf_pmu@busy-check-all-vecs0:
- shard-snb: SKIP [fdo#109271] -> ( 2 SKIP ) [fdo#109271] +36
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4896 -> IGTPW_2678
* Piglit: piglit_4509 -> None
CI_DRM_5787: 8a27af0b94f56d403bc7806a64a50013a2dd9396 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2678: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2678/
IGT_4896: 0f9c061247fb7aba21c9459f19f437927a28f32c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2678/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-28 8:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-21 8:59 [igt-dev] [PATCH i-g-t] tests/i915/gem_exec_latency: fix uninitialized variable Simon Ser
2019-03-21 9:05 ` Chris Wilson
2019-03-28 7:59 ` Ser, Simon
2019-03-28 8:02 ` Chris Wilson
2019-03-21 10:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-21 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox