Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Daniel Charles <daniel.charles@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH] tests/intel/xe_exec_reset: expect error or complete on CAT_ERROR
Date: Fri, 19 Sep 2025 16:59:52 -0700	[thread overview]
Message-ID: <854isyxabr.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250919222836.82407-1-daniel.charles@intel.com>

On Fri, 19 Sep 2025 15:28:36 -0700, Daniel Charles wrote:
>
> when running cm job, it could be that after the fence is checked, a
> CAT_ERROR will throw an error in the same way as GT_RESET does.
>
> Signed-off-by: Daniel Charles <daniel.charles@intel.com>
> ---
>  tests/intel/xe_exec_reset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
> index 7ae53c679..73c5c7e20 100644
> --- a/tests/intel/xe_exec_reset.c
> +++ b/tests/intel/xe_exec_reset.c
> @@ -433,7 +433,7 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci,
>
>		err = __xe_wait_ufence(fd, &data[i].exec_sync, USER_FENCE_VALUE,
>				       exec_queues[i % n_exec_queues], &timeout);
> -		if (flags & GT_RESET)
> +		if (flags & GT_RESET || flags & CAT_ERROR)

Hi Daniel,

1. Is there a gitlab bug about this? If yes, could you please add a
   'Closes:' tag to this patch (see git log)

2. Would you have a reference to the kernel code that a CAT error returns
   -EIO?

Thanks.
--
Ashutosh

>			/* exec races with reset: may return -EIO or complete */
>			igt_assert(err == -EIO || !err);
>		else
> --
> 2.43.0
>

  parent reply	other threads:[~2025-09-19 23:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19 22:28 [PATCH] tests/intel/xe_exec_reset: expect error or complete on CAT_ERROR Daniel Charles
2025-09-19 23:34 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-09-19 23:39 ` ✓ i915.CI.BAT: " Patchwork
2025-09-19 23:59 ` Dixit, Ashutosh [this message]
2025-09-20  0:07   ` [PATCH] " Daniel Charles
2025-09-22 15:35     ` Dixit, Ashutosh
2025-09-20  6:51 ` ✗ Xe.CI.Full: failure for " Patchwork
2025-09-20 19:00 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=854isyxabr.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=daniel.charles@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox