Re: [PATCH i-g-t v2 08/14] tests/intel/xe_oa: Simplify the buffer-fill test

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 03 Mar 2025 16:28:08 -0800, Dixit, Ashutosh wrote:
>
> On Mon, 03 Mar 2025 15:14:56 -0800, Umesh Nerlige Ramappa wrote:
> >
> >  static struct intel_xe_perf_metric_set *metric_set(const struct drm_xe_engine_class_instance *hwe)
> >  {
> > @@ -1092,6 +1093,7 @@ init_sys_info(void)
> >
> >	rc_width = 1920;
> >	rc_height = 1080;
> > +	buffer_fill_size = SZ_16M;
>
> Sorry, missed this earlier. Note that there is a default_oa_buffer_size,
> just below. Can we use that or we need this new buffer_fill_size variable?
>
> The kernel will return a constant default_oa_buffer_size of 16 M (at least
> for now).
>
> We can fix this later too if needed, so not need to spin a new version for
> now for this. We can do this if we see any other reason for a new version,
> till now doesn't look like it.

Sorry, this is not an issue, buffer_fill_size is used to set an OA buffer
size. So presumably it can be reduced for slower platforms.

>
> >	oa_exponent_default = max_oa_exponent_for_period_lte(1000000);
> >
> >	default_oa_buffer_size = get_default_oa_buffer_size(drm_fd);