Re: [PATCH i-g-t v2 03/14] tests/intel/xe_oa: Use period_ns in max_oa_exponent_for_period_lte

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 03 Mar 2025 15:14:51 -0800, Umesh Nerlige Ramappa wrote:
>
> Rename the argument in max_oa_exponent_for_period_lte() to period_ns to
> specify the units of the period.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
>  tests/intel/xe_oa.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 5c68f1d79..b15958de6 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -688,10 +688,10 @@ timebase_scale(uint64_t delta)
>  }
>
>  /* Returns: the largest OA exponent that will still result in a sampling period
> - * less than or equal to the given @period.
> + * less than or equal to the given @period_ns.
>   */
>  static int
> -max_oa_exponent_for_period_lte(uint64_t period)
> +max_oa_exponent_for_period_lte(uint64_t period_ns)
>  {
>	/* NB: timebase_scale() takes a uint64_t and an exponent of 30
>	 * would already represent a period of ~3 minutes so there's
> @@ -700,7 +700,7 @@ max_oa_exponent_for_period_lte(uint64_t period)
>	for (int i = 0; i < 30; i++) {
>		uint64_t oa_period = timebase_scale(2 << i);
>
> -		if (oa_period > period)
> +		if (oa_period > period_ns)
>			return max(0, i - 1);
>	}
>
> --
> 2.34.1
>