Re: [PATCH i-g-t] lib: Add ARL-S PCI ID for perf tests

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Sun, 04 Feb 2024 22:01:39 -0800, Chaitanya Kumar Borah wrote:
>

Hi Chaitanya,

> Enable perf tests on ARL-S
>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>  lib/i915_pciids_local.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/i915_pciids_local.h b/lib/i915_pciids_local.h
> index a0ca29ee7..0043b0cd9 100644
> --- a/lib/i915_pciids_local.h
> +++ b/lib/i915_pciids_local.h
> @@ -10,7 +10,8 @@
>  /* MTL perf */
>  #ifndef INTEL_MTL_M_IDS
>  #define INTEL_MTL_M_IDS(info) \
> -	INTEL_VGA_DEVICE(0x7D60, info)
> +	INTEL_VGA_DEVICE(0x7D60, info), \
> +	INTEL_VGA_DEVICE(0x7D67, info)

1. Did you check if this fixes the OA tests on ARL? Or this will enable
   the testing?

2. Why not include all ARL PCI ID's? Seem to be already there in kernel
   include/drm/i915_pciids.h. Also:

   https://gfxspecs.intel.com/Predator/Home/Index/55420

3. How about moving all these MTL/ARL ID's into lib/i915_pciids.h from
   lib/i915_pciids_local.h?

Thanks.
--
Ashutosh