Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Harish Chegondi <harish.chegondi@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t v2 2/2] tests/intel/xe_eu_stall: Add tests for EU stall sampling
Date: Mon, 03 Mar 2025 11:11:29 -0800	[thread overview]
Message-ID: <85frju53q6.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <97b6c6425406e966c8831aec0d26ef6d53c8b4dd.1739901972.git.harish.chegondi@intel.com>

On Tue, 18 Feb 2025 10:21:27 -0800, Harish Chegondi wrote:
>
> +const char *help_str =  "  --event_count | -e\t\tPoll event report count\n"
> +			"  --gt_id | -g\t\tGT ID for the GT to sample EU stalls\n"
> +			"  --output | -o\t\tOutput file to write EU stall data\n"
> +			"  --rate | -r\t\tSampling rate in GPU cycles\n"
> +			"  --user_buf_sz | -u\t\tUser buffer size\n"
> +			"  --workload | -w\t\tWorkload to run\n";
> +
> +static struct option long_options[] = {
> +	{"event_count", 0, 0, 'e'},
> +	{"gt_id", 0, 0, 'g'},
> +	{"output", 0, 0, 'o'},
> +	{"rate", 0, 0, 'r'},
> +	{"user_buf_sz", 0, 0, 'u'},
> +	{"workload", 0, 0, 'w'},
> +	{ NULL, 0, 0, 0 }

The tests should probably be extended in the future by iterating over some
of these parameters (such as user buffer size, sampling rate, event
count). But this is good patch is good enough starting point, so this is
now:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

  reply	other threads:[~2025-03-03 19:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 18:21 [PATCH i-g-t v2 0/2] Add tests for EU stall sampling Harish Chegondi
2025-02-18 18:21 ` [PATCH i-g-t v2 1/2] drm-uapi/xe: Sync with EU stall sampling uapi updates Harish Chegondi
2025-03-03 19:11   ` Dixit, Ashutosh
2025-02-18 18:21 ` [PATCH i-g-t v2 2/2] tests/intel/xe_eu_stall: Add tests for EU stall sampling Harish Chegondi
2025-03-03 19:11   ` Dixit, Ashutosh [this message]
2025-02-18 19:16 ` ✓ Xe.CI.BAT: success for Add tests for EU stall sampling (rev2) Patchwork
2025-02-18 19:34 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-19 12:26 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85frju53q6.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=harish.chegondi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox