Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: <igt-dev@lists.freedesktop.org>,
	<kamil.konieczny@linux.intel.com>, <lucas.demarchi@intel.com>,
	<adrinael@adrinael.net>
Subject: Re: [PATCH i-g-t v2] lib/igt_core: Add ftrace logs at test boundaries
Date: Fri, 21 Feb 2025 16:18:38 -0800	[thread overview]
Message-ID: <85h64momqp.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250221223823.2336228-1-umesh.nerlige.ramappa@intel.com>

On Fri, 21 Feb 2025 14:38:23 -0800, Umesh Nerlige Ramappa wrote:
>
> When looking at kernel ftrace output, it would really help to see the
> test start/exit boundaries.
>
> v2: Fix copy paste error

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
>  lib/igt_core.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index b95db1b25..9702a9417 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1324,6 +1324,7 @@ out:
>	if (!igt_only_list_subtests()) {
>		bind_fbcon(false);
>		igt_kmsg(KMSG_INFO "%s: executing\n", command_str);
> +		igt_trace("%s: executing\n", command_str);
>		print_version();
>		igt_srandom();
>
> @@ -1528,6 +1529,7 @@ bool __igt_run_subtest(const char *subtest_name, const char *file, const int lin
>
>	igt_kmsg(KMSG_INFO "%s: starting subtest %s\n",
>		 command_str, subtest_name);
> +	igt_trace("%s: starting subtest %s\n", command_str, subtest_name);
>	_subtest_starting_message(_SUBTEST_TYPE_NORMAL, subtest_name);
>
>	_igt_log_buffer_reset();
> @@ -1681,6 +1683,8 @@ __noreturn static void exit_subtest(const char *result)
>				igt_time_elapsed(thentime, &now));
>	igt_kmsg(KMSG_INFO "%s: finished subtest %s, %s\n",
>		 command_str, *subtest_name, result);
> +	igt_trace("%s: finished subtest %s, %s\n",
> +		  command_str, *subtest_name, result);
>
>	igt_terminate_spins();
>
> --
> 2.34.1
>

  parent reply	other threads:[~2025-02-22  0:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 22:38 [PATCH i-g-t v2] lib/igt_core: Add ftrace logs at test boundaries Umesh Nerlige Ramappa
2025-02-21 23:52 ` ✓ i915.CI.BAT: success for lib/igt_core: Add ftrace logs at test boundaries (rev2) Patchwork
2025-02-21 23:58 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-22  0:18 ` Dixit, Ashutosh [this message]
2025-02-22  1:50 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-24 12:08   ` Kamil Konieczny
2025-02-22 13:38 ` ✗ Xe.CI.Full: " Patchwork
2025-02-24 12:09   ` Kamil Konieczny
2025-02-24 10:41 ` [PATCH i-g-t v2] lib/igt_core: Add ftrace logs at test boundaries Krzysztof Karas
2025-02-24 12:01 ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85h64momqp.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=adrinael@adrinael.net \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox