* [PATCH] tests/intel/xe_exec_reset: Explicitly declare exec
@ 2024-10-14 21:39 Jonathan Cavitt
2024-10-14 21:45 ` Dixit, Ashutosh
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cavitt @ 2024-10-14 21:39 UTC (permalink / raw)
To: igt-dev; +Cc: jonathan.cavitt, saurabhg.gupta, alex.zuo, jani.saarinen
In the gt-reset-stress subtest, we define a drm_xe_exec exec without
declaring any of its variable values. Explicitly declare exec to equal
an empty struct to prevent any values from being assigned garbage data
during execution.
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: Jani Saarinen <jani.saarinen@intel.com>
---
tests/intel/xe_exec_reset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
index b5d5f43eab..fdfefa91cc 100644
--- a/tests/intel/xe_exec_reset.c
+++ b/tests/intel/xe_exec_reset.c
@@ -628,7 +628,7 @@ static void submit_jobs(struct gt_thread_data *t)
.engine_instance = 0,
.gt_id = 0,
};
- struct drm_xe_exec exec;
+ struct drm_xe_exec exec = {};
int ret;
/* GuC IDs can get exhausted */
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tests/intel/xe_exec_reset: Explicitly declare exec
2024-10-14 21:39 [PATCH] tests/intel/xe_exec_reset: Explicitly declare exec Jonathan Cavitt
@ 2024-10-14 21:45 ` Dixit, Ashutosh
2024-10-14 21:50 ` Cavitt, Jonathan
0 siblings, 1 reply; 4+ messages in thread
From: Dixit, Ashutosh @ 2024-10-14 21:45 UTC (permalink / raw)
To: Jonathan Cavitt; +Cc: igt-dev, saurabhg.gupta, alex.zuo, jani.saarinen
On Mon, 14 Oct 2024 14:39:36 -0700, Jonathan Cavitt wrote:
>
> diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
> index b5d5f43eab..fdfefa91cc 100644
> --- a/tests/intel/xe_exec_reset.c
> +++ b/tests/intel/xe_exec_reset.c
> @@ -628,7 +628,7 @@ static void submit_jobs(struct gt_thread_data *t)
> .engine_instance = 0,
> .gt_id = 0,
> };
> - struct drm_xe_exec exec;
> + struct drm_xe_exec exec = {};
> int ret;
>
How about
struct drm_xe_exec exec = {
.num_batch_buffer = 1,
.address = addr,
};
And delete the assignments below?
> /* GuC IDs can get exhausted */
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] tests/intel/xe_exec_reset: Explicitly declare exec
2024-10-14 21:45 ` Dixit, Ashutosh
@ 2024-10-14 21:50 ` Cavitt, Jonathan
0 siblings, 0 replies; 4+ messages in thread
From: Cavitt, Jonathan @ 2024-10-14 21:50 UTC (permalink / raw)
To: Dixit, Ashutosh
Cc: igt-dev@lists.freedesktop.org, Gupta, saurabhg, Zuo, Alex,
Saarinen, Jani, Cavitt, Jonathan
-----Original Message-----
From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
Sent: Monday, October 14, 2024 2:46 PM
To: Cavitt, Jonathan <jonathan.cavitt@intel.com>
Cc: igt-dev@lists.freedesktop.org; Gupta, saurabhg <saurabhg.gupta@intel.com>; Zuo, Alex <alex.zuo@intel.com>; Saarinen, Jani <jani.saarinen@intel.com>
Subject: Re: [PATCH] tests/intel/xe_exec_reset: Explicitly declare exec
>
> On Mon, 14 Oct 2024 14:39:36 -0700, Jonathan Cavitt wrote:
> >
> > diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
> > index b5d5f43eab..fdfefa91cc 100644
> > --- a/tests/intel/xe_exec_reset.c
> > +++ b/tests/intel/xe_exec_reset.c
> > @@ -628,7 +628,7 @@ static void submit_jobs(struct gt_thread_data *t)
> > .engine_instance = 0,
> > .gt_id = 0,
> > };
> > - struct drm_xe_exec exec;
> > + struct drm_xe_exec exec = {};
> > int ret;
> >
>
> How about
>
> struct drm_xe_exec exec = {
> .num_batch_buffer = 1,
> .address = addr,
> };
>
> And delete the assignments below?
Good catch!
I'll apply this change shortly and change the commit message
to reflect the new implementation.
-Jonathan Cavitt
>
> > /* GuC IDs can get exhausted */
> > --
> > 2.43.0
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] tests/intel/xe_exec_reset: Explicitly declare exec
@ 2024-10-14 21:31 Jonathan Cavitt
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cavitt @ 2024-10-14 21:31 UTC (permalink / raw)
To: igt-dev; +Cc: jonathan.cavitt, saurabhg.gupta, alex.zuo, jani.saarinen
In the gt-reset-stress subtest, we define a drm_xe_exec exec without
declaring any of its variable values. Explicitly declare exec to equal
an empty struct to prevent any values from being assigned garbage data
during execution.
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: Jani Saarinen <jani.saarinen@intel.com>
---
tests/intel/xe_exec_reset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
index b5d5f43eab..fdfefa91cc 100644
--- a/tests/intel/xe_exec_reset.c
+++ b/tests/intel/xe_exec_reset.c
@@ -628,7 +628,7 @@ static void submit_jobs(struct gt_thread_data *t)
.engine_instance = 0,
.gt_id = 0,
};
- struct drm_xe_exec exec;
+ struct drm_xe_exec exec = {};
int ret;
/* GuC IDs can get exhausted */
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-14 21:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 21:39 [PATCH] tests/intel/xe_exec_reset: Explicitly declare exec Jonathan Cavitt
2024-10-14 21:45 ` Dixit, Ashutosh
2024-10-14 21:50 ` Cavitt, Jonathan
-- strict thread matches above, loose matches on Subject: below --
2024-10-14 21:31 Jonathan Cavitt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox