From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: <igt-dev@lists.freedesktop.org>,
Jakub Kolakowski <jakub1.kolakowski@intel.com>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: Re: [PATCH i-g-t] tests/xe_oa: Skip when no OA units available
Date: Fri, 21 Feb 2025 09:08:18 -0800 [thread overview]
Message-ID: <85ldtzns3h.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250220130105.756157-1-marcin.bernatowicz@linux.intel.com>
On Thu, 20 Feb 2025 05:01:05 -0800, Marcin Bernatowicz wrote:
>
> Add a check to ensure at least one OA unit is available before
> proceeding with the tests. This prevents unnecessary failures on
> devices that do not support OA units.
Are we seeing this anywhere?
In any case:
Acked-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> tests/intel/xe_oa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 0242fd594..6abf44128 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -4852,6 +4852,7 @@ igt_main
>
> /* See xe_query_oa_units_new() */
> igt_require(xe_dev->oa_units);
> + igt_require(xe_dev->oa_units->num_oa_units);
> oau = nth_oa_unit(drm_fd, 0);
>
> devid = intel_get_drm_devid(drm_fd);
> --
> 2.31.1
>
next prev parent reply other threads:[~2025-02-21 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 13:01 [PATCH i-g-t] tests/xe_oa: Skip when no OA units available Marcin Bernatowicz
2025-02-20 17:41 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-02-20 17:48 ` ✓ i915.CI.BAT: " Patchwork
2025-02-20 19:36 ` ✗ i915.CI.Full: failure " Patchwork
2025-02-21 10:59 ` ✗ Xe.CI.Full: " Patchwork
2025-02-21 17:05 ` [PATCH i-g-t] " Kamil Konieczny
2025-02-21 17:08 ` Dixit, Ashutosh [this message]
2025-02-21 19:36 ` Bernatowicz, Marcin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ldtzns3h.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=marcin.bernatowicz@linux.intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox