From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: igt-dev <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 4/9] tests/prime_mmap: use device coherent mapping instead of mmap_gtt
Date: Fri, 31 Jan 2020 22:57:29 -0800 [thread overview]
Message-ID: <871rre6bhi.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200131173109.12527-5-ramalingam.c@intel.com>
On Fri, 31 Jan 2020 09:31:04 -0800, Ramalingam C wrote:
>
> Since on new discrete GPUs we dont have the mappable aperture, if that
> is acceptable for the test purpose, we should use GEM_MMAP_OFFSET.
> Hence using gem_mmap_device_coherent() which wraps the mmap options in
> the order of gem_mmap_offset / gem_mmap / mmap_gtt
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> tests/prime_mmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/prime_mmap.c b/tests/prime_mmap.c
> index fc985784407b..1433424109c8 100644
> --- a/tests/prime_mmap.c
> +++ b/tests/prime_mmap.c
> @@ -85,8 +85,8 @@ test_correct(void)
> dma_buf_fd = prime_handle_to_fd(fd, handle);
> igt_assert(errno == 0);
>
> - /* Check correctness vs GEM_MMAP_GTT */
> - ptr1 = gem_mmap__gtt(fd, handle, BO_SIZE, PROT_READ);
> + /* Check correctness vs GEM_MMAP */
> + ptr1 = gem_mmap__device_coherent(fd, handle, 0, BO_SIZE, PROT_READ);
Once again, does this test pass with gtt mapping but fail with wc mapping?
I thought gtt mapping also bypasses the cache like wc? What about prime
mmap's? Can someone please confirm? Otherwise I will try to look.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-01 6:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 17:31 [igt-dev] [PATCH i-g-t 0/9] Handling mmap_gtt Ramalingam C
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 1/9] tests/prime_vgem: Skip fence and gtt specific tests Ramalingam C
2020-02-01 5:42 ` Dixit, Ashutosh
2020-02-03 9:19 ` Janusz Krzysztofik
2020-02-03 9:28 ` Janusz Krzysztofik
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported Ramalingam C
2020-02-01 5:55 ` Dixit, Ashutosh
2020-02-04 5:55 ` Dixit, Ashutosh
2020-02-04 6:00 ` Ramalingam C
2020-02-04 6:15 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 3/9] tests/prime_mmap_coherency: use device coherent mapping instead of mmap_gtt Ramalingam C
2020-02-01 6:27 ` Dixit, Ashutosh
2020-02-02 18:24 ` Ramalingam C
2020-02-04 6:14 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 4/9] tests/prime_mmap: " Ramalingam C
2020-02-01 6:57 ` Dixit, Ashutosh [this message]
2020-02-02 18:28 ` Ramalingam C
2020-02-04 6:29 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 5/9] tests/kms_psr: Skip tests on mmap_gtt, if no mappable aperture Ramalingam C
2020-02-04 6:38 ` Dixit, Ashutosh
2020-02-09 0:41 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 6/9] tests/kms_available_modes_crc: Skip test if mappable aperture not supported Ramalingam C
2020-02-04 6:49 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 7/9] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt Ramalingam C
2020-02-05 0:16 ` Dixit, Ashutosh
2020-02-07 12:59 ` Ramalingam C
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 8/9] tests/i915_suspend: skip fence related tests, if no mmap_gtt Ramalingam C
2020-02-05 2:06 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 9/9] tests/gem_tiling_max_stride: Skip if set tiling is not supported Ramalingam C
2020-02-05 0:43 ` Antonio Argenziano
2020-02-05 1:29 ` Dixit, Ashutosh
2020-01-31 18:45 ` [igt-dev] ✓ Fi.CI.BAT: success for Handling mmap_gtt Patchwork
2020-02-04 12:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rre6bhi.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox