From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: igt-dev <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 8/9] tests/i915_suspend: skip fence related tests, if no mmap_gtt
Date: Tue, 04 Feb 2020 18:06:42 -0800 [thread overview]
Message-ID: <87wo91lrd9.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200131173109.12527-9-ramalingam.c@intel.com>
On Fri, 31 Jan 2020 09:31:08 -0800, Ramalingam C wrote:
>
> When mappable aperture is not available, skip the fencing related tests.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> tests/i915/i915_suspend.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c
> index 5a2ec76699d6..47e134b12086 100644
> --- a/tests/i915/i915_suspend.c
> +++ b/tests/i915/i915_suspend.c
> @@ -208,11 +208,15 @@ igt_main
> igt_fixture
> fd = drm_open_driver(DRIVER_INTEL);
>
> - igt_subtest("fence-restore-tiled2untiled")
> + igt_subtest("fence-restore-tiled2untiled") {
> + gem_require_mappable_ggtt(fd);
> test_fence_restore(fd, true, false);
> + }
>
> - igt_subtest("fence-restore-untiled")
> + igt_subtest("fence-restore-untiled") {
> + gem_require_mappable_ggtt(fd);
> test_fence_restore(fd, false, false);
> + }
>
> igt_subtest("debugfs-reader")
> test_debugfs_reader(fd, false);
> @@ -226,11 +230,15 @@ igt_main
> igt_subtest("forcewake")
> test_forcewake(fd, false);
>
> - igt_subtest("fence-restore-tiled2untiled-hibernate")
> + igt_subtest("fence-restore-tiled2untiled-hibernate") {
> + gem_require_mappable_ggtt(fd);
> test_fence_restore(fd, true, true);
> + }
>
> - igt_subtest("fence-restore-untiled-hibernate")
> + igt_subtest("fence-restore-untiled-hibernate") {
> + gem_require_mappable_ggtt(fd);
> test_fence_restore(fd, false, true);
> + }
Afaict test_fence_restore() is intimately related with gtt and tiling. So
skipping makes sense:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-05 2:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 17:31 [igt-dev] [PATCH i-g-t 0/9] Handling mmap_gtt Ramalingam C
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 1/9] tests/prime_vgem: Skip fence and gtt specific tests Ramalingam C
2020-02-01 5:42 ` Dixit, Ashutosh
2020-02-03 9:19 ` Janusz Krzysztofik
2020-02-03 9:28 ` Janusz Krzysztofik
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 2/9] tests/intel_dp_compliance: Skip tests as tiling is not supported Ramalingam C
2020-02-01 5:55 ` Dixit, Ashutosh
2020-02-04 5:55 ` Dixit, Ashutosh
2020-02-04 6:00 ` Ramalingam C
2020-02-04 6:15 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 3/9] tests/prime_mmap_coherency: use device coherent mapping instead of mmap_gtt Ramalingam C
2020-02-01 6:27 ` Dixit, Ashutosh
2020-02-02 18:24 ` Ramalingam C
2020-02-04 6:14 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 4/9] tests/prime_mmap: " Ramalingam C
2020-02-01 6:57 ` Dixit, Ashutosh
2020-02-02 18:28 ` Ramalingam C
2020-02-04 6:29 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 5/9] tests/kms_psr: Skip tests on mmap_gtt, if no mappable aperture Ramalingam C
2020-02-04 6:38 ` Dixit, Ashutosh
2020-02-09 0:41 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 6/9] tests/kms_available_modes_crc: Skip test if mappable aperture not supported Ramalingam C
2020-02-04 6:49 ` Dixit, Ashutosh
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 7/9] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt Ramalingam C
2020-02-05 0:16 ` Dixit, Ashutosh
2020-02-07 12:59 ` Ramalingam C
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 8/9] tests/i915_suspend: skip fence related tests, if no mmap_gtt Ramalingam C
2020-02-05 2:06 ` Dixit, Ashutosh [this message]
2020-01-31 17:31 ` [igt-dev] [PATCH i-g-t 9/9] tests/gem_tiling_max_stride: Skip if set tiling is not supported Ramalingam C
2020-02-05 0:43 ` Antonio Argenziano
2020-02-05 1:29 ` Dixit, Ashutosh
2020-01-31 18:45 ` [igt-dev] ✓ Fi.CI.BAT: success for Handling mmap_gtt Patchwork
2020-02-04 12:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo91lrd9.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox