From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 2/2] lib/intel_device_info: use dedicated macro for struct pci_id_match init
Date: Tue, 03 Sep 2024 13:55:38 -0700 [thread overview]
Message-ID: <8734mgzcc5.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20240902134907.2186238-2-jani.nikula@intel.com>
On Mon, 02 Sep 2024 06:49:07 -0700, Jani Nikula wrote:
>
> Now that we can pass our own macros to the INTEL_*_IDS() and XE_*_IDS()
> macros, define a new macro INTEL_PCI_ID_INIT() for struct pci_id_match
> initialization with designated initializers.
>
> INTEL_VGA_DEVICE() is aimed at initializing kernel struct pci_device_id,
> and it's mostly just a coincidence that it can be used to initialize
> struct pci_id_match. Indeed, the member names are different, and the IGT
> usage has prevented the kernel from switching to designated
> initializers.
OK, understand what you mean since INTEL_VGA_DEVICE comes from kernel
headers. So this is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2024-09-03 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 13:49 [PATCH i-g-t 1/2] lib/xe/oa: simplify device id array initialization Jani Nikula
2024-09-02 13:49 ` [PATCH i-g-t 2/2] lib/intel_device_info: use dedicated macro for struct pci_id_match init Jani Nikula
2024-09-03 20:55 ` Dixit, Ashutosh [this message]
2024-09-02 19:15 ` ✓ CI.xeBAT: success for series starting with [i-g-t,1/2] lib/xe/oa: simplify device id array initialization Patchwork
2024-09-02 19:34 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-09-03 0:53 ` ✗ CI.xeFULL: " Patchwork
2024-09-03 20:50 ` [PATCH i-g-t 1/2] " Dixit, Ashutosh
2024-09-04 10:23 ` Jani Nikula
2024-09-04 8:29 ` ✓ CI.xeBAT: success for series starting with [i-g-t,1/2] lib/xe/oa: simplify device id array initialization (rev2) Patchwork
2024-09-04 8:36 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-04 10:09 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-05 8:52 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734mgzcc5.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox