From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com,
Chris Wilson <chris.p.wilson@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 3/3] i915_pm_rpm: rpm resume by user forcewake
Date: Tue, 03 May 2022 21:32:53 -0700 [thread overview]
Message-ID: <8735hprk7e.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <874k26qac3.wl-ashutosh.dixit@intel.com>
On Tue, 03 May 2022 19:51:24 -0700, Dixit, Ashutosh wrote:
>
> > Change function name to disable_all_screens_and_clr_forcewake_and_wait()
> > (s/or/and/) since we are doing both?
>
> Or we could do this:
>
> if (data->fw_fd)
> clear_forcewake(data);
>
> Basically, I think either make both enable and disable functions
> unconditional, or set/clear forcewake in both only for headless (and name
> the functions appropriately).
I think the code will be clearer if we do in only for headless (as is in
the patch) but we could just make the above change in the disable function.
next prev parent reply other threads:[~2022-05-04 4:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 17:02 [igt-dev] [PATCH i-g-t 0/3] RPM Test on HEADLESS Anshuman Gupta
2022-04-21 17:02 ` [igt-dev] [PATCH i-g-t 1/3] test: i915_pm_rpm: init devid in setup_envirnoment Anshuman Gupta
2022-04-21 23:26 ` Dixit, Ashutosh
2022-04-21 17:02 ` [igt-dev] [PATCH i-g-t 2/3] test: i915_pm_rpm: conditional initialization of igt_display_t Anshuman Gupta
2022-04-21 23:29 ` Dixit, Ashutosh
2022-04-22 4:30 ` Gupta, Anshuman
2022-05-03 21:17 ` Dixit, Ashutosh
2022-04-21 17:02 ` [igt-dev] [PATCH i-g-t 3/3] i915_pm_rpm: rpm resume by user forcewake Anshuman Gupta
2022-05-04 1:16 ` Dixit, Ashutosh
2022-05-04 2:51 ` Dixit, Ashutosh
2022-05-04 4:32 ` Dixit, Ashutosh [this message]
2022-05-11 8:03 ` Gupta, Anshuman
2022-04-21 18:00 ` [igt-dev] ✗ GitLab.Pipeline: warning for RPM Test on HEADLESS Patchwork
2022-04-21 18:25 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-04-21 22:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735hprk7e.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=chris.p.wilson@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox