public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tools/intel_reg: fix use-after-free bug in register spec read
@ 2019-08-21 13:09 Jani Nikula
  2019-08-21 13:40 ` Ser, Simon
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2019-08-21 13:09 UTC (permalink / raw)
  To: igt-dev; +Cc: jani.nikula

e points into the buffer pointer to by p.

Fixes: dfda0b6aecce ("intel_reg: introduce one intel_reg tool to rule them all")
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 tools/intel_reg_spec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/intel_reg_spec.c b/tools/intel_reg_spec.c
index 0df69b6884de..5ab56ec1a31f 100644
--- a/tools/intel_reg_spec.c
+++ b/tools/intel_reg_spec.c
@@ -233,9 +233,9 @@ static int parse_line(struct reg *reg, const char *line)
 			reg->name = p;
 		} else if (i == 2) {
 			reg->addr = strtoul(p, &e, 16);
-			free(p);
 			if (*e)
 				ret = -1;
+			free(p);
 		} else if (i == 3) {
 			ret = parse_port_desc(reg, p);
 			free(p);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-08-22  7:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-21 13:09 [igt-dev] [PATCH i-g-t] tools/intel_reg: fix use-after-free bug in register spec read Jani Nikula
2019-08-21 13:40 ` Ser, Simon
2019-08-22  7:33   ` Jani Nikula
2019-08-21 13:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-08-22  1:23 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox