From: Javier Martinez Canillas <javierm@redhat.com>
To: Albert Esteve <aesteve@redhat.com>
Cc: igt-dev@lists.freedesktop.org, belmouss@redhat.com
Subject: Re: [igt-dev] [PATCH 3/3] kms_cursor_legacy: modeset-atomic-cursor-hotspot
Date: Wed, 26 Jul 2023 16:53:43 +0200 [thread overview]
Message-ID: <874jlq4tc8.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <CADSE00L4H_fAEXizdyoPZJLztr7b3dBZoiXECRnUpLcevR+Dzw@mail.gmail.com>
Albert Esteve <aesteve@redhat.com> writes:
> On Tue, Jul 25, 2023 at 4:26 PM Javier Martinez Canillas <javierm@redhat.com>
> wrote:
>
[...]
>> Also, there's
>> https://docs.kernel.org/gpu/drm-uapi.html#c.DRM_CAP_CURSOR_WIDTH
>> and DRM_CAP_CURSOR_HEIGHT to query the hardware cursor size. Maybe you
>> should
>> use that instead of assume a 64x64 cursor size ?
>>
>
> In many other tests in the same file the size of the cursor is hardcoded to
> 64, same as here.
> So I kept it consistent.
> Could be a nice refactor, but I guess it is outside the scope of this patch.
>
Ah, didn't look at the rest of the file but yes, agreed that is better to
keep it consistent and in any case the whole file could be cleaned up in
a separate patch.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-07-26 14:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:04 [igt-dev] [PATCH 0/3] Add atomic DRM cursor hotspot test Albert Esteve
2023-07-21 13:04 ` [igt-dev] [PATCH 1/3] drm header update: temp commit Albert Esteve
2023-07-28 7:41 ` Zbigniew Kempczyński
2023-07-28 7:57 ` Albert Esteve
2023-07-28 8:31 ` Zbigniew Kempczyński
2023-07-21 13:04 ` [igt-dev] [PATCH 2/3] igt_kms: add hotspot plane property Albert Esteve
2023-07-25 13:40 ` Javier Martinez Canillas
2023-07-26 14:42 ` Albert Esteve
2023-07-21 13:04 ` [igt-dev] [PATCH 3/3] kms_cursor_legacy: modeset-atomic-cursor-hotspot Albert Esteve
2023-07-25 14:26 ` Javier Martinez Canillas
2023-07-26 14:50 ` Albert Esteve
2023-07-26 14:53 ` Javier Martinez Canillas [this message]
2023-07-24 12:22 ` [igt-dev] ✓ Fi.CI.BAT: success for Add atomic DRM cursor hotspot test Patchwork
2023-07-24 17:02 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-25 15:51 ` [igt-dev] [PATCH 0/3] " Kamil Konieczny
2023-07-26 14:52 ` Albert Esteve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jlq4tc8.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=aesteve@redhat.com \
--cc=belmouss@redhat.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox