From: Javier Martinez Canillas <javierm@redhat.com>
To: Albert Esteve <aesteve@redhat.com>, igt-dev@lists.freedesktop.org
Cc: belmouss@redhat.com
Subject: Re: [igt-dev] [PATCH 2/3] igt_kms: add hotspot plane property
Date: Tue, 25 Jul 2023 15:40:29 +0200 [thread overview]
Message-ID: <87fs5cjeia.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20230721130458.64856-3-aesteve@redhat.com>
Hello Albert,
Patch looks good to me. But I'm not really familiar with the IGT codebase.
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
I've one question below though:
Albert Esteve <aesteve@redhat.com> writes:
[...]
> @@ -2679,6 +2686,8 @@ void igt_display_require(igt_display_t *display, int drm_fd)
> drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> if (drmSetClientCap(drm_fd, DRM_CLIENT_CAP_ATOMIC, 1) == 0)
> display->is_atomic = 1;
> +
> + drmSetClientCap(drm_fd, DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT, 1);
>
Should this capability be set unconditionally?
Do we want to also test the case when user-space doesn't opt-in and does
not know how to handle the hostpost properties ?
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-07-25 13:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 13:04 [igt-dev] [PATCH 0/3] Add atomic DRM cursor hotspot test Albert Esteve
2023-07-21 13:04 ` [igt-dev] [PATCH 1/3] drm header update: temp commit Albert Esteve
2023-07-28 7:41 ` Zbigniew Kempczyński
2023-07-28 7:57 ` Albert Esteve
2023-07-28 8:31 ` Zbigniew Kempczyński
2023-07-21 13:04 ` [igt-dev] [PATCH 2/3] igt_kms: add hotspot plane property Albert Esteve
2023-07-25 13:40 ` Javier Martinez Canillas [this message]
2023-07-26 14:42 ` Albert Esteve
2023-07-21 13:04 ` [igt-dev] [PATCH 3/3] kms_cursor_legacy: modeset-atomic-cursor-hotspot Albert Esteve
2023-07-25 14:26 ` Javier Martinez Canillas
2023-07-26 14:50 ` Albert Esteve
2023-07-26 14:53 ` Javier Martinez Canillas
2023-07-24 12:22 ` [igt-dev] ✓ Fi.CI.BAT: success for Add atomic DRM cursor hotspot test Patchwork
2023-07-24 17:02 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-25 15:51 ` [igt-dev] [PATCH 0/3] " Kamil Konieczny
2023-07-26 14:52 ` Albert Esteve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs5cjeia.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=aesteve@redhat.com \
--cc=belmouss@redhat.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox