Re: [igt-dev] [PATCH i-g-t v2] i915_pm_rpm: Use __igt_debugfs_dump for i915_runtime_pm_status

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 23 Feb 2022 08:53:14 -0800, Anshuman Gupta wrote:
>
> Use __igt_debugfs_dump() in wait_for_suspended() in order to
> specify explicit igt log level.
> We need to dump the i915_runtime_pm_status even in case of igt
> test's skips while setting up envirnment as well,
> that requires log level to be IGT_LOG_INFO.
>
> v2:
> - Add a comment "Dump status even if the test skips" before
>   __igt_debugfs_dump(). [Ashutosh]

Thanks!

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_rpm.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 6c8ffbd5d..1df0ed222 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -206,8 +206,10 @@ static bool wait_for_suspended(void)
>	} else {
>		bool suspended = igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
>
> -		if (!suspended)
> -			igt_debugfs_dump(drm_fd, "i915_runtime_pm_status");
> +		if (!suspended) {
> +			/* Dump runtime pm status even if test skips */
> +			__igt_debugfs_dump(drm_fd, "i915_runtime_pm_status", IGT_LOG_INFO);
> +		}
>
>		return suspended;
>	}
> --
> 2.26.2
>