Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org, petri.latvala@intel.com,
	badal.nilawar@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] i915_pm_rpm: Use __igt_debugfs_dump for i915_runtime_pm_status
Date: Wed, 23 Feb 2022 07:57:49 -0800	[thread overview]
Message-ID: <87tucp60ea.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220223095951.12430-1-anshuman.gupta@intel.com>

On Wed, 23 Feb 2022 01:59:51 -0800, Anshuman Gupta wrote:
>
> Use __igt_debugfs_dump() in wait_for_suspended() in order to
> specify explicit igt log level.
> We need to dump the i915_runtime_pm_status even in case of igt
> test's skips as well, that requires log level to be IGT_LOG_INFO.

Ok, by skip I believe you are referring to this:

	igt_require(setup_environment(false));

Therefore:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 6c8ffbd5d..eb4c4f4e3 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -207,7 +207,7 @@ static bool wait_for_suspended(void)
>		bool suspended = igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED);
>
>		if (!suspended)
> -			igt_debugfs_dump(drm_fd, "i915_runtime_pm_status");
> +			__igt_debugfs_dump(drm_fd, "i915_runtime_pm_status", IGT_LOG_INFO);
>
>		return suspended;
>	}
> --
> 2.26.2
>

  parent reply	other threads:[~2022-02-23 15:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23  9:59 [igt-dev] [PATCH i-g-t] i915_pm_rpm: Use __igt_debugfs_dump for i915_runtime_pm_status Anshuman Gupta
2022-02-23 11:38 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-02-23 15:57 ` Dixit, Ashutosh [this message]
2022-02-23 16:08   ` [igt-dev] [PATCH i-g-t] " Gupta, Anshuman
2022-02-23 16:31     ` Dixit, Ashutosh
2022-02-23 16:53 ` [igt-dev] [PATCH i-g-t v2] " Anshuman Gupta
2022-02-23 16:54   ` Dixit, Ashutosh
2022-02-23 18:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for i915_pm_rpm: Use __igt_debugfs_dump for i915_runtime_pm_status (rev2) Patchwork
2022-02-23 21:22 ` [igt-dev] ✓ Fi.CI.IGT: success for i915_pm_rpm: Use __igt_debugfs_dump for i915_runtime_pm_status Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tucp60ea.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox