From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Jasmine Newsome <jasmine.newsome@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner
Date: Tue, 22 Feb 2022 11:49:17 -0800 [thread overview]
Message-ID: <874k4q7kci.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220219013215.3531766-2-jasmine.newsome@intel.com>
On Fri, 18 Feb 2022 17:32:14 -0800, Jasmine Newsome wrote:
>
> Save igt_spin_factory info in igt_spin. This will allow
> for access to the actual context within the spinner.
> Previously, only the context id was accessible.
Not sure about the sentence above, not seeing context id as part of
igt_spin_t. Maybe just drop this sentence.
> This might help make spinner code cleaner.
Maybe we can just say something like: Save the opts with which the spin was
created as part of the spin so that the opts are available in case they are
needed. Something like that.
The patch itself is fine, just the commit message needs a tweak. Thanks.
next prev parent reply other threads:[~2022-02-22 19:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 1:32 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner Jasmine Newsome
2022-02-22 19:49 ` Dixit, Ashutosh [this message]
2022-02-19 1:32 ` [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_spin_batch: Removing context persistence Jasmine Newsome
2022-02-19 2:39 ` Dixit, Ashutosh
2022-02-21 11:54 ` Tvrtko Ursulin
2022-02-23 15:34 ` Newsome, Jasmine
2022-02-19 2:47 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix for gem_spin_batch (rev3) Patchwork
2022-02-19 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-02-24 0:42 [igt-dev] [PATCH i-g-t 0/2] Fix for gem_spin_batch Jasmine Newsome
2022-02-24 0:42 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner Jasmine Newsome
2022-02-24 2:46 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k4q7kci.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jasmine.newsome@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox