Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] i915: Skip two subsets when pread/pwrite are unavailable
@ 2021-03-26  4:33 Ashutosh Dixit
  2021-03-26  5:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Ashutosh Dixit @ 2021-03-26  4:33 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala

The pread/pwrite replacement implemented in
ad5eb02eb3f1 ("lib/ioctl_wrappers: Keep IGT working without pread/pwrite
ioctls") uses gem_set_domain which pins all pages which have to be
read/written. When the read/write size is large this causes gem_set_domain
to return -ENOMEM with a trace such as:

ioctl_wrappers-CRITICAL: Test assertion failure function gem_set_domain, file ../lib/ioctl_wrappers.c:563:
ioctl_wrappers-CRITICAL: Failed assertion: __gem_set_domain(fd, handle, read, write) == 0
ioctl_wrappers-CRITICAL: Last errno: 12, Cannot allocate memory
ioctl_wrappers-CRITICAL: error: -12 != 0
igt_core-INFO: Stack trace:
igt_core-INFO:   #0 ../lib/igt_core.c:1746 __igt_fail_assert()
igt_core-INFO:   #1 [gem_set_domain+0x44]
igt_core-INFO:   #2 ../lib/ioctl_wrappers.c:367 gem_write()
igt_core-INFO:   #3 ../tests/prime_mmap.c:67 test_aperture_limit()
igt_core-INFO:   #4 ../tests/prime_mmap.c:578 __real_main530()
igt_core-INFO:   #5 ../tests/prime_mmap.c:530 main()

Skip these tests when pread/pwrite are unavailable because they cannot pass
with the pread/pwrite replacement.

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/i915/gem_exec_params.c | 2 ++
 tests/prime_mmap.c           | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c
index 6840cf40ce..a7bcd39d32 100644
--- a/tests/i915/gem_exec_params.c
+++ b/tests/i915/gem_exec_params.c
@@ -314,6 +314,8 @@ static void test_larger_than_life_batch(int fd)
 	 */
 	igt_require(size < gem_aperture_size(fd));
 	intel_require_memory(2, size, CHECK_RAM); /* batch + shadow */
+	/* Prevent gem_set_domain -ENOMEM failures */
+	gem_require_pread_pwrite(fd);
 
 	__for_each_physical_engine(fd, e) {
 		/* Keep the batch_len implicit [0] */
diff --git a/tests/prime_mmap.c b/tests/prime_mmap.c
index cdf2d51497..af313917da 100644
--- a/tests/prime_mmap.c
+++ b/tests/prime_mmap.c
@@ -451,6 +451,8 @@ test_aperture_limit(void)
 	uint64_t size1 = (gem_mappable_aperture_size(fd) * 7) / 8;
 	uint64_t size2 = (gem_mappable_aperture_size(fd) * 3) / 8;
 
+	/* Prevent gem_set_domain -ENOMEM failures */
+	gem_require_pread_pwrite(fd);
 	handle1 = gem_create(fd, size1);
 	fill_bo(handle1, BO_SIZE);
 
-- 
2.29.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-26 10:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-26  4:33 [igt-dev] [PATCH i-g-t] i915: Skip two subsets when pread/pwrite are unavailable Ashutosh Dixit
2021-03-26  5:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2021-03-26  5:34   ` Dixit, Ashutosh
2021-03-26  6:29     ` Vudum, Lakshminarayana
2021-03-26  6:19 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2021-03-26  6:58 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
2021-03-26  7:23   ` Dixit, Ashutosh
2021-03-26 10:41 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox