From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
Date: Fri, 30 Oct 2020 16:06:29 -0700 [thread overview]
Message-ID: <875z6rz53e.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20201030225548.7444-1-umesh.nerlige.ramappa@intel.com>
On Fri, 30 Oct 2020 15:55:48 -0700, Umesh Nerlige Ramappa wrote:
> @@ -4806,6 +4807,13 @@ igt_main
> igt_fixture {
> struct stat sb;
>
> + /*
> + * Prior tests may have unloaded i915 or failed while
> + * loading/unloading i915. Load i915 here before we stat the
> + * files.
> + */
> + igt_i915_driver_load(NULL);
> +
I was thinking that the original if () was also ok because there will be an
additional igt_debug() if the module is already loaded and the if will
avoid that. Anyway you decide what to do, either way:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-10-30 23:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 22:55 [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Umesh Nerlige Ramappa
2020-10-30 23:06 ` Dixit, Ashutosh [this message]
2020-10-30 23:58 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf: Make sure i915 is loaded before reading proc (rev2) Patchwork
2020-10-31 2:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-11-02 9:48 ` [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Petri Latvala
-- strict thread matches above, loose matches on Subject: below --
2020-11-02 19:49 Umesh Nerlige Ramappa
2020-11-03 8:06 ` Petri Latvala
2020-11-04 0:15 ` Umesh Nerlige Ramappa
2020-11-04 10:35 ` Petri Latvala
2020-10-30 0:39 Umesh Nerlige Ramappa
2020-10-30 10:16 ` Petri Latvala
2020-10-30 22:39 ` Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z6rz53e.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox