From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
Date: Wed, 20 Mar 2019 16:54:51 +0200 [thread overview]
Message-ID: <875zsd1tqc.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190319192320.10526-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Don't try to evaluate whether reads executed on an absent ring do
> anything.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> tests/i915/gem_mocs_settings.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 21f7c6e12..1a311b8c0 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -564,8 +564,8 @@ igt_main
> }
> }
>
> - igt_subtest_f("mocs-isolation-%s",
> - e->name) {
> + igt_subtest_f("mocs-isolation-%s", e->name) {
> + gem_require_ring(fd, e->exec_id | e->flags);
> gem_require_contexts(fd);
>
> isolation_test(fd, e->exec_id | e->flags);
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-20 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 19:23 [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings Chris Wilson
2019-03-19 20:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-20 7:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-20 14:54 ` Mika Kuoppala [this message]
2019-03-20 16:40 ` [igt-dev] [PATCH i-g-t] " Kumar Valsan, Prathap
2019-03-20 16:35 ` Chris Wilson
2019-03-20 16:59 ` Kumar Valsan, Prathap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zsd1tqc.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox