From: "Kumar Valsan, Prathap" <prathap.kumar.valsan@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
Date: Wed, 20 Mar 2019 12:59:22 -0400 [thread overview]
Message-ID: <20190320165922.GG30702@intel.com> (raw)
In-Reply-To: <155309975207.15790.7075400941662429787@skylake-alporthouse-com>
On Wed, Mar 20, 2019 at 04:35:52PM +0000, Chris Wilson wrote:
> Quoting Kumar Valsan, Prathap (2019-03-20 16:40:50)
> > On Tue, Mar 19, 2019 at 07:23:20PM +0000, Chris Wilson wrote:
> > > Don't try to evaluate whether reads executed on an absent ring do
> > > anything.
> >
> > Chris,
> >
> > I am trying to understand this patch and has this question.
> > AFAIK every GPU engine has an assosiated ring buffer per
> > context. Absent ring is a error case?
>
> Not all HW has the same set of engines available. And we should get a
> failure from gem_execbuf() if you try to dispatch something on a ring
> that didn't exist. What I haven't actually answered is why we actually
> hit a failure later. But it's definitely a requirement of the test that
> the engine exist.
> -Chris
I get it now. Thank you.
-Prathap
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-03-20 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 19:23 [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings Chris Wilson
2019-03-19 20:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-20 7:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-20 14:54 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Mika Kuoppala
2019-03-20 16:40 ` Kumar Valsan, Prathap
2019-03-20 16:35 ` Chris Wilson
2019-03-20 16:59 ` Kumar Valsan, Prathap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320165922.GG30702@intel.com \
--to=prathap.kumar.valsan@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox