* [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
@ 2019-03-19 19:23 Chris Wilson
2019-03-19 20:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Chris Wilson @ 2019-03-19 19:23 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Don't try to evaluate whether reads executed on an absent ring do
anything.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_mocs_settings.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
index 21f7c6e12..1a311b8c0 100644
--- a/tests/i915/gem_mocs_settings.c
+++ b/tests/i915/gem_mocs_settings.c
@@ -564,8 +564,8 @@ igt_main
}
}
- igt_subtest_f("mocs-isolation-%s",
- e->name) {
+ igt_subtest_f("mocs-isolation-%s", e->name) {
+ gem_require_ring(fd, e->exec_id | e->flags);
gem_require_contexts(fd);
isolation_test(fd, e->exec_id | e->flags);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
2019-03-19 19:23 [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings Chris Wilson
@ 2019-03-19 20:03 ` Patchwork
2019-03-20 7:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-03-19 20:03 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
URL : https://patchwork.freedesktop.org/series/58201/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5774 -> IGTPW_2662
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58201/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2662 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17
* igt@gem_ctx_create@basic-files:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] +106
* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +57
* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_contexts:
- fi-icl-u3: NOTRUN -> DMESG-FAIL [fdo#108569]
* igt@kms_addfb_basic@addfb25-y-tiled-small:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +56
* igt@kms_busy@basic-flip-c:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8
* igt@kms_force_connector_basic@force-load-detect:
- fi-bxt-j4205: NOTRUN -> SKIP [fdo#109271] +47
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> FAIL [fdo#103167]
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#107362]
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
Participating hosts (41 -> 42)
------------------------------
Additional (6): fi-bxt-j4205 fi-gdg-551 fi-icl-u3 fi-skl-lmem fi-byt-n2820 fi-byt-clapper
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4890 -> IGTPW_2662
CI_DRM_5774: eb58badf383e72d54ba48b8570ce7169c1419f6a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2662: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2662/
IGT_4890: 6d4d6949a099521003de252358601d22115e27ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2662/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
2019-03-19 19:23 [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings Chris Wilson
2019-03-19 20:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-20 7:01 ` Patchwork
2019-03-20 14:54 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Mika Kuoppala
2019-03-20 16:40 ` Kumar Valsan, Prathap
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-03-20 7:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
URL : https://patchwork.freedesktop.org/series/58201/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5774_full -> IGTPW_2662_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58201/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2662_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_plane@pixel-format-pipe-a-planes-source-clamping}:
- shard-apl: PASS -> FAIL
Known issues
------------
Here are the changes found in IGTPW_2662_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-apl: PASS -> INCOMPLETE [fdo#103927] +1
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: PASS -> SKIP [fdo#109271]
- shard-hsw: PASS -> FAIL [fdo#108686]
- shard-kbl: PASS -> SKIP [fdo#109271]
- shard-apl: PASS -> SKIP [fdo#109271]
* igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_busy@basic-modeset-d:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956] +1
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-snb: PASS -> DMESG-WARN [fdo#107956]
- shard-hsw: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> FAIL [fdo#108597] / [fdo#108739]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +3
- shard-apl: PASS -> FAIL [fdo#103232] +3
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-apl: PASS -> FAIL [fdo#103167] +3
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +11
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-pwrite:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +59
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +21
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: NOTRUN -> FAIL [fdo#109016]
* igt@kms_setmode@basic:
- shard-glk: PASS -> FAIL [fdo#99912]
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-kbl: PASS -> FAIL [fdo#104894]
#### Possible fixes ####
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS +1
- shard-snb: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS +1
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: FAIL [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: FAIL [fdo#105767] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: FAIL [fdo#103355] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-kbl: FAIL [fdo#103167] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-glk: FAIL [fdo#103167] -> PASS +6
* {igt@kms_plane@pixel-format-pipe-b-planes}:
- shard-glk: SKIP [fdo#109271] -> PASS
* {igt@kms_plane_multiple@atomic-pipe-b-tiling-none}:
- shard-apl: FAIL [fdo#110037] -> PASS +1
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS +2
#### Warnings ####
* igt@i915_missed_irq:
- shard-hsw: SKIP [fdo#109271] -> INCOMPLETE [fdo#103540]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 5)
------------------------------
Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u
Build changes
-------------
* IGT: IGT_4890 -> IGTPW_2662
* Piglit: piglit_4509 -> None
CI_DRM_5774: eb58badf383e72d54ba48b8570ce7169c1419f6a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2662: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2662/
IGT_4890: 6d4d6949a099521003de252358601d22115e27ef @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2662/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
2019-03-19 19:23 [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings Chris Wilson
2019-03-19 20:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-20 7:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-20 14:54 ` Mika Kuoppala
2019-03-20 16:40 ` Kumar Valsan, Prathap
3 siblings, 0 replies; 7+ messages in thread
From: Mika Kuoppala @ 2019-03-20 14:54 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Don't try to evaluate whether reads executed on an absent ring do
> anything.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> tests/i915/gem_mocs_settings.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 21f7c6e12..1a311b8c0 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -564,8 +564,8 @@ igt_main
> }
> }
>
> - igt_subtest_f("mocs-isolation-%s",
> - e->name) {
> + igt_subtest_f("mocs-isolation-%s", e->name) {
> + gem_require_ring(fd, e->exec_id | e->flags);
> gem_require_contexts(fd);
>
> isolation_test(fd, e->exec_id | e->flags);
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
2019-03-19 19:23 [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings Chris Wilson
` (2 preceding siblings ...)
2019-03-20 14:54 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Mika Kuoppala
@ 2019-03-20 16:40 ` Kumar Valsan, Prathap
2019-03-20 16:35 ` Chris Wilson
3 siblings, 1 reply; 7+ messages in thread
From: Kumar Valsan, Prathap @ 2019-03-20 16:40 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Tue, Mar 19, 2019 at 07:23:20PM +0000, Chris Wilson wrote:
> Don't try to evaluate whether reads executed on an absent ring do
> anything.
Chris,
I am trying to understand this patch and has this question.
AFAIK every GPU engine has an assosiated ring buffer per
context. Absent ring is a error case?
Thanks,
Prathap
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_mocs_settings.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 21f7c6e12..1a311b8c0 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -564,8 +564,8 @@ igt_main
> }
> }
>
> - igt_subtest_f("mocs-isolation-%s",
> - e->name) {
> + igt_subtest_f("mocs-isolation-%s", e->name) {
> + gem_require_ring(fd, e->exec_id | e->flags);
> gem_require_contexts(fd);
>
> isolation_test(fd, e->exec_id | e->flags);
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
2019-03-20 16:40 ` Kumar Valsan, Prathap
@ 2019-03-20 16:35 ` Chris Wilson
2019-03-20 16:59 ` Kumar Valsan, Prathap
0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2019-03-20 16:35 UTC (permalink / raw)
To: Kumar Valsan, Prathap; +Cc: igt-dev
Quoting Kumar Valsan, Prathap (2019-03-20 16:40:50)
> On Tue, Mar 19, 2019 at 07:23:20PM +0000, Chris Wilson wrote:
> > Don't try to evaluate whether reads executed on an absent ring do
> > anything.
>
> Chris,
>
> I am trying to understand this patch and has this question.
> AFAIK every GPU engine has an assosiated ring buffer per
> context. Absent ring is a error case?
Not all HW has the same set of engines available. And we should get a
failure from gem_execbuf() if you try to dispatch something on a ring
that didn't exist. What I haven't actually answered is why we actually
hit a failure later. But it's definitely a requirement of the test that
the engine exist.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings
2019-03-20 16:35 ` Chris Wilson
@ 2019-03-20 16:59 ` Kumar Valsan, Prathap
0 siblings, 0 replies; 7+ messages in thread
From: Kumar Valsan, Prathap @ 2019-03-20 16:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Wed, Mar 20, 2019 at 04:35:52PM +0000, Chris Wilson wrote:
> Quoting Kumar Valsan, Prathap (2019-03-20 16:40:50)
> > On Tue, Mar 19, 2019 at 07:23:20PM +0000, Chris Wilson wrote:
> > > Don't try to evaluate whether reads executed on an absent ring do
> > > anything.
> >
> > Chris,
> >
> > I am trying to understand this patch and has this question.
> > AFAIK every GPU engine has an assosiated ring buffer per
> > context. Absent ring is a error case?
>
> Not all HW has the same set of engines available. And we should get a
> failure from gem_execbuf() if you try to dispatch something on a ring
> that didn't exist. What I haven't actually answered is why we actually
> hit a failure later. But it's definitely a requirement of the test that
> the engine exist.
> -Chris
I get it now. Thank you.
-Prathap
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-20 16:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-19 19:23 [igt-dev] [PATCH i-g-t] i915/gem_mocs_settings/mocs-isolation: Filter out missing rings Chris Wilson
2019-03-19 20:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-20 7:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-20 14:54 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Mika Kuoppala
2019-03-20 16:40 ` Kumar Valsan, Prathap
2019-03-20 16:35 ` Chris Wilson
2019-03-20 16:59 ` Kumar Valsan, Prathap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox