Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Lionel G Landwerlin <lionel.g.landwerlin@linux.intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t v4 27/31] lib/i915/perf: Update MTL OA timestamp and EU thread config
Date: Tue, 21 Mar 2023 22:31:59 -0700	[thread overview]
Message-ID: <877cv9uzao.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230322000523.3310187-28-umesh.nerlige.ramappa@intel.com>

On Tue, 21 Mar 2023 17:05:19 -0700, Umesh Nerlige Ramappa wrote:
>
> MTL has configuration similar to DG2 for OA timestamp and threads per
> EU. Update the same for MTL.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
>  lib/i915/perf.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/lib/i915/perf.c b/lib/i915/perf.c
> index d8624dc0..24ef3819 100644
> --- a/lib/i915/perf.c
> +++ b/lib/i915/perf.c
> @@ -432,6 +432,14 @@ intel_perf_for_devinfo(uint32_t device_id,
>		else
>			return unsupported_i915_perf_platform(perf);
>	} else if (devinfo->is_meteorlake) {
> +		perf->devinfo.eu_threads_count = 8;
> +		/* OA reports have the timestamp value shifted to the
> +		 * right by 1 bits, it also means we cannot use the
> +		 * top bit for comparison.
> +		 */
> +		perf->devinfo.oa_timestamp_shift = -1;
> +		perf->devinfo.oa_timestamp_mask = 0x7fffffff;
> +

Is it possible to add a Bspec reference for this? Otherwise:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

  reply	other threads:[~2023-03-22  5:32 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22  0:04 [igt-dev] [PATCH i-g-t v4 00/31] Enable OAM support in IGT and GPUvis Umesh Nerlige Ramappa
2023-03-22  0:04 ` [igt-dev] [PATCH i-g-t v4 01/31] i915/perf: Add support for 64-bit OA formats Umesh Nerlige Ramappa
2023-03-22  0:04 ` [igt-dev] [PATCH i-g-t v4 02/31] i915/perf: Define a default engine for OA Umesh Nerlige Ramappa
2023-03-22  0:04 ` [igt-dev] [PATCH i-g-t v4 03/31] i915/perf: Use default engine for sseu tests Umesh Nerlige Ramappa
2023-03-22 15:14   ` Dixit, Ashutosh
2023-03-22  0:04 ` [igt-dev] [PATCH i-g-t v4 04/31] i915/perf: Ensure rcs0 is present for gen12-mi-rpc Umesh Nerlige Ramappa
2023-03-22  0:04 ` [igt-dev] [PATCH i-g-t v4 05/31] i915/perf: Use ARRAY_SIZE for buffer-fill test Umesh Nerlige Ramappa
2023-03-22  0:04 ` [igt-dev] [PATCH i-g-t v4 06/31] i915/perf: Add class:instance support to OA tests Umesh Nerlige Ramappa
2023-03-22  0:04 ` [igt-dev] [PATCH i-g-t v4 07/31] i915/perf: Enable tests to run on specific engines Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 08/31] i915/perf: Treat ticks as 64 bit Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 09/31] i915/perf: Treat timestamp as 64 bit value Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 10/31] i915/perf: Add OAM format type Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 11/31] i915/perf: Move OA format array from stack to heap Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 12/31] i915/perf: Use a helper for OA format Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 13/31] i915/perf: Add support for oa perf groups Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 14/31] i915/perf: Test concurrent access to OA in different groups Umesh Nerlige Ramappa
2023-03-22 15:19   ` Dixit, Ashutosh
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 15/31] i915/perf: Add OAM support Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 16/31] lib/i915/perf: Prepare to read different OA formats Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 17/31] lib/i915/perf: Choose OAM format for media metrics Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 18/31] lib/i915/perf: Set missing metric unit for some counters Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 19/31] lib/i915/perf: Add MTL to supported HW in OA guid registry Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 20/31] lib/i915/perf: Add support for OAM format in codegen Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 21/31] lib/i915/perf: Update MTL GT2 metrics Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 22/31] lib/i915/perf: Update MTL GT3 metrics Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 23/31] i915/perf: Add support for engine specific metrics Umesh Nerlige Ramappa
2023-03-22 15:22   ` Dixit, Ashutosh
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 24/31] i915/perf: Run non-zero-reason on media engines as well Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 25/31] i915/perf: Make sanity check failures descriptive Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 26/31] lib/i915/perf: Enable multi-tile support for perf library Umesh Nerlige Ramappa
2023-03-22  5:19   ` Dixit, Ashutosh
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 27/31] lib/i915/perf: Update MTL OA timestamp and EU thread config Umesh Nerlige Ramappa
2023-03-22  5:31   ` Dixit, Ashutosh [this message]
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 28/31] lib/i915/perf: Add support for MPEC format Umesh Nerlige Ramappa
2023-03-22 16:26   ` Dixit, Ashutosh
2023-03-22 17:10     ` Dixit, Ashutosh
2023-03-22 17:39       ` Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 29/31] lib/i915/perf: Adjust the GPU timestamp for new OA formats Umesh Nerlige Ramappa
2023-03-22  5:40   ` Dixit, Ashutosh
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 30/31] tools/perf: Choose the right card Umesh Nerlige Ramappa
2023-03-22 15:49   ` Dixit, Ashutosh
2023-03-23  0:05     ` Umesh Nerlige Ramappa
2023-03-22 17:20   ` Kamil Konieczny
2023-03-23  2:45     ` Umesh Nerlige Ramappa
2023-03-22  0:05 ` [igt-dev] [PATCH i-g-t v4 31/31] lib/i915/perf: Apply shift to raw timestamp as well Umesh Nerlige Ramappa
2023-03-22  5:43   ` Dixit, Ashutosh
2023-03-22  0:39 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable OAM support in IGT and GPUvis (rev4) Patchwork
2023-03-22  7:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cv9uzao.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@linux.intel.com \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox