From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Khajapasha, Mohammed" <mohammed.khajapasha@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 3/3] kms/test: Pass correct pipe value to print pipe name
Date: Tue, 10 Mar 2020 10:20:33 +0200 [thread overview]
Message-ID: <878sk8oc32.fsf@intel.com> (raw)
In-Reply-To: <1EBC98102E7E77409022937977AC68920C3E4633@BGSMSX110.gar.corp.intel.com>
On Tue, 10 Mar 2020, "Khajapasha, Mohammed" <mohammed.khajapasha@intel.com> wrote:
> Are you saying, we should get rid of pipe enum and make it array index
> based? Is my understanding correct? At present, every IGT subtest
> iterates over pipe list using "enum pipe" and this is getting passed
> down.
I am saying do not conflate enum pipe and crtc index.
If you call something a pipe, it should be the pipe, not crtc index. And
vice versa.
It gets really confusing really quick if you call something a pipe, and
then go on to convert it into a pipe, as if it wasn't a pipe already.
In i915 we've removed all assumptions that pipe == crtc index. So should
igt.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-10 8:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 21:17 [igt-dev] [PATCH i-g-t 0/3] test/kms: Add support for display with non-contiguous pipes Mohammed Khajapasha
2020-03-07 21:17 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_kms: Set pipe enum name to a pipe from drm pipe Mohammed Khajapasha
2020-03-07 21:17 ` [igt-dev] [PATCH i-g-t 2/3] test/kms: Loop for enable pipes only in static iteration Mohammed Khajapasha
2020-06-01 9:14 ` [igt-dev] [i-g-t, " Arkadiusz Hiler
2020-03-07 21:17 ` [igt-dev] [PATCH i-g-t 3/3] kms/test: Pass correct pipe value to print pipe name Mohammed Khajapasha
2020-03-09 8:49 ` Jani Nikula
2020-03-10 5:52 ` Khajapasha, Mohammed
2020-03-10 8:20 ` Jani Nikula [this message]
2020-03-10 12:14 ` Ville Syrjälä
2020-03-17 5:11 ` Khajapasha, Mohammed
2020-03-17 12:36 ` Ville Syrjälä
2020-03-18 14:08 ` Khajapasha, Mohammed
2020-03-09 8:42 ` [igt-dev] ✗ Fi.CI.BUILD: failure for test/kms: Add support for display with non-contiguous pipes Patchwork
2020-03-09 8:57 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sk8oc32.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mohammed.khajapasha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox