From: Jani Nikula <jani.nikula@linux.intel.com>
To: Mohammed Khajapasha <mohammed.khajapasha@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 3/3] kms/test: Pass correct pipe value to print pipe name
Date: Mon, 09 Mar 2020 10:49:20 +0200 [thread overview]
Message-ID: <87d09lnca7.fsf@intel.com> (raw)
In-Reply-To: <20200307211751.22125-4-mohammed.khajapasha@intel.com>
On Sun, 08 Mar 2020, Mohammed Khajapasha <mohammed.khajapasha@intel.com> wrote:
> currently kmstest_pipe_name() fn gets the pipe index
> value to print the pipe name, but with non-contiguous
> display, pipe index is not always same as pipe name.
>
> for example: if PIPE_A is disabled in kernel, PIPE_B,C & D
> get registered with 0,1 & 2 indexes in mode config's crtc list
> and kmstest_pipe_name() always prints PIPE_A for 0 index
> which is actually PIPE_B in kernel.
IMO if you have enum pipe pipe in IGT, it should match the kernel pipe.
If you have crtc indexes in igt, then you should call them crtc indexes,
*not* pipes.
Otherwise you'll end up completely lost when a pipe is a pipe and when
it's not.
> igt_info("Running test on pipe %s with resolution %dx%d and sprite size %dx%d alpha %i\n",
> - kmstest_pipe_name(pipe), mode->hdisplay, mode->vdisplay,
> + kmstest_pipe_name(display->pipes[pipe].pipe), mode->hdisplay, mode->vdisplay,
For example in changes like this my only conclusion is that the pipe is
not really a pipe, but something else. So you should probably not call
it a pipe to begin with.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-09 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 21:17 [igt-dev] [PATCH i-g-t 0/3] test/kms: Add support for display with non-contiguous pipes Mohammed Khajapasha
2020-03-07 21:17 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_kms: Set pipe enum name to a pipe from drm pipe Mohammed Khajapasha
2020-03-07 21:17 ` [igt-dev] [PATCH i-g-t 2/3] test/kms: Loop for enable pipes only in static iteration Mohammed Khajapasha
2020-06-01 9:14 ` [igt-dev] [i-g-t, " Arkadiusz Hiler
2020-03-07 21:17 ` [igt-dev] [PATCH i-g-t 3/3] kms/test: Pass correct pipe value to print pipe name Mohammed Khajapasha
2020-03-09 8:49 ` Jani Nikula [this message]
2020-03-10 5:52 ` Khajapasha, Mohammed
2020-03-10 8:20 ` Jani Nikula
2020-03-10 12:14 ` Ville Syrjälä
2020-03-17 5:11 ` Khajapasha, Mohammed
2020-03-17 12:36 ` Ville Syrjälä
2020-03-18 14:08 ` Khajapasha, Mohammed
2020-03-09 8:42 ` [igt-dev] ✗ Fi.CI.BUILD: failure for test/kms: Add support for display with non-contiguous pipes Patchwork
2020-03-09 8:57 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d09lnca7.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mohammed.khajapasha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox