Re: [igt-dev] [PATCH] tests/xe/perf_pmu: Tests for the XE pmu interface

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 06 Oct 2023 02:31:19 -0700, Kumar, Janga Rahul wrote:
>

Hi Priyanka,

> > From: Dandamudi, Priyanka <priyanka.dandamudi@intel.com>
> > Sent: Friday, October 6, 2023 10:45 AM
> > To: Kumar, Janga Rahul <janga.rahul.kumar@intel.com>; igt-
> > dev@lists.freedesktop.org; Dandamudi, Priyanka
> > <priyanka.dandamudi@intel.com>
> > Subject: [PATCH] tests/xe/perf_pmu: Tests for the XE pmu interface
> >
> > From: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
> >
> > There are set of engine group busyness counters provided by HW which are
> > exposed via PMU events. Adding a basic unit tests to read those counters.
> >
> > v2: Added idle condition checks while reading the counters. (Rahul)
> >
> > v3: Moved test from tests/xe/ location to tests/intel.
> > Modified code to work for xe_exec_queue_create xe_spin_init changes.
> >
> > Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> > Signed-off-by: Venkata Ramana Nayana
> > <venkata.ramana.nayana@intel.com>
> > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
>
> Reviewed-by: Janga Rahul Kumar<janga.rahul.kumar@intel.com>

OK good that the original patch is reverted (though it should not have been
merged in the first place) so at least it fixed part the
drm_xe_exec_queue_get_property.

However this patch is still incorrect because you should do a 'make
headers_install' from the latest drm-xe-next kernel branch and then send
/that/ patch.

Ashutosh