Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH v3 i-g-t] tests/i915: Skip gem_exec_fair on GuC based platforms
@ 2021-10-15 21:54 John.C.Harrison
  2021-10-15 22:34 ` [igt-dev] [Intel-gfx] " Dixit, Ashutosh
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: John.C.Harrison @ 2021-10-15 21:54 UTC (permalink / raw)
  To: IGT-Dev; +Cc: Intel-GFX, John Harrison

From: John Harrison <John.C.Harrison@Intel.com>

The gem_exec_fair test is specifically testing scheduler algorithm
performance. However, GuC does not implement the same algorithm as
execlist mode and this test is not applicable. So, until sw arch
approves a new algorithm and it is implemented in GuC, stop running
the test.

v2: Add exceptions for TGL/RKL/ADL-S - review feedback from Tvrtko.
v3: Use the somewhat suspect submission test helpers instead - review
feedback from Ashutosh.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 tests/i915/gem_exec_fair.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/i915/gem_exec_fair.c b/tests/i915/gem_exec_fair.c
index ef5a450f6..5cbb48f5a 100644
--- a/tests/i915/gem_exec_fair.c
+++ b/tests/i915/gem_exec_fair.c
@@ -1314,6 +1314,12 @@ igt_main
 		igt_require(gem_scheduler_enabled(i915));
 		igt_require(gem_scheduler_has_ctx_priority(i915));
 
+		/*
+		 * These tests are for a specific scheduling model which is
+		 * not currently implemented by GuC. So skip on GuC platforms.
+		 */
+		igt_require(!gem_has_guc_submission(i915));
+
 		cfg = intel_ctx_cfg_all_physical(i915);
 
 		igt_info("CS timestamp frequency: %d\n",
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-16  3:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-15 21:54 [igt-dev] [PATCH v3 i-g-t] tests/i915: Skip gem_exec_fair on GuC based platforms John.C.Harrison
2021-10-15 22:34 ` [igt-dev] [Intel-gfx] " Dixit, Ashutosh
2021-10-15 22:48 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915: Skip gem_exec_fair on GuC based platforms (rev3) Patchwork
2021-10-16  3:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox