From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Badal Nilawar <badal.nilawar@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 0/4] i915/i915_hwmon: General verification of hwmon attributes
Date: Tue, 13 Dec 2022 19:11:33 -0800 [thread overview]
Message-ID: <87cz8mel22.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <87edt2enr6.wl-ashutosh.dixit@intel.com>
On Tue, 13 Dec 2022 18:13:17 -0800, Dixit, Ashutosh wrote:
>
> On Tue, 13 Dec 2022 10:37:24 -0800, Ashutosh Dixit wrote:
> >
> > Ensure we can read all hwmon attributes. For writable attributes, also
> > ensure the read value approximately matches the written value, taking the
> > clamping of writes into account.
> >
> > v2: Added new patch "lib/igt_sysfs: Make it easier to extend verification
> > of clamped sysfs attr". No changes to previous patches.
>
> Please do *NOT* review this or previous versions of these patches. I am
> sending out a new version with some changes soon.
Please review v4. In v4 I have dropped the concept of a 'clamped' sysfs
attribute, it is not necessary. All we need is a writable attribute for
which the read values will match the written values for a few points across
the range of all possible values.
So please don't review v1 through v3, please only review v4.
Thanks.
--
Ashutosh
next prev parent reply other threads:[~2022-12-14 3:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 18:37 [igt-dev] [PATCH i-g-t 0/4] i915/i915_hwmon: General verification of hwmon attributes Ashutosh Dixit
2022-12-13 18:37 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_sysfs: Generic verification of clamped sysfs attributes Ashutosh Dixit
2022-12-13 18:37 ` [igt-dev] [PATCH i-g-t 2/4] i915/i915_hwmon: General verification of hwmon attributes Ashutosh Dixit
2022-12-13 18:37 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_sysfs: Make it easier to extend verification of clamped sysfs attr Ashutosh Dixit
2022-12-13 18:37 ` [igt-dev] [PATCH i-g-t 4/4] HAX: Add i915_hwmon* to fast-feedback.testlist Ashutosh Dixit
2022-12-13 19:49 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/i915_hwmon: General verification of hwmon attributes (rev3) Patchwork
2022-12-14 2:13 ` [igt-dev] [PATCH i-g-t 0/4] i915/i915_hwmon: General verification of hwmon attributes Dixit, Ashutosh
2022-12-14 3:11 ` Dixit, Ashutosh [this message]
2022-12-14 23:57 ` [igt-dev] ✓ Fi.CI.IGT: success for i915/i915_hwmon: General verification of hwmon attributes (rev3) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-12-13 18:35 [igt-dev] [PATCH i-g-t 0/4] i915/i915_hwmon: General verification of hwmon attributes Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz8mel22.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=badal.nilawar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox