[igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Vidya Srinivas]

When the plane scaling is used with YUV 420 planar formats,
the height should be a minimum of 16 scanlines as per BSpec.
Minimum of 8 scanlines is for non-YUV 420 planar formats.
Patch changes the minimum fb height being used in the test
in case of YUV 420 planar (currently done for NV12, as
that is the only planar format supported)

v2: Addressed review comments from Maarten

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_scaling.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 4408e5c..36fcfc0 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
 
 	/* create buffer in the range of  min and max source side limit.*/
 	width = height = 9;
+	if (pixel_format == DRM_FORMAT_NV12)
+		width = height = 17;
 	igt_create_color_fb(display->drm_fd, width, height,
 		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
 	igt_plane_set_fb(plane, &d->fb[0]);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar (rev2)

[Patchwork]

== Series Details ==

Series: tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar (rev2)
URL   : https://patchwork.freedesktop.org/series/39433/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
5c146fcff2d51ea426efc538599013e887fe456b tests/kms_pipe_crc_basic: Remove legacy crc tests

with latest DRM-Tip kernel build CI_DRM_3931
178cfb9373cc drm-tip: 2018y-03m-14d-21h-38m-09s UTC integration manifest

No testlist changes.

---- Known issues:

Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:432s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:444s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:381s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:537s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:297s
fi-bxt-dsi       total:285  pass:255  dwarn:0   dfail:0   fail:0   skip:30  time:518s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:519s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:504s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:410s
fi-cfl-s2        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:584s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:516s
fi-cnl-y3        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:586s
fi-elk-e7500     total:285  pass:226  dwarn:0   dfail:0   fail:0   skip:59  time:426s
fi-gdg-551       total:285  pass:177  dwarn:0   dfail:0   fail:0   skip:108 time:316s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:540s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:403s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:425s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:473s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:428s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:479s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:470s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:516s
fi-pnv-d510      total:285  pass:219  dwarn:1   dfail:0   fail:0   skip:65  time:654s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:442s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:528s
fi-skl-6700hq    total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:540s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:509s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:486s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:429s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:445s
fi-snb-2520m     total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:580s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:406s
Blacklisted hosts:
fi-cnl-drrs      total:285  pass:254  dwarn:3   dfail:0   fail:0   skip:28  time:533s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1130/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar (rev2)

[Patchwork]

== Series Details ==

Series: tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar (rev2)
URL   : https://patchwork.freedesktop.org/series/39433/
State : success

== Summary ==

---- Possible new issues:

Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-primscrn-pri-shrfb-draw-render:
                fail       -> PASS       (shard-apl)

---- Known issues:

Test gem_exec_suspend:
        Subgroup basic-s3:
                pass       -> SKIP       (shard-snb) fdo#104311
Test kms_flip:
        Subgroup modeset-vs-vblank-race-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#103060
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
                pass       -> FAIL       (shard-apl) fdo#103167

fdo#104311 https://bugs.freedesktop.org/show_bug.cgi?id=104311
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167

shard-apl        total:3375 pass:1779 dwarn:1   dfail:0   fail:8   skip:1585 time:12536s
shard-hsw        total:3441 pass:1765 dwarn:1   dfail:0   fail:3   skip:1671 time:11939s
shard-snb        total:3441 pass:1356 dwarn:1   dfail:0   fail:2   skip:2082 time:7253s
Blacklisted hosts:
shard-kbl        total:3305 pass:1845 dwarn:21  dfail:0   fail:8   skip:1429 time:9279s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1130/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Jani Nikula]

On Thu, 15 Mar 2018, Vidya Srinivas <vidya.srinivas@intel.com> wrote:
> When the plane scaling is used with YUV 420 planar formats,
> the height should be a minimum of 16 scanlines as per BSpec.
> Minimum of 8 scanlines is for non-YUV 420 planar formats.
> Patch changes the minimum fb height being used in the test
> in case of YUV 420 planar (currently done for NV12, as
> that is the only planar format supported)
>
> v2: Addressed review comments from Maarten

This doesn't really say anything meaningful. In the future, please state
the actual changes.

> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_scaling.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 4408e5c..36fcfc0 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>  
>  	/* create buffer in the range of  min and max source side limit.*/
>  	width = height = 9;
> +	if (pixel_format == DRM_FORMAT_NV12)
> +		width = height = 17;

IMO it's easier to read when you have an if-else instead of overwriting
the previous values in some cases.

BR,
Jani.

>  	igt_create_color_fb(display->drm_fd, width, height,
>  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>  	igt_plane_set_fb(plane, &d->fb[0]);

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Srinivas, Vidya]

> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Thursday, March 15, 2018 4:21 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Kamath, Sunil <sunil.kamath@intel.com>; Syrjala, Ville
> <ville.syrjala@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change
> minimum fb height for YUV 420 planar
> 
> On Thu, 15 Mar 2018, Vidya Srinivas <vidya.srinivas@intel.com> wrote:
> > When the plane scaling is used with YUV 420 planar formats, the height
> > should be a minimum of 16 scanlines as per BSpec.
> > Minimum of 8 scanlines is for non-YUV 420 planar formats.
> > Patch changes the minimum fb height being used in the test in case of
> > YUV 420 planar (currently done for NV12, as that is the only planar
> > format supported)
> >
> > v2: Addressed review comments from Maarten
> 
> This doesn't really say anything meaningful. In the future, please state the
> actual changes.
> 
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> >  tests/kms_plane_scaling.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index 4408e5c..36fcfc0 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t
> > *d, igt_plane_t *plane,
> >
> >  	/* create buffer in the range of  min and max source side limit.*/
> >  	width = height = 9;
> > +	if (pixel_format == DRM_FORMAT_NV12)
> > +		width = height = 17;
> 
> IMO it's easier to read when you have an if-else instead of overwriting the
> previous values in some cases.
> 

Sorry about that. I see the patch is merged already.
When I push any other patch, will address this issue.

Regards
Vidya

> BR,
> Jani.
> 
> >  	igt_create_color_fb(display->drm_fd, width, height,
> >  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> >  	igt_plane_set_fb(plane, &d->fb[0]);
> 
> --
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Jani Nikula]

On Fri, 16 Mar 2018, "Srinivas, Vidya" <vidya.srinivas@intel.com> wrote:
>> -----Original Message-----
>> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>> Sent: Thursday, March 15, 2018 4:21 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
>> Cc: Kamath, Sunil <sunil.kamath@intel.com>; Syrjala, Ville
>> <ville.syrjala@intel.com>
>> Subject: Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change
>> minimum fb height for YUV 420 planar
>> 
>> On Thu, 15 Mar 2018, Vidya Srinivas <vidya.srinivas@intel.com> wrote:
>> > When the plane scaling is used with YUV 420 planar formats, the height
>> > should be a minimum of 16 scanlines as per BSpec.
>> > Minimum of 8 scanlines is for non-YUV 420 planar formats.
>> > Patch changes the minimum fb height being used in the test in case of
>> > YUV 420 planar (currently done for NV12, as that is the only planar
>> > format supported)
>> >
>> > v2: Addressed review comments from Maarten
>> 
>> This doesn't really say anything meaningful. In the future, please state the
>> actual changes.
>> 
>> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>> > ---
>> >  tests/kms_plane_scaling.c | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>> > index 4408e5c..36fcfc0 100644
>> > --- a/tests/kms_plane_scaling.c
>> > +++ b/tests/kms_plane_scaling.c
>> > @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t
>> > *d, igt_plane_t *plane,
>> >
>> >  	/* create buffer in the range of  min and max source side limit.*/
>> >  	width = height = 9;
>> > +	if (pixel_format == DRM_FORMAT_NV12)
>> > +		width = height = 17;
>> 
>> IMO it's easier to read when you have an if-else instead of overwriting the
>> previous values in some cases.
>> 
>
> Sorry about that. I see the patch is merged already.
> When I push any other patch, will address this issue.

Hey, no apologies necessary. Maarten already did the important part of
reviewing the functionality, this was just me opinioning on style.

BR,
Jani.

>
> Regards
> Vidya
>
>> BR,
>> Jani.
>> 
>> >  	igt_create_color_fb(display->drm_fd, width, height,
>> >  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>> >  	igt_plane_set_fb(plane, &d->fb[0]);
>> 
>> --
>> Jani Nikula, Intel Open Source Technology Center

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Srinivas, Vidya]

> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> Sent: Friday, March 16, 2018 1:20 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Kamath, Sunil <sunil.kamath@intel.com>; Syrjala, Ville
> <ville.syrjala@intel.com>
> Subject: RE: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change
> minimum fb height for YUV 420 planar
> 
> On Fri, 16 Mar 2018, "Srinivas, Vidya" <vidya.srinivas@intel.com> wrote:
> >> -----Original Message-----
> >> From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
> >> Sent: Thursday, March 15, 2018 4:21 PM
> >> To: Srinivas, Vidya <vidya.srinivas@intel.com>;
> >> igt-dev@lists.freedesktop.org
> >> Cc: Kamath, Sunil <sunil.kamath@intel.com>; Syrjala, Ville
> >> <ville.syrjala@intel.com>
> >> Subject: Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling:
> >> Change minimum fb height for YUV 420 planar
> >>
> >> On Thu, 15 Mar 2018, Vidya Srinivas <vidya.srinivas@intel.com> wrote:
> >> > When the plane scaling is used with YUV 420 planar formats, the
> >> > height should be a minimum of 16 scanlines as per BSpec.
> >> > Minimum of 8 scanlines is for non-YUV 420 planar formats.
> >> > Patch changes the minimum fb height being used in the test in case
> >> > of YUV 420 planar (currently done for NV12, as that is the only
> >> > planar format supported)
> >> >
> >> > v2: Addressed review comments from Maarten
> >>
> >> This doesn't really say anything meaningful. In the future, please
> >> state the actual changes.
> >>
> >> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> >> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> >> > ---
> >> >  tests/kms_plane_scaling.c | 2 ++
> >> >  1 file changed, 2 insertions(+)
> >> >
> >> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> >> > index 4408e5c..36fcfc0 100644
> >> > --- a/tests/kms_plane_scaling.c
> >> > +++ b/tests/kms_plane_scaling.c
> >> > @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t
> >> > *d, igt_plane_t *plane,
> >> >
> >> >  	/* create buffer in the range of  min and max source side limit.*/
> >> >  	width = height = 9;
> >> > +	if (pixel_format == DRM_FORMAT_NV12)
> >> > +		width = height = 17;
> >>
> >> IMO it's easier to read when you have an if-else instead of
> >> overwriting the previous values in some cases.
> >>
> >
> > Sorry about that. I see the patch is merged already.
> > When I push any other patch, will address this issue.
> 
> Hey, no apologies necessary. Maarten already did the important part of
> reviewing the functionality, this was just me opinioning on style.
> 

Thank you :) Thanks to Maarten too :)

Regards
Vidya

> BR,
> Jani.
> 
> >
> > Regards
> > Vidya
> >
> >> BR,
> >> Jani.
> >>
> >> >  	igt_create_color_fb(display->drm_fd, width, height,
> >> >  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> >> >  	igt_plane_set_fb(plane, &d->fb[0]);
> >>
> >> --
> >> Jani Nikula, Intel Open Source Technology Center
> 
> --
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Maarten Lankhorst]

Op 15-03-18 om 06:42 schreef Vidya Srinivas:
> When the plane scaling is used with YUV 420 planar formats,
> the height should be a minimum of 16 scanlines as per BSpec.
> Minimum of 8 scanlines is for non-YUV 420 planar formats.
> Patch changes the minimum fb height being used in the test
> in case of YUV 420 planar (currently done for NV12, as
> that is the only planar format supported)
>
> v2: Addressed review comments from Maarten
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_scaling.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 4408e5c..36fcfc0 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>  
>  	/* create buffer in the range of  min and max source side limit.*/
>  	width = height = 9;
> +	if (pixel_format == DRM_FORMAT_NV12)
> +		width = height = 17;
>  	igt_create_color_fb(display->drm_fd, width, height,
>  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>  	igt_plane_set_fb(plane, &d->fb[0]);

No way that CI can test this currently. so pushed. :)

Thanks for the patch.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Srinivas, Vidya]

Hi Maarten,

Apologies :(

From the CI results, I checked that when 17x17 buffer is requested, KMD makes it 16  and
again the check fails (which we added in skl_update_scaler in range check) and due to this we see igt exits
from pixel format test of kms_plane_scaling.

Also for underruns:
Until I give a multiplier of 4 (which will be > 16), it would take 16 only and hence the fifo underruns.

From BSpec: Display WA 1106:
Display corruption/color shift observed when using NV12 with 270 rotation or 90 rotation + horizontal flip.
WA: NV12 with 270 rotation or 90 rotation + horizontal flip requires the programmed plane height to be a multiple of 4.

We need to set width = height = 20 in i-g-t. I will send a FIXME patch. Can you please help merge?

Sorry, trybot did not catch it then as it considered the older i-g-t and showed scaler out of range for 9x9
And I assumed everything is right/expected.

Regards
Vidya


> -----Original Message-----
> From: Maarten Lankhorst [mailto:maarten.lankhorst@linux.intel.com]
> Sent: Thursday, March 15, 2018 10:33 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Kamath, Sunil <sunil.kamath@intel.com>; Syrjala, Ville
> <ville.syrjala@intel.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: Re: [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum
> fb height for YUV 420 planar
> 
> Op 15-03-18 om 06:42 schreef Vidya Srinivas:
> > When the plane scaling is used with YUV 420 planar formats, the height
> > should be a minimum of 16 scanlines as per BSpec.
> > Minimum of 8 scanlines is for non-YUV 420 planar formats.
> > Patch changes the minimum fb height being used in the test in case of
> > YUV 420 planar (currently done for NV12, as that is the only planar
> > format supported)
> >
> > v2: Addressed review comments from Maarten
> >
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> >  tests/kms_plane_scaling.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index 4408e5c..36fcfc0 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t
> > *d, igt_plane_t *plane,
> >
> >  	/* create buffer in the range of  min and max source side limit.*/
> >  	width = height = 9;
> > +	if (pixel_format == DRM_FORMAT_NV12)
> > +		width = height = 17;
> >  	igt_create_color_fb(display->drm_fd, width, height,
> >  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> >  	igt_plane_set_fb(plane, &d->fb[0]);
> 
> No way that CI can test this currently. so pushed. :)
> 
> Thanks for the patch.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Vidya Srinivas]

When the plane scaling is used with YUV 420 planar formats,
the height should be a minimum of 16 scanlines as per BSpec
Minimum of 8 scanlines is for non-YUV 420 planar formats.
Patch changes the minimum fb height being used in the test
in case of YUV 420 planar (for now NV12 as only that is supported).

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_scaling.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 4408e5c..cf49015 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
 
 	/* create buffer in the range of  min and max source side limit.*/
 	width = height = 9;
+	if (pixel_format == DRM_FORMAT_NV12)
+		height = 16;
 	igt_create_color_fb(display->drm_fd, width, height,
 		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
 	igt_plane_set_fb(plane, &d->fb[0]);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Maarten Lankhorst]

Op 06-03-18 om 10:21 schreef Vidya Srinivas:
> When the plane scaling is used with YUV 420 planar formats,
> the height should be a minimum of 16 scanlines as per BSpec
> Minimum of 8 scanlines is for non-YUV 420 planar formats.
> Patch changes the minimum fb height being used in the test
> in case of YUV 420 planar (for now NV12 as only that is supported).
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_scaling.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 4408e5c..cf49015 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>  
>  	/* create buffer in the range of  min and max source side limit.*/
>  	width = height = 9;
> +	if (pixel_format == DRM_FORMAT_NV12)
> +		height = 16;
>  	igt_create_color_fb(display->drm_fd, width, height,
>  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>  	igt_plane_set_fb(plane, &d->fb[0]);

Could we set height to 17 for all?

~Maarten

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Srinivas, Vidya]

> -----Original Message-----
> From: Maarten Lankhorst [mailto:maarten.lankhorst@linux.intel.com]
> Sent: Tuesday, March 6, 2018 3:23 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Kamath, Sunil <sunil.kamath@intel.com>; Syrjala, Ville
> <ville.syrjala@intel.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: Re: [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum
> fb height for YUV 420 planar
> 
> Op 06-03-18 om 10:21 schreef Vidya Srinivas:
> > When the plane scaling is used with YUV 420 planar formats, the height
> > should be a minimum of 16 scanlines as per BSpec Minimum of 8
> > scanlines is for non-YUV 420 planar formats.
> > Patch changes the minimum fb height being used in the test in case of
> > YUV 420 planar (for now NV12 as only that is supported).
> >
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> >  tests/kms_plane_scaling.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index 4408e5c..cf49015 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t
> > *d, igt_plane_t *plane,
> >
> >  	/* create buffer in the range of  min and max source side limit.*/
> >  	width = height = 9;
> > +	if (pixel_format == DRM_FORMAT_NV12)
> > +		height = 16;
> >  	igt_create_color_fb(display->drm_fd, width, height,
> >  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> >  	igt_plane_set_fb(plane, &d->fb[0]);
> 
> Could we set height to 17 for all?
> 
> ~Maarten

Hi Maarten. We can. But since min for non-YUV was 8, we thought
the purpose of the test was to create the minimal possible buffer.
So we dint change that. What do you suggest? Please let us know.

Regards
Vidya

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Maarten Lankhorst]

Op 06-03-18 om 11:15 schreef Srinivas, Vidya:
>
>> -----Original Message-----
>> From: Maarten Lankhorst [mailto:maarten.lankhorst@linux.intel.com]
>> Sent: Tuesday, March 6, 2018 3:23 PM
>> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
>> Cc: Kamath, Sunil <sunil.kamath@intel.com>; Syrjala, Ville
>> <ville.syrjala@intel.com>; Shankar, Uma <uma.shankar@intel.com>
>> Subject: Re: [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum
>> fb height for YUV 420 planar
>>
>> Op 06-03-18 om 10:21 schreef Vidya Srinivas:
>>> When the plane scaling is used with YUV 420 planar formats, the height
>>> should be a minimum of 16 scanlines as per BSpec Minimum of 8
>>> scanlines is for non-YUV 420 planar formats.
>>> Patch changes the minimum fb height being used in the test in case of
>>> YUV 420 planar (for now NV12 as only that is supported).
>>>
>>> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>>> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
>>> ---
>>>  tests/kms_plane_scaling.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
>>> index 4408e5c..cf49015 100644
>>> --- a/tests/kms_plane_scaling.c
>>> +++ b/tests/kms_plane_scaling.c
>>> @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t
>>> *d, igt_plane_t *plane,
>>>
>>>  	/* create buffer in the range of  min and max source side limit.*/
>>>  	width = height = 9;
>>> +	if (pixel_format == DRM_FORMAT_NV12)
>>> +		height = 16;
>>>  	igt_create_color_fb(display->drm_fd, width, height,
>>>  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>>>  	igt_plane_set_fb(plane, &d->fb[0]);
>> Could we set height to 17 for all?
>>
>> ~Maarten
> Hi Maarten. We can. But since min for non-YUV was 8, we thought
> the purpose of the test was to create the minimal possible buffer.
> So we dint change that. What do you suggest? Please let us know.
>
> Regards
> Vidya
>
Allow igt_create_fb_with_bo_size to fail, but not kms_addfb, then handle its failure in kms_frontbuffer_tracking

and then do something like this:


for (height = 1; height < 1024; height *= 2) {

if (igt_create_fb_with_bo_size(height + 1, height + 1) > 0)

        break;

}

igt_assert(height < 1024);

width = ++height;

This should work regardless of format..

~Maarten

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Maarten Lankhorst]

Op 06-03-18 om 10:21 schreef Vidya Srinivas:
> When the plane scaling is used with YUV 420 planar formats,
> the height should be a minimum of 16 scanlines as per BSpec
> Minimum of 8 scanlines is for non-YUV 420 planar formats.
> Patch changes the minimum fb height being used in the test
> in case of YUV 420 planar (for now NV12 as only that is supported).
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
>  tests/kms_plane_scaling.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 4408e5c..cf49015 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>  
>  	/* create buffer in the range of  min and max source side limit.*/
>  	width = height = 9;
> +	if (pixel_format == DRM_FORMAT_NV12)
> +		height = 16;
>  	igt_create_color_fb(display->drm_fd, width, height,
>  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>  	igt_plane_set_fb(plane, &d->fb[0]);

And shouldn't we reject this in the kernel?

~Maarten

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum fb height for YUV 420 planar

[Srinivas, Vidya]

> -----Original Message-----
> From: Maarten Lankhorst [mailto:maarten.lankhorst@linux.intel.com]
> Sent: Tuesday, March 6, 2018 3:24 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Kamath, Sunil <sunil.kamath@intel.com>; Syrjala, Ville
> <ville.syrjala@intel.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: Re: [PATCH i-g-t] [i-g-t] tests/kms_plane_scaling: Change minimum
> fb height for YUV 420 planar
> 
> Op 06-03-18 om 10:21 schreef Vidya Srinivas:
> > When the plane scaling is used with YUV 420 planar formats, the height
> > should be a minimum of 16 scanlines as per BSpec Minimum of 8
> > scanlines is for non-YUV 420 planar formats.
> > Patch changes the minimum fb height being used in the test in case of
> > YUV 420 planar (for now NV12 as only that is supported).
> >
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> >  tests/kms_plane_scaling.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index 4408e5c..cf49015 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -131,6 +131,8 @@ static void check_scaling_pipe_plane_rot(data_t
> > *d, igt_plane_t *plane,
> >
> >  	/* create buffer in the range of  min and max source side limit.*/
> >  	width = height = 9;
> > +	if (pixel_format == DRM_FORMAT_NV12)
> > +		height = 16;
> >  	igt_create_color_fb(display->drm_fd, width, height,
> >  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
> >  	igt_plane_set_fb(plane, &d->fb[0]);
> 
> And shouldn't we reject this in the kernel?
> 
> ~Maarten

Hi Maarten. We should. We will be doing that also and refloat the series tomorrow.

Thanks
Vidya
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev