Re: [igt-dev] [i-g-t] tests/i915/gem_media_vme : skip on no media Samplers

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 29 Dec 2021 16:46:01 -0800, Katragadda, MastanX wrote:
>
> Moved this check to   igt_get_media_vme_func is it fine ?

No. Look at the code.

> igt_vme_func_t fill = NULL;
> +       const struct intel_device_info *devinfo = intel_get_device_info(devid);
> +
> +       igt_skip_on_f(devinfo->is_elkhartlake || devinfo->is_jasperlake,
> +                       "media-vme samplers not present\n");
>
>         if (IS_GEN11(devid))
>                 fill = gen11_media_vme_func;
>
> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: 30 December 2021 02:04
> To: Katragadda, MastanX <mastanx.katragadda@intel.com>
> Cc: igt-dev@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>; Ye, Tony <tony.ye@intel.com>
> Subject: Re: [igt-dev] [i-g-t] tests/i915/gem_media_vme : skip on no media Samplers
>
> On Wed, 29 Dec 2021 06:42:51 -0800, Mastan Katragadda wrote:
> >
> > Media sampers are not present on some of Gen11 platforms adding skip
> > on EHL and JSL as per Bspec.
> >
> > Bspec:29151
> >
> > Signed-off-by: Mastan Katragadda <mastanx.katragadda@intel.com>
> > ---
> >  tests/i915/gem_media_vme.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/tests/i915/gem_media_vme.c b/tests/i915/gem_media_vme.c
> > index 3ea70386..29e0fda3 100644
> > --- a/tests/i915/gem_media_vme.c
> > +++ b/tests/i915/gem_media_vme.c
> > @@ -90,6 +90,15 @@ static void shut_non_vme_subslices(int drm_fd,
> > uint32_t ctx)
> >
> >       gem_context_set_param(drm_fd, &arg);
> >  }
> > +static bool is_jsl_ehl(uint32_t devid) {
> > +     const struct intel_device_info *devinfo =
> > +intel_get_device_info(devid);
> > +
> > +     if (devinfo->is_elkhartlake || devinfo->is_jasperlake)
> > +             return true;
> > +
> > +     return false;
> > +}
> >
> >  igt_simple_main
> >  {
> > @@ -104,6 +113,8 @@ igt_simple_main
> >
> >       devid = intel_get_drm_devid(drm_fd);
> >
> > +     igt_skip_on_f(is_jsl_ehl(devid), "media-vme samplers not
> > +present\n");
> > +
> >       media_vme = igt_get_media_vme_func(devid);
> >       igt_require_f(media_vme, "no media-vme function\n");
>
> I think we should just add the checks to igt_get_media_vme_func().