Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Mastan Katragadda <mastanx.katragadda@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [i-g-t] tests/i915/gem_media_vme : skip on no media Samplers
Date: Wed, 29 Dec 2021 12:34:21 -0800	[thread overview]
Message-ID: <87lf039mlu.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20211229144251.3709751-1-mastanx.katragadda@intel.com>

On Wed, 29 Dec 2021 06:42:51 -0800, Mastan Katragadda wrote:
>
> Media sampers are not present on some of Gen11 platforms adding
> skip on EHL and JSL as per Bspec.
>
> Bspec:29151
>
> Signed-off-by: Mastan Katragadda <mastanx.katragadda@intel.com>
> ---
>  tests/i915/gem_media_vme.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/tests/i915/gem_media_vme.c b/tests/i915/gem_media_vme.c
> index 3ea70386..29e0fda3 100644
> --- a/tests/i915/gem_media_vme.c
> +++ b/tests/i915/gem_media_vme.c
> @@ -90,6 +90,15 @@ static void shut_non_vme_subslices(int drm_fd, uint32_t ctx)
>
>	gem_context_set_param(drm_fd, &arg);
>  }
> +static bool is_jsl_ehl(uint32_t devid)
> +{
> +	const struct intel_device_info *devinfo = intel_get_device_info(devid);
> +
> +	if (devinfo->is_elkhartlake || devinfo->is_jasperlake)
> +		return true;
> +
> +	return false;
> +}
>
>  igt_simple_main
>  {
> @@ -104,6 +113,8 @@ igt_simple_main
>
>	devid = intel_get_drm_devid(drm_fd);
>
> +	igt_skip_on_f(is_jsl_ehl(devid), "media-vme samplers not present\n");
> +
>	media_vme = igt_get_media_vme_func(devid);
>	igt_require_f(media_vme, "no media-vme function\n");

I think we should just add the checks to igt_get_media_vme_func().

  parent reply	other threads:[~2021-12-29 20:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 14:42 [igt-dev] [i-g-t] tests/i915/gem_media_vme : skip on no media Samplers Mastan Katragadda
2021-12-29 15:42 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-12-29 17:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-12-29 20:34 ` Dixit, Ashutosh [this message]
2021-12-30  0:46   ` [igt-dev] [i-g-t] " Katragadda, MastanX
2021-12-30  0:54     ` Ye, Tony
2021-12-30  1:06       ` Katragadda, MastanX
2021-12-30  0:55     ` Dixit, Ashutosh
  -- strict thread matches above, loose matches on Subject: below --
2021-12-30  2:09 Mastan Katragadda
2021-12-30  4:29 ` Ye, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf039mlu.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mastanx.katragadda@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox